Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 24 Mar 2023 16:54:18 +0100
From:   Marc Kleine-Budde <mkl@pengutronix.de>
To:     Dario Binacchi <dario.binacchi@amarulasolutions.com>
Cc:     linux-kernel@vger.kernel.org,
        Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
        Amarula patchwork <linux-amarula@amarulasolutions.com>,
        Vincent Mailhol <mailhol.vincent@wanadoo.fr>,
        Alexandre Torgue <alexandre.torgue@foss.st.com>,
        michael@amarulasolutions.com, Rob Herring <robh@kernel.org>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        Wolfgang Grandegger <wg@grandegger.com>,
        linux-can@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [RESEND PATCH v7 5/5] can: bxcan: add support for ST bxCAN
 controller
Message-ID: <20230324155418.nn44wxwjjjiqqhdf@pengutronix.de>
References: <20230315211040.2455855-1-dario.binacchi@amarulasolutions.com>
 <20230315211040.2455855-6-dario.binacchi@amarulasolutions.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="cpmjthz5s44cl3qg"
Content-Disposition: inline
In-Reply-To: <20230315211040.2455855-6-dario.binacchi@amarulasolutions.com>
Precedence: bulk


--cpmjthz5s44cl3qg
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On 15.03.2023 22:10:40, Dario Binacchi wrote:
[...]

> +static int __maybe_unused bxcan_suspend(struct device *dev)
> +{
> +	struct net_device *ndev =3D dev_get_drvdata(dev);
> +	struct bxcan_priv *priv =3D netdev_priv(ndev);
> +
> +	if (!netif_running(ndev))
> +		return 0;
> +
> +	netif_stop_queue(ndev);
> +	netif_device_detach(ndev);
> +
> +	bxcan_enter_sleep_mode(priv);
> +	priv->can.state =3D CAN_STATE_SLEEPING;
> +	clk_disable_unprepare(priv->clk);

The driver enabled the clock in probe, right? So in case the interface
is down you don't disable the clock and keep it running during
suspend. Is this a problem?

You can disable the clock in probe and enable it in open/disable in
close.

> +	return 0;
> +}

regards,
Marc

--=20
Pengutronix e.K.                 | Marc Kleine-Budde           |
Embedded Linux                   | https://www.pengutronix.de  |
Vertretung N=C3=BCrnberg              | Phone: +49-5121-206917-129  |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-5555 |

--cpmjthz5s44cl3qg
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEDs2BvajyNKlf9TJQvlAcSiqKBOgFAmQdx6cACgkQvlAcSiqK
BOhIzAf/QrMxYd4klMcThRsnQ4udN8k2Eaj/CiWuJ172yNqr0dk3sAwYuvvpbwal
R1HzHoAkcTECNx+HOmGYSmZKNDONrWm84brl+wsZPSPIY1BmguVe3MyDKVD8Hv5/
Mu8eMml9CzKNdvV6n1GpCiCOGl4QTAJzRxVmzJ7QH1UTlXSWj8z0jh3JEP/SBp5Q
uyZM4JyS+UbFCz6Ic5Vdnod+1kGJfC9oN8hYkp91s1WEmGkYvZjWzrK1Etuycch0
Sugr0VPvKlxSQ8Mi0heuO7ms09iF3pgs1k6SVSpKHhNAEXS/wTmdT4IHQqljaPDR
o9JdAlJOEEXmCRL+Bb/AwISMZSv2uA==
=8O6F
-----END PGP SIGNATURE-----

--cpmjthz5s44cl3qg--