Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Nicolas Schichan <nschichan@freebox.fr>
To:     chengzhihao1@huawei.com
Cc:     george.kennedy@oracle.com, linux-kernel@vger.kernel.org,
        linux-mtd@lists.infradead.org, miquel.raynal@bootlin.com,
        richard@nod.at, s.hauer@pengutronix.de, yi.zhang@huawei.com,
        Nicolas Schichan <nschichan@freebox.fr>
Subject: [PATCH -next v3] ubi: Fix failure attaching when vid_hdr offset equals to (sub)page size
Date:   Fri, 24 Mar 2023 17:19:24 +0100
Message-Id: <20230324161923.1456371-1-nschichan@freebox.fr>
In-Reply-To: <20230306013308.3884777-1-chengzhihao1@huawei.com>
References: <20230306013308.3884777-1-chengzhihao1@huawei.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Precedence: bulk


> Following process will make ubi attaching failed since commit
> 1b42b1a36fc946 ("ubi: ensure that VID header offset ... size"):
>
> ID="0xec,0xa1,0x00,0x15" # 128M 128KB 2KB
> modprobe nandsim id_bytes=$ID
> flash_eraseall /dev/mtd0
> modprobe ubi mtd="0,2048"  # set vid_hdr offset as 2048 (one page)
> (dmesg):
>   ubi0 error: ubi_attach_mtd_dev [ubi]: VID header offset 2048 too large.
>   UBI error: cannot attach mtd0
>   UBI error: cannot initialize UBI, error -22
>
> Rework original solution, the key point is making sure
> 'vid_hdr_shift + UBI_VID_HDR_SIZE < ubi->vid_hdr_alsize',
> so we should check vid_hdr_shift rather not vid_hdr_offset.
> Then, ubi still support (sub)page aligined VID header offset.
>
> Fixes: 1b42b1a36fc946 ("ubi: ensure that VID header offset ... size")
> Signed-off-by: Zhihao Cheng <chengzhihao1@huawei.com>
> ---
>  v2->v3: Use printing format '%zu' for UBI_VID_HDR_SIZE.
>  drivers/mtd/ubi/build.c | 21 +++++++++++++++------
>  1 file changed, 15 insertions(+), 6 deletions(-)

[...]

Hello,

Having had the problem, and found this patch as a fix, feel free to
add my:

Tested-by: Nicolas Schichan <nschichan@freebox.fr>

-- 
Nicolas Schichan