Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 24 Mar 2023 17:25:28 +0100
From:   Miquel Raynal <miquel.raynal@bootlin.com>
To:     Christophe Kerello <christophe.kerello@foss.st.com>
Cc:     <richard@nod.at>, <vigneshr@ti.com>,
        <linux-mtd@lists.infradead.org>, <linux-kernel@vger.kernel.org>,
        <linux-stm32@st-md-mailman.stormreply.com>
Subject: Re: [PATCH] mtd: rawnand: stm32_fmc2: do not support EDO mode
Message-ID: <20230324172528.4d3ccd4b@xps-13>
In-Reply-To: <20230324160918.826452-1-christophe.kerello@foss.st.com>
References: <20230324160918.826452-1-christophe.kerello@foss.st.com>
Organization: Bootlin
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Hi Christophe,

christophe.kerello@foss.st.com wrote on Fri, 24 Mar 2023 17:09:18 +0100:

> FMC2 controller does not support EDO mode (timings mode 4 and 5).
>=20
> Signed-off-by: Christophe Kerello <christophe.kerello@foss.st.com>
> Fixes: 2cd457f328c1 ("mtd: rawnand: stm32_fmc2: add STM32 FMC2 NAND flash=
 controller driver")
> ---
>  drivers/mtd/nand/raw/stm32_fmc2_nand.c | 3 +++
>  1 file changed, 3 insertions(+)
>=20
> diff --git a/drivers/mtd/nand/raw/stm32_fmc2_nand.c b/drivers/mtd/nand/ra=
w/stm32_fmc2_nand.c
> index 5d627048c420..3abb63d00a0b 100644
> --- a/drivers/mtd/nand/raw/stm32_fmc2_nand.c
> +++ b/drivers/mtd/nand/raw/stm32_fmc2_nand.c
> @@ -1531,6 +1531,9 @@ static int stm32_fmc2_nfc_setup_interface(struct na=
nd_chip *chip, int chipnr,
>  	if (IS_ERR(sdrt))
>  		return PTR_ERR(sdrt);
> =20
> +	if (sdrt->tRC_min < 30000)

When introducing NV-DDR support we as well added a timings.mode field,
perhaps you could use it?

> +		return -EOPNOTSUPP;
> +
>  	if (chipnr =3D=3D NAND_DATA_IFACE_CHECK_ONLY)
>  		return 0;
> =20


Thanks,
Miqu=C3=A8l