Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <f4c32aa5-e5b1-6465-7708-ef0281baf0af@foss.st.com>
Date:   Fri, 24 Mar 2023 17:34:14 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.8.0
Subject: Re: [PATCH] mtd: rawnand: stm32_fmc2: do not support EDO mode
Content-Language: en-US
To:     Miquel Raynal <miquel.raynal@bootlin.com>
CC:     <richard@nod.at>, <vigneshr@ti.com>,
        <linux-mtd@lists.infradead.org>, <linux-kernel@vger.kernel.org>,
        <linux-stm32@st-md-mailman.stormreply.com>
References: <20230324160918.826452-1-christophe.kerello@foss.st.com>
 <20230324172528.4d3ccd4b@xps-13>
From:   Christophe Kerello <christophe.kerello@foss.st.com>
In-Reply-To: <20230324172528.4d3ccd4b@xps-13>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk

Hello Miquel,

On 3/24/23 17:25, Miquel Raynal wrote:
> Hi Christophe,
> 
> christophe.kerello@foss.st.com wrote on Fri, 24 Mar 2023 17:09:18 +0100:
> 
>> FMC2 controller does not support EDO mode (timings mode 4 and 5).
>>
>> Signed-off-by: Christophe Kerello <christophe.kerello@foss.st.com>
>> Fixes: 2cd457f328c1 ("mtd: rawnand: stm32_fmc2: add STM32 FMC2 NAND flash controller driver")
>> ---
>>   drivers/mtd/nand/raw/stm32_fmc2_nand.c | 3 +++
>>   1 file changed, 3 insertions(+)
>>
>> diff --git a/drivers/mtd/nand/raw/stm32_fmc2_nand.c b/drivers/mtd/nand/raw/stm32_fmc2_nand.c
>> index 5d627048c420..3abb63d00a0b 100644
>> --- a/drivers/mtd/nand/raw/stm32_fmc2_nand.c
>> +++ b/drivers/mtd/nand/raw/stm32_fmc2_nand.c
>> @@ -1531,6 +1531,9 @@ static int stm32_fmc2_nfc_setup_interface(struct nand_chip *chip, int chipnr,
>>   	if (IS_ERR(sdrt))
>>   		return PTR_ERR(sdrt);
>>   
>> +	if (sdrt->tRC_min < 30000)
> 
> When introducing NV-DDR support we as well added a timings.mode field,
> perhaps you could use it?

Yes, I can use it. It will be done in V2.

Regards,
Christophe Kerello.

> 
>> +		return -EOPNOTSUPP;
>> +
>>   	if (chipnr == NAND_DATA_IFACE_CHECK_ONLY)
>>   		return 0;
>>   
> 
> 
> Thanks,
> Miquèl