Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 24 Mar 2023 10:09:00 -0700
In-Reply-To: <20230110175057.715453-2-pgonda@google.com>
Mime-Version: 1.0
References: <20230110175057.715453-1-pgonda@google.com> <20230110175057.715453-2-pgonda@google.com>
Message-ID: <ZB3ZLFCgqYxekE6U@google.com>
Subject: Re: [PATCH V6 1/7] KVM: selftests: sparsebit: add const where appropriate
From:   Sean Christopherson <seanjc@google.com>
To:     Peter Gonda <pgonda@google.com>
Cc:     kvm@vger.kernel.org, linux-kernel@vger.kernel.org,
        Michael Roth <michael.roth@amd.com>,
        Paolo Bonzini <pbonzini@redhat.com>,
        Vishal Annapurve <vannapurve@google.com>,
        Ackerley Tng <ackerleytng@google.com>,
        Andrew Jones <andrew.jones@linux.dev>
Content-Type: text/plain; charset="us-ascii"
Precedence: bulk

I suggest this for the shortlog

  KVM: selftests: Make sparsebit structs const where appropriate

Three deep scopes are a net negative IMO.  Too much of the shortlog is consumed
by the scope, and very few patches are actually capable of such precision, i.e.
touch more than a single area.

On Tue, Jan 10, 2023, Peter Gonda wrote:
> From: Michael Roth <michael.roth@amd.com>
> 
> Subsequent patches will introduce an encryption bitmap in kvm_util that

protected memory, not encryption

> would be useful to allow tests to access in read-only fashion. This
> will be done via a const sparsebit*. To avoid warnings or the need to
> add casts everywhere, add const to the various sparsebit functions that
> are applicable for read-only usage of sparsebit.