Received: by 2002:a05:6358:11c7:b0:104:8066:f915 with SMTP id i7csp1443559rwl; Fri, 24 Mar 2023 10:32:21 -0700 (PDT) X-Google-Smtp-Source: AKy350b/S7eY/wab+D9sdBjSzOFx31Lx4ECH9h+aqIIAsQy+OzCgi9fu5zEnKI9pmcGuxThM//xa X-Received: by 2002:a17:903:110e:b0:1a1:bfd6:f890 with SMTP id n14-20020a170903110e00b001a1bfd6f890mr4074497plh.9.1679679141699; Fri, 24 Mar 2023 10:32:21 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1679679141; cv=none; d=google.com; s=arc-20160816; b=vzTYv3e53AFQ9RvyZQsh3880X8o38FfS/bgz6UvxYrOz6LzsbOa2FJJ/yqLkhqNqFk hYRJSMSDjLE9yjREv9T59iRn/92hTmmipC3Du4oL5D2aub82Tp2itRlZ4KF4BvwdTS4h mwbPxd4V5YWxhFq8v0DSkD9yV9hIuTYU2azjxNpN4w+AYpX7CRDK2kDn90TJAtt8AGCH WytvbQEqm9bDBOToM9BUEoVqtL/rJj+SO7HjLAqQavsxgdP64VSfslH3gUbgR96nMKer HDRM+n+Nx8fXY8MZaMAFlwD2HScZn2MeXWg4nQtoPpcGG3SJcQlsNw2T0NJbbK4BNJwN vp1w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=6kvgynts9pGunaYTqyxyW8b1uVo2ebWpPqOLNHUAp5s=; b=TJUKW0pgTJpj6U6ECk6DC77+1TsbTN88i4TKRezEl+Si+bZEuB5lGMTICbf0cCm5vu xy7DpL9j5JRia0fYoZX5nTcefYX7xACJ1SkIERl1nZgsvCqR0G4XAzY/6cRuAYXS8wP2 EeGgBhmx1/xS0FzBxbrtKljngu2quwnmJDPJqXcKzulKgfWLeTZ4Qzttjxuf/f5CXzEF uMu/Lc/0PbzKbrlS6vrVfxSP0jw/dAz1dqnBNcvxaCrrix0xRCHtkf5gvHezFxqxIkc5 2HjDOuJ4P7LDRRya84wlv3GHqDGYUDOTkHonNOFvq1o1GqwDLX+BqmJN4Ka2LUOMsgE2 ULOg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=oB+95YCd; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id g21-20020a170902d1d500b0019aa6450ff3si20028504plb.585.2023.03.24.10.32.09; Fri, 24 Mar 2023 10:32:21 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=oB+95YCd; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231704AbjCXRYo (ORCPT + 99 others); Fri, 24 Mar 2023 13:24:44 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46120 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231718AbjCXRYm (ORCPT ); Fri, 24 Mar 2023 13:24:42 -0400 Received: from mail-ot1-x332.google.com (mail-ot1-x332.google.com [IPv6:2607:f8b0:4864:20::332]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6FE7118B0F; Fri, 24 Mar 2023 10:24:35 -0700 (PDT) Received: by mail-ot1-x332.google.com with SMTP id m20-20020a9d6094000000b0069caf591747so1258056otj.2; Fri, 24 Mar 2023 10:24:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1679678674; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=6kvgynts9pGunaYTqyxyW8b1uVo2ebWpPqOLNHUAp5s=; b=oB+95YCdnFSnDNUAsmd3akZYut4IbwPvelIZLYP3hiX0NQCJJ6AgqdHo4hFOQiQGCS hzzPfqMKlfTr9PXTDc6vufgbr2Yilw7biRtdlDfZxHSwo6WEh+dcKorVWSfYOLy+WnEE pOPfH8KZARyRRpnR2xUDAw00GgMeD5Bed74rCQWBw6pBpYkFYsyHiz6GtuH5tBQ9DKA6 SWPjr6iwRZqDbLPXiI5uWvO51wT26c7hMu9Hz1jzcfwi3gkD32W8hMwVcxhv2vXrKtod 7QB8AQukpAPhoD6nMFqx9xaOEOoVzeXN/2Cj/xICn3LkQmr1WBOLEqlJ9krwe8q7/qJL jggA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679678674; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=6kvgynts9pGunaYTqyxyW8b1uVo2ebWpPqOLNHUAp5s=; b=a/w3FDLS1RtrfbiVeD+MW4bXa/ZpYwGsMQiUXVTjRt6ZKqPdeMFuTTku1cR0sHrql+ TnwV0+2f/kYZSkTZHts9+Up+zqZEfvEkI5Km6o4KCarpWh3tFhWXEoW/ZH2uyexDFUaD Cb6kzfQAGoVOiEBKDk5bCbTasBDK96eN3JudXC2AowDpRrTj1mViSEkIbCWkOVQ+6DF2 8rMQkNQRCsoZGilBnhg0OX1CAn4Hn2+Un+YivR5nxOC/UP4AzvjfTu/C4ppVSYDzcbh5 kuL8FpIbxjzzYgATpxB1uYH6j1ePs4lw2aFT9Fq6M9iUmtCtr9AcokSvoePwpXIt3krk EMKA== X-Gm-Message-State: AO0yUKXiJNj3WWCloQs549Wd9iEBzIvzJkMBgFGDCvwH29AsrtihcBIJ mHI0eoOvMoMXb4wtjqHBPS0= X-Received: by 2002:a05:6830:1da6:b0:69d:8f5e:b24b with SMTP id z6-20020a0568301da600b0069d8f5eb24bmr2223161oti.25.1679678674500; Fri, 24 Mar 2023 10:24:34 -0700 (PDT) Received: from chcpu13.cse.ust.hk (191host119.mobilenet.cse.ust.hk. [143.89.191.119]) by smtp.gmail.com with ESMTPSA id w16-20020a9d77d0000000b006a11dd6d2c1sm102045otl.29.2023.03.24.10.24.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 24 Mar 2023 10:24:34 -0700 (PDT) From: Wei Chen To: martink@posteo.de Cc: mchehab@kernel.org, linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, Wei Chen Subject: [PATCH] media: hi846: Fix memleak in hi846_init_controls() Date: Fri, 24 Mar 2023 17:24:27 +0000 Message-Id: <20230324172427.3416342-1-harperchen1110@gmail.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=0.1 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org hi846_init_controls doesn't clean the allocated ctrl_hdlr in case there is a failure, which causes memleak. Add v4l2_ctrl_handler_free to free the resource properly. Signed-off-by: Wei Chen --- drivers/media/i2c/hi846.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/media/i2c/hi846.c b/drivers/media/i2c/hi846.c index 7c61873b7198..c45a6511d2c1 100644 --- a/drivers/media/i2c/hi846.c +++ b/drivers/media/i2c/hi846.c @@ -1472,6 +1472,7 @@ static int hi846_init_controls(struct hi846 *hi846) if (ctrl_hdlr->error) { dev_err(&client->dev, "v4l ctrl handler error: %d\n", ctrl_hdlr->error); + v4l2_ctrl_handler_free(ctrl_hdlr); return ctrl_hdlr->error; } -- 2.25.1