Received: by 2002:a05:6358:11c7:b0:104:8066:f915 with SMTP id i7csp1464151rwl; Fri, 24 Mar 2023 10:50:37 -0700 (PDT) X-Google-Smtp-Source: AKy350a6od207saaj3CJoG9ilkiVKisW8uIy5qmOn35ZsG3Sj+E2xfV7YSoL0h1kASDthE2wFhtJ X-Received: by 2002:a62:1885:0:b0:623:d058:8661 with SMTP id 127-20020a621885000000b00623d0588661mr3636027pfy.28.1679680237052; Fri, 24 Mar 2023 10:50:37 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1679680237; cv=none; d=google.com; s=arc-20160816; b=hQaElcCh+oLkWgWkf5OKSMY4ljOaDFbz9guhzZ3+bwOuW8lgOakVw9THGQsY9Dte6u wo+b026OsLVaeiBUiw4y8IjJ94zvAWGlEZD1Pqv8zB78syqfVkwLYxwfXBy/P3L+HvQG CyCbpJ6+cjlnahgURjWsEcAVUsf8VusaVjfcAqZokaJxDqj+wLEDj0yjQW3hljBH+aTB 9bOnwfPCZ5baqfJBlCyamR0oznJrthTwMspIhGNtYwILQhfyE+ya2VuupMm+NlXOF19v vtLqHNvX0mSb759u6HPL+cj/Dgr6KCYXeWdOleA0+pdErJl/+SvkGOFYr9J5GwzShecb BT6Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=8JMgALQCKNhc1DTat1Ue9NTRfw44LtlfEA05xu771Mo=; b=GAIdN2xeVkMP6DPe1TeRQVsS7SWkWJO2d6gkcwribRQfTquGIzmICuMtRDmRiOrfxS WWUtOMhmR+SwlaHf5ysyRBAJAbE0vVW7Y6AqtmUNBLurdVs+0+k//9gXdeqAV39Elqj/ 843KYhy/+2yDt621KsvNq+wC+CzR6S2m05lbkbdFEH6wz9L2o4rHwePOnKf0x1jv/DAF sSiVLuGlk6LeupmQtaBhE9p8oIHi74705h+LFF0faAr0spjcaYNEEHMvmRhAXmKMuRw4 Cjo6ClXNKpgu8IwXf5mTI7KA32E21YpWemt9HS6QPsHXDxnd0qIjUWzNUjvb0qDJFn9t lmwg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id b38-20020a631b66000000b004fba35db0a7si20790340pgm.160.2023.03.24.10.50.24; Fri, 24 Mar 2023 10:50:37 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231960AbjCXRuJ (ORCPT + 99 others); Fri, 24 Mar 2023 13:50:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44084 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232050AbjCXRt7 (ORCPT ); Fri, 24 Mar 2023 13:49:59 -0400 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3F4FD1E2B1 for ; Fri, 24 Mar 2023 10:49:11 -0700 (PDT) Received: from moin.white.stw.pengutronix.de ([2a0a:edc0:0:b01:1d::7b] helo=bjornoya.blackshift.org) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pflWy-0001Xe-J2; Fri, 24 Mar 2023 18:48:48 +0100 Received: from pengutronix.de (unknown [IPv6:2a01:4f8:1c1c:29e9:22:41ff:fe00:1400]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (prime256v1) server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: mkl-all@blackshift.org) by smtp.blackshift.org (Postfix) with ESMTPSA id F120019BAE9; Fri, 24 Mar 2023 17:48:46 +0000 (UTC) Date: Fri, 24 Mar 2023 18:48:46 +0100 From: Marc Kleine-Budde To: Frank Jungclaus Cc: linux-can@vger.kernel.org, Wolfgang Grandegger , Vincent Mailhol , Stefan =?utf-8?B?TcOkdGpl?= , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] can: esd_usb: Improve code readability by means of replacing struct esd_usb_msg with a union Message-ID: <20230324174846.izruwh6evo2yvn7j@pengutronix.de> References: <20230222163754.3711766-1-frank.jungclaus@esd.eu> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="bvdrty76npd6pz24" Content-Disposition: inline In-Reply-To: <20230222163754.3711766-1-frank.jungclaus@esd.eu> X-SA-Exim-Connect-IP: 2a0a:edc0:0:b01:1d::7b X-SA-Exim-Mail-From: mkl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org X-Spam-Status: No, score=-2.3 required=5.0 tests=RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --bvdrty76npd6pz24 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On 22.02.2023 17:37:54, Frank Jungclaus wrote: > As suggested by Vincent Mailhol, declare struct esd_usb_msg as a union > instead of a struct. Then replace all msg->msg.something constructs, > that make use of esd_usb_msg, with simpler and prettier looking > msg->something variants. >=20 > Link: https://lore.kernel.org/all/CAMZ6RqKRzJwmMShVT9QKwiQ5LJaQupYqkPkKjh= RBsP=3D12QYpfA@mail.gmail.com/ > Suggested-by: Vincent MAILHOL > Signed-off-by: Frank Jungclaus Applied to linux-can-next. regards, Marc --=20 Pengutronix e.K. | Marc Kleine-Budde | Embedded Linux | https://www.pengutronix.de | Vertretung N=C3=BCrnberg | Phone: +49-5121-206917-129 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | --bvdrty76npd6pz24 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEDs2BvajyNKlf9TJQvlAcSiqKBOgFAmQd4nsACgkQvlAcSiqK BOh5CQgArhe7G5ZaiycZsxZx7Oq7wIPTZUb/Vc9ALgHmWuun4UfFWv7vyG9hJ5FE Nyx/4pleb8dtRQcEZFjjaVze1lLQP0zk686k3YMGHfqvSyHGZnPUID9YDc67aN55 FLaO3pL1P0Rnp56+yKKSIkQzGbB11+Vf2KFnjIilchfoM8jGXdnyrscbNRlj1Z5A 5S3BiLVhV8ZlufYh5WLyjL7mIdV3UFJy2EypDfnGK9NjpD1KGHreRiKUeLOqgeKI gctb7vSV3+RNwi9xGmLoTEIxhbgNfhDAGP0dDEoi1ysIsyTdfwbfhxt/dkPpws4b c91YHigS0OSF9VGm9KheQbUJ+bN+GQ== =KgKF -----END PGP SIGNATURE----- --bvdrty76npd6pz24--