Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 24 Mar 2023 14:51:45 -0300
From:   Jason Gunthorpe <jgg@nvidia.com>
To:     Nicolin Chen <nicolinc@nvidia.com>
Cc:     Eric Auger <eric.auger@redhat.com>, robin.murphy@arm.com,
        will@kernel.org, kevin.tian@intel.com, baolu.lu@linux.intel.com,
        joro@8bytes.org, shameerali.kolothum.thodi@huawei.com,
        jean-philippe@linaro.org, linux-arm-kernel@lists.infradead.org,
        iommu@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 12/14] iommu/arm-smmu-v3: Support IOMMU_DOMAIN_NESTED
 type of allocations
Message-ID: <ZB3jMSOL5A+E5D82@nvidia.com>
References: <cover.1678348754.git.nicolinc@nvidia.com>
 <b01b2bad6d0d34908812d964eba118a9cc1e89ab.1678348754.git.nicolinc@nvidia.com>
 <b870ec68-623c-df0c-3ea5-7fe6a95e2ef6@redhat.com>
 <ZB3i6r7QD4NVBXkK@Asurada-Nvidia>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <ZB3i6r7QD4NVBXkK@Asurada-Nvidia>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?drj0jT2D1zXQjRlUW1qsvfqZMtUOX4bKcT1G7R4hjQ6SYqommSjAtk9iFe5Z?=
 =?us-ascii?Q?7RL1U02ytiVrFxXFzpQMqfbRkyCRFSmLus0t2tLtKG767IS92pD/e2R8lsVT?=
 =?us-ascii?Q?4kWt0sbAI1xxetpJejgYipVbLws43CMpkrYK6JtTRbCJrDQVPLjIFtyHxQuD?=
 =?us-ascii?Q?oX6zz3cxotN5exkNx//N/VylCiBhcBle17QMst1+IP2lLpbjAJVlnndFj5fA?=
 =?us-ascii?Q?p9ASsqjco0UZAxRFcUdCoDbaLTRjcyFxm83+1cMU/y7ou6bZOBG74189XOJq?=
 =?us-ascii?Q?QN4Ecjhacn9vqMeyYxvacKwEFmmzFKJMpGcQ8ZqKlvu56h6KXSlb0iQRWbae?=
 =?us-ascii?Q?F6qGhaIyjk4a37X0WvT6YI29utiYhaRRhcWF9h7XI9vsymeXwA3JVAyBLklW?=
 =?us-ascii?Q?8kdoNfTrKldWeh4jn+nB4cbAdM43OnIqOqpA/yzPfsPPF8Ldd7abGaMJjrIg?=
 =?us-ascii?Q?0ej+H3WKqoQKXTmwQAQetKDfjnLhF47C6nfYuDwZKbc/NcelhRbFWG36BjkS?=
 =?us-ascii?Q?SyIB2h4kkw2uZg3zo5I/pCT15oFuCAvuuvMfK5vCdV3/6F06pzC9gD+harEQ?=
 =?us-ascii?Q?c5oDb8zJ9vjN2mVXyTUbSqITyNiSNnsJ4IoQBrhY9Y2nqdYIf93ldh2OxtpQ?=
 =?us-ascii?Q?rADBRW/mAsmNo/QCS7I17wKO8nBRkQu6P7Bxlkd2UUhmDt8cQ+4zFuP1A1va?=
 =?us-ascii?Q?rG0p4XXfwU0J92p81fxOG7voGHtlUjW5DWgmyiG7NDbke6kPsIRhGxNdBoZV?=
 =?us-ascii?Q?9wmxdzTbDTwyUWHYPSYP70BUgkuSecDSwzYsZsIPjesLKSbSxb54C1H6Bolk?=
 =?us-ascii?Q?yNgPLToDY6zXtbwdfB21bRUx4rPTko2IZsL7k2OEFDu6IeOAsJR8nAeKmlV9?=
 =?us-ascii?Q?RCqslbTI254B7M0sQoJLmEVt14lTJ0WElyXAR9vQJvSu1k2LG++jz8xyip6V?=
 =?us-ascii?Q?xWpJfUMcfsbYyLh8QrTZNje2Mj2wjGQq8oYUd/16NxDPjm/5Xceb2Dmjh4gk?=
 =?us-ascii?Q?/GE47GVDAdZIxXP4q/SSEg/55cQlKPm+r5sfh0Ej6DHp1dchOcgLn9ENamX9?=
 =?us-ascii?Q?lgAyhW2iLe5o6ynxzhRX+uRsEcMgyS220RBhej60Zb3XO5kCdR4/4XcLKLq8?=
 =?us-ascii?Q?EhcFOnqKfdfR3UicFydAkOfGG4eb3NH1yRgV+8wWq4runhPnUGthtGxd+15/?=
 =?us-ascii?Q?nnZNJun1iatIqlyD9k7HEHMWKSvVKdZ8FMsOGVVxobagThfYGoi/NVM/iGmk?=
 =?us-ascii?Q?bBrkJaGiJftnLBkRQo0t2oxddeLk0lUipUeFIQr4ULl4yP4MT/t2O/SOqtTI?=
 =?us-ascii?Q?c1bgqBfMzGiDyp/HTMHcKmB9IS2RSI19cVm7AOuMuGCrJny6hZTot6LeBFNE?=
 =?us-ascii?Q?+efqlbqt7mFUd/8kNjxlq+EjD1CGBD2jHqgahgYw2I3KwuIsKh6hsjCkFvCe?=
 =?us-ascii?Q?kJQ6Qudh6wo7GrTFig3rOMPOs7hgC0ltrLp9HgqBu0BDDGraoq8kcfLltRc0?=
 =?us-ascii?Q?qmQd1OS60C3i9zDVsmxpEF+VmRK0EH8WR1gFRnVX2ywPJJdHtUajvQtA0LtG?=
 =?us-ascii?Q?mEWADL5T+++dXRgZho11fS+rMypD2U9skwzWKrLm?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 3f6078d2-48d8-4e86-2732-08db2c907025
X-MS-Exchange-CrossTenant-AuthSource: LV2PR12MB5869.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Mar 2023 17:51:47.2702
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: SM56BcXBdU8DuaQo4QXcd6S3k72oqIn80KCsiaF+FWk6Nfj1HRfUuqKFa2kWOoPW
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR12MB8860
X-Spam-Status: No, score=-0.2 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE
        autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Mar 24, 2023 at 10:50:34AM -0700, Nicolin Chen wrote:
> On Fri, Mar 24, 2023 at 04:44:58PM +0100, Eric Auger wrote:
> > > @@ -2923,8 +2949,16 @@ arm_smmu_domain_alloc_user(struct device *dev, struct iommu_domain *parent,
> > >       const struct iommu_hwpt_arm_smmuv3 *user_cfg = user_data;
> > >       struct arm_smmu_master *master = dev_iommu_priv_get(dev);
> > >       unsigned type = IOMMU_DOMAIN_UNMANAGED;
> > > +     struct arm_smmu_domain *s2 = NULL;
> > > +
> > > +     if (parent) {
> > > +             if (parent->ops != arm_smmu_ops.default_domain_ops)
> > > +                     return NULL;
> > > +             type = IOMMU_DOMAIN_NESTED;
> > > +             s2 = to_smmu_domain(parent);
> > > +     }
> > Please can you explain the (use) case where !parent. This creates an
> > unmanaged S1?
> 
> It creates an unmanaged type of a domain. The decision to mark
> it as an unmanaged S1 or an unmanaged S2 domain, is done in the
> finalise() function that it checks the S2 flag and set a stage
> accordingly.

This also needs to be fixed up, the alloc_user should not return
incompletely initialized domains.

Jason