Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   "Chen, Tim C" <tim.c.chen@intel.com>
To:     Yicong Yang <yangyicong@huawei.com>,
        "acme@kernel.org" <acme@kernel.org>,
        "mark.rutland@arm.com" <mark.rutland@arm.com>,
        "peterz@infradead.org" <peterz@infradead.org>,
        "mingo@redhat.com" <mingo@redhat.com>,
        "james.clark@arm.com" <james.clark@arm.com>,
        "alexander.shishkin@linux.intel.com" 
        <alexander.shishkin@linux.intel.com>,
        "linux-perf-users@vger.kernel.org" <linux-perf-users@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
CC:     "Jonathan.Cameron@huawei.com" <Jonathan.Cameron@huawei.com>,
        "21cnbao@gmail.com" <21cnbao@gmail.com>,
        "prime.zeng@hisilicon.com" <prime.zeng@hisilicon.com>,
        "shenyang39@huawei.com" <shenyang39@huawei.com>,
        "linuxarm@huawei.com" <linuxarm@huawei.com>,
        "yangyicong@hisilicon.com" <yangyicong@hisilicon.com>
Subject: RE: [PATCH] perf stat: Support per-cluster aggregation
Thread-Topic: [PATCH] perf stat: Support per-cluster aggregation
Thread-Index: AQHZVYo31QoKPHK0wkSS3lkNmYeNka8KPe7Q
Date:   Fri, 24 Mar 2023 18:05:50 +0000
Message-ID: <DM6PR11MB4107255E167D98A000DC49FBDC849@DM6PR11MB4107.namprd11.prod.outlook.com>
References: <20230313085911.61359-1-yangyicong@huawei.com>
In-Reply-To: <20230313085911.61359-1-yangyicong@huawei.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?O+AGxiIpfvqA/qenSLkyxcjUnGxuUoAwez8DySvMVgp0QwisbcJ1MHtuscle?=
 =?us-ascii?Q?ZBPqDNbW5DVOb5gcN1sDalk2tMaTZBFLdLVVBCbTU4KAuH4WEMQ5fS6gwSOM?=
 =?us-ascii?Q?oaCElFtXGsq+uTkjcgR6pcCsagthA6nqJPfn1m6Z/2oLY7a5+JwelVoOM/ak?=
 =?us-ascii?Q?SAPvA4lEH3YFOt933UtmwaqWT027IpStG2224fYJcihXCf8eyyt/qZUBMmGP?=
 =?us-ascii?Q?Wv9krWQbhscAXsSFtTunNm6GoLKSYUwNfXEhTyVgZDlXoZYKS9dI6yWRWANA?=
 =?us-ascii?Q?wqoltfp76iIJTAFqYXffCASxxWOwS7qfVxzDfrA0b5bKeq7lxQQR2o3rHZXy?=
 =?us-ascii?Q?aXNL+bEUKXUWbpoAhNjqLPCsqAyZYai3NGqRNvRysJ3GuRp+CX4P/rFljsu1?=
 =?us-ascii?Q?41QbjIeCvWuZtUHdQbxG7A4f8r72wqO8zC7DE4SuCEM06SlwE7KqoYmjAsAa?=
 =?us-ascii?Q?AZ1kGu3xKenPNB+M+NN911m5c6LdsQOYAS24xsDWQp7D4npCY9YshnRIe+ka?=
 =?us-ascii?Q?KCVOGlZ+G1r+HIMYf4+7SuOygIrXrtRym95leJWg5+0FkPrk9x1OeJVGYP2+?=
 =?us-ascii?Q?oPz7wDLkXKSxpymbhOrguR4K6BfkXzDEXoSwFRQdKfqI30/x/9Pe8U+bwtfP?=
 =?us-ascii?Q?eB5Ec6nqGw6o6EMzdHT2L4cVkfCFgYV2Q69jsAmSso8PJenieDcJDU0Auu3a?=
 =?us-ascii?Q?C9HcsbCyKDY/GX8EdTfcGZHbO0fJEFkLoEOKLgIVDnkOvO/zJd+H9DHfRKca?=
 =?us-ascii?Q?8IYsgvRmP5NJDbaeuF1e4lpJki/sb6iOGExDUzqzq8Wcxfmg+IKRF5Wy6Dc1?=
 =?us-ascii?Q?Es616Ib6Hma6UbRASmJxhymCmaOi9c8NqvuxPYEght/b6R+5MJOkLsWXoAcz?=
 =?us-ascii?Q?h+aEyIzTSnaa9bbOd1QX/j3SS3jm00kLstP04NG7VNgEEg2w3zWmNd9USkhY?=
 =?us-ascii?Q?048ZLVOFgcGLc0p8V1u4dLeFBoJw4TC6KwvjIo+NbSMMqg5v/8IIYVLqc0HE?=
 =?us-ascii?Q?LbAHkPe8dcapDkysaTlaVHko1E4zbkJiIKpiT4kh616U3UK7wPwUEMq2xUsK?=
 =?us-ascii?Q?NgWGzajd1lfycpLrZqp76uJFSfZHsVs/phmJkVTn2m4C87sJGf0L+n0dBWiN?=
 =?us-ascii?Q?EgR0Acp5s/oUHPPHKTDNMXT5BUqb4sTquFqG9hGrl1PNyWbbioEbNoXWaK5a?=
 =?us-ascii?Q?CZSAL1X9WqEPjJeEuFImwvEI///MY1AAlIa8F9fFnM2x0Q51CvFWdvqymktu?=
 =?us-ascii?Q?0XuGV5jP7PuHQ5t6fpkNYeT9IJ2UVnxZX/l0fHzaIRO99MWNcdffPqJaKNsx?=
 =?us-ascii?Q?yLSqXJdlFf8OLGLB0o4jCBXUBKL8AUxPFBuGCHCbeRfg1e5KwYsQVzEbUNSt?=
 =?us-ascii?Q?MttSTcmCTqUVBH6XUfsP2rCQufWRjgSr4LvRspao6ROWUvEVqhTLdB7t68Xv?=
 =?us-ascii?Q?9UN4sGMpEiSKikiVdLT2QYPuxVPf0YN7r1c8Cg1Qs/I44AuQm3yYpAMjR+xO?=
 =?us-ascii?Q?4HkcNMTvp5tSDGpmNbZD39EhlRUd+lAQ4oqaUOdE2gnjIAhcEKV/hvCEP6WV?=
 =?us-ascii?Q?B6O8RaDZ0Fm4OHyHl15sJim0vnmPa4YvHO/W2Pgq?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB4107.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 83f806b1-ac80-49cc-39e8-08db2c926700
X-MS-Exchange-CrossTenant-originalarrivaltime: 24 Mar 2023 18:05:50.7347
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: HVcA1EpU90blXqDeDm16Zc/4I9DnSi4MKYMah4+Y2y6jahxV0yDVfFX+xD/ylxaIHvp7OUn44zl1UkRDS9FijA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR11MB7213
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-2.5 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE
        autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

>
>From: Yicong Yang <yangyicong@hisilicon.com>
>
>Some platforms have 'cluster' topology and CPUs in the cluster will share
>resources like L3 Cache Tag (for HiSilicon Kunpeng SoC) or L2 cache (for I=
ntel
>Jacobsville). Currently parsing and building cluster topology have been
>supported since [1].
>
>perf stat has already supported aggregation for other topologies like die =
or
>socket, etc. It'll be useful to aggregate per-cluster to find problems lik=
e L3T
>bandwidth contention or imbalance.
>
>This patch adds support for "--per-cluster" option for per-cluster aggrega=
tion.
>Also update the docs and related test. The output will be like:
>
>[root@localhost tmp]# perf stat -a -e LLC-load --per-cluster -- sleep 5
>
> Performance counter stats for 'system wide':
>
>S56-D0-CLS158    4      1,321,521,570      LLC-load
>S56-D0-CLS594    4        794,211,453      LLC-load
>S56-D0-CLS1030    4             41,623      LLC-load
>S56-D0-CLS1466    4             41,646      LLC-load
>S56-D0-CLS1902    4             16,863      LLC-load
>S56-D0-CLS2338    4             15,721      LLC-load
>S56-D0-CLS2774    4             22,671      LLC-load
>[...]

Overall it looks good.  You can add my reviewed-by.

I wonder if we could enhance the help message=20
in perf stat to tell user to refer to=20
/sys/devices/system/cpu/cpuX/topology/*_id
to map relevant ids back to overall cpu topology.

For example the above example, cluster S56-D0-CLS158  has
really heavy load. It took me  a while
going through the code to figure out how to find
the info that maps cluster id to cpu.

Tim