Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230113122910.672417-1-jiangshanlai@gmail.com> <167934153606.1941128.1026865175616779306.b4-ty@google.com>
In-Reply-To: <167934153606.1941128.1026865175616779306.b4-ty@google.com>
From:   Mingwei Zhang <mizhang@google.com>
Date:   Fri, 24 Mar 2023 11:34:28 -0700
Message-ID: <CAL715W+a=og5f-v1o+56wTDmLJr1HitgFzmvL276BuomZvS7YA@mail.gmail.com>
Subject: Re: [PATCH] kvm: x86/mmu: Simplify pte_list_{add|remove}
To:     Sean Christopherson <seanjc@google.com>
Cc:     linux-kernel@vger.kernel.org,
        Lai Jiangshan <jiangshanlai@gmail.com>,
        Paolo Bonzini <pbonzini@redhat.com>,
        Lai Jiangshan <jiangshan.ljs@antgroup.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
        Dave Hansen <dave.hansen@linux.intel.com>, x86@kernel.org,
        "H. Peter Anvin" <hpa@zytor.com>, kvm@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Thu, Mar 23, 2023 at 3:51=E2=80=AFPM Sean Christopherson <seanjc@google.=
com> wrote:
>
> On Fri, 13 Jan 2023 20:29:10 +0800, Lai Jiangshan wrote:
> > Simplify pte_list_{add|remove} by ensuring all the non-head pte_list_de=
sc
> > to be full and addition/removal actions being performed on the head.
> >
> > To make pte_list_add() return a count as before, @tail_count is also
> > added to the struct pte_list_desc.
> >
> > No visible performace is changed in tests.  But pte_list_add() is no lo=
nger
> > shown in the perf result for the COWed pages even the guest forks milli=
ons
> > of tasks.
> >
> > [...]
>
> Applied to kvm-x86 mmu, thanks!  I added quite a few comments and a BUG_O=
N() to
> sanity check that the head is never empty when trying to remove an entry,=
 but I
> didn't make anything changes to the code itself.
>
> [1/1] kvm: x86/mmu: Simplify pte_list_{add|remove}
>       https://github.com/kvm-x86/linux/commit/141705b78381
>

I am not sure if it is possible, but now spte_count is u32 so does
tail_count. I wonder if an attacker could use the potential integer
overflow to trigger this? E.g,: creating a huge number of little L1
EPTs with the many nGPA-> one GPA? hmm, I think it could overflow
tail_count? Please double check.

spte_count is u32, but assigned to an (signed) int j and BUG_ON(j <
0)? Please don't add more BUG_ON in KVM mmu... and please change
either 'spte_count' to 'int' or 'j' to u32.

In general, please, no BUG_ON(), at least no more BUG_ON() on our nested MM=
U...

Please take a second thought on this one before merge!

Thanks.

-Mingwei