Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <04bef83e-8679-d8f9-1f11-e55a2e5f5b58@intel.com>
Date:   Fri, 24 Mar 2023 19:45:07 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.9.0
Subject: Re: [PATCH v3 26/38] pnp: add HAS_IOPORT dependencies
To:     Niklas Schnelle <schnelle@linux.ibm.com>,
        "Rafael J. Wysocki" <rafael@kernel.org>
CC:     Arnd Bergmann <arnd@arndb.de>, Jaroslav Kysela <perex@perex.cz>,
        "Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
        Bjorn Helgaas <bhelgaas@google.com>,
        =?UTF-8?Q?Uwe_Kleine-K=c3=b6nig?= <u.kleine-koenig@pengutronix.de>,
        Mauro Carvalho Chehab <mchehab@kernel.org>,
        Alan Stern <stern@rowland.harvard.edu>,
        Geert Uytterhoeven <geert@linux-m68k.org>,
        Paul Walmsley <paul.walmsley@sifive.com>,
        "Palmer Dabbelt" <palmer@dabbelt.com>,
        Albert Ou <aou@eecs.berkeley.edu>,
        <linux-kernel@vger.kernel.org>, <linux-arch@vger.kernel.org>,
        <linux-pci@vger.kernel.org>, Arnd Bergmann <arnd@kernel.org>,
        <linux-acpi@vger.kernel.org>
References: <20230314121216.413434-1-schnelle@linux.ibm.com>
 <20230314121216.413434-27-schnelle@linux.ibm.com>
 <CAJZ5v0gYGkbUk4uFXgidMaRBniwiXpizZWwMGixeNNejeZjPzg@mail.gmail.com>
 <CAJZ5v0gHFA_BgLuCx=Eb3J5D7f7j8kV3Pthqy3jAfpavY6UMuQ@mail.gmail.com>
 <2bcabfceab658ae62bf854e5fdaf5bc916481359.camel@linux.ibm.com>
Content-Language: en-US
From:   "Wysocki, Rafael J" <rafael.j.wysocki@intel.com>
In-Reply-To: <2bcabfceab658ae62bf854e5fdaf5bc916481359.camel@linux.ibm.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ck1KUjNHcUhacVkzTFJpY2hMZ3pQUUlJc2YrYlQrK1pmRnhDYUNlVlJWWUtp?=
 =?utf-8?B?WnkxQVpSRHgzUlN2R0plWEpqTjk3SHJTdkRZZmh1TnhYenU3RmR4NUw0dURz?=
 =?utf-8?B?cEVhVGZnQTBkZUFuQlRULy8wTUpDNTlzTGlHVXJwMG5sVnJQV29sNW5QcElR?=
 =?utf-8?B?UzRYaUVWbWQ3b1NBNVE4R0psZDNTaGpvbVNyUWl1RVpQQ3owMVEvNGt1Y0oz?=
 =?utf-8?B?dzN2ZWpUZkpmcFkyL0MrN2pjN1lJQ1dNN2M5WFNjWlA4ekVHZzBOWHZYd1ox?=
 =?utf-8?B?SGRRczN3TjVnZythdUQ0TjdDK2l3a21ucmcxWVJicDRIRmxjNzJZek5aZXU3?=
 =?utf-8?B?Mzg1OUxuNFZpdE0wWkx4VExrNU1keDRmcGIzRk5mcWYvSWNvQ2szb0krQlhJ?=
 =?utf-8?B?dSsyN0diRmo1Vmp3bjdXaXVjMCtiK0RrRzM4cXpBMmtsRlV5Tk9MMWxUVHMw?=
 =?utf-8?B?bktwcnk0VlNZajdGdmFBbHlwUXJQVEV4RzA0OGRnZks3R0o3bjNHSnByVnRP?=
 =?utf-8?B?aVJGanAwT0V3Yit0NUU4eXIyZkJGYmVZUXhjZ2t4N3YrMDZyVi9WOW8wd2Zt?=
 =?utf-8?B?SU9TZWR1c3FRVTh2emhwb2lJYmRicHY4R1BkdjZXaXNpcDNyaTI0Nmo2c2lK?=
 =?utf-8?B?T1B0RHJFWEF4NGdJSTl6M012TWZyTS80eFBUWnJScmo0MzBaZG95U0N3UTFh?=
 =?utf-8?B?bGJRODlxcEhxOS96RnNvT3BhVXcxMm9TL1Vzbno3ZkFNRmhQOE85SWVvNGV3?=
 =?utf-8?B?VExsN0drOUJDcERNVVFJUUNKVldWRDBxdU54M2FXeUo5R1RZb1FkME4xS1R4?=
 =?utf-8?B?SzB6ODRKaEJoYUJYeHJHWGpBdUFsNnB2cnhZK04yN3MvQUJGVXFFZkFubVMr?=
 =?utf-8?B?OUJxdmVpUmZRMkNFeXVuS3BwY1pQTk00aFQ4amRvcGZ3RTVnWmFzTU1KZzZj?=
 =?utf-8?B?Z1V3WTVmTXVCUm15T0hzcGwwUVozWCtKczZCTzRkR0k1Vm9wT3o1MkNKSlNX?=
 =?utf-8?B?TDlpeTVzMGw5eEpTYk4xbTBwUGk2VEdyaHdUSFNMMnVTejRud3NFRjJMRHFx?=
 =?utf-8?B?SUhLMDNOQ294RXJrY1dPUWVkOTBYbm0ya3E4Nytzc2gwdlErQ3ViTUpYaVpZ?=
 =?utf-8?B?VjJ4cEVKbkc1TXlsbFBRWGdaSy9VQVFUTmFmOVB4UlVHNzNTeVVNMUY0OHF3?=
 =?utf-8?B?cVpnbk54OFVUdVVKUU45elhHbENlU09iSm8zaUI2Y0pBLzh5RFVOWlN6c01U?=
 =?utf-8?B?ZjRic0FxSWdIVWpGNDZ1ZVZTVUFnMVYzejRKTmxMRjlBc280NlUzSENtTXFs?=
 =?utf-8?B?MU1WZTFEcU1xU0U0aUJZYllXSCttN1ZVd0V6aDh3RTZpL2VIUXFqeld1c090?=
 =?utf-8?B?SGxVNCsrOXNjWktrMjFPalBVbWxsQUhuZjNES2wweXhDVlF2UEZFOWtMNnIx?=
 =?utf-8?B?ZTdJN2RQclZ4alByREFlbjg0TFNva3U3bGEyQU5nOWZlaDMwOWUxbW52eTkz?=
 =?utf-8?B?UU9TS2xaY1BhTSswSWtGVGdtYS8wOC81SWgyY0xYWDlQSHVvSGZyYitmYnhE?=
 =?utf-8?B?Rjh1MzYwbW44SUlpYlp3Uk40OG9JSHZ6N1F1Qkd0am5zUXIzVmJoeTFnTnJy?=
 =?utf-8?B?dFhubzdYVnZGSHJ0a2VFOHNyUUUxWlBaNUhnRDRIMDRtb3JKYkVwaFMyeUgr?=
 =?utf-8?B?Y3hCY1JtUkZZWUplOFdpRXBzSlhSMllaRDBGaldkenNiM2pFc2YvMmIxTEtF?=
 =?utf-8?B?a0NXYlo4RWJSdVFIeHAvVlZMZzFiZlVJT3ptVTFuclpDVTNkTldnWjZIdWVL?=
 =?utf-8?B?cEdJNU1SZk1la3kzcEpJQWdCYlhUb2JrYkNUNWdsOTErcEM3SmR0b2JVREht?=
 =?utf-8?B?b3lKOHhYOWJmMmpqb0RZaVZCVVVhWVhCOTZKaWsrbUZ4Tys3aHBGVTNJK2Jx?=
 =?utf-8?B?VVVSMFk3TW1vQUR0N2lSTmFvQURVNWF0SXc1Nmh5d3NPZjhNRUFkeDBrQmsz?=
 =?utf-8?B?UCtuSG9mT1R4aEdwSEVEeUJsdHI4NDJPbkZXWllFYUhaUXdtSWF1TjNVaWNa?=
 =?utf-8?B?Z3liclJkQjNvclBvc3pZV25MSjFnRUNHQ0ZwYWlrV1d0Q1VRTnJpNDQySUpI?=
 =?utf-8?B?NE16QjJKUk9zVDNFVE0vMDRjK3ZodThRS0w2WFM2bVlFZUw0ZWNHaGtIa0dP?=
 =?utf-8?B?aHc9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 3fbf6668-874a-4d96-00f7-08db2c97e967
X-MS-Exchange-CrossTenant-AuthSource: MW5PR11MB5810.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Mar 2023 18:45:17.4488
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: JCyzffHJXhxL5kLf3eyBtA84lyR8t6I0/YJe3ZnqcCVn7Dv+fI8YUfZOju73dGmDeOWiQby7p9LDKyBQSyg1z5v9y46nj1IKpW/8sxLqegE=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR11MB7952
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-0.2 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,SPF_HELO_NONE,
        SPF_NONE autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 3/23/2023 1:55 PM, Niklas Schnelle wrote:
> On Tue, 2023-03-21 at 14:56 +0100, Rafael J. Wysocki wrote:
>> On Mon, Mar 20, 2023 at 6:37 PM Rafael J. Wysocki <rafael@kernel.org> wrote:
>>> On Tue, Mar 14, 2023 at 1:13 PM Niklas Schnelle <schnelle@linux.ibm.com> wrote:
>>>> In a future patch HAS_IOPORT=n will result in inb()/outb() and friends
>>>> not being declared. We thus need to depend on HAS_IOPORT even when
>>>> compile testing only.
>>>>
>>>> Co-developed-by: Arnd Bergmann <arnd@kernel.org>
>>>> Signed-off-by: Niklas Schnelle <schnelle@linux.ibm.com>
>>>> ---
>>>>   drivers/pnp/isapnp/Kconfig | 2 +-
>>>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>>>
>>>> diff --git a/drivers/pnp/isapnp/Kconfig b/drivers/pnp/isapnp/Kconfig
>>>> index d0479a563123..79bd48f1dd94 100644
>>>> --- a/drivers/pnp/isapnp/Kconfig
>>>> +++ b/drivers/pnp/isapnp/Kconfig
>>>> @@ -4,7 +4,7 @@
>>>>   #
>>>>   config ISAPNP
>>>>          bool "ISA Plug and Play support"
>>>> -       depends on ISA || COMPILE_TEST
>>>> +       depends on ISA || (HAS_IOPORT && COMPILE_TEST)
>> This breaks code selecting ISAPNP and not depending on it.  See
>> https://lore.kernel.org/linux-acpi/202303211932.5gtCVHCz-lkp@intel.com/T/#u
>> for example.
>>
>> I'm dropping the patch now, please fix and resend.
>>
> Sorry if this wasn't super clear but all patches in this series depend
> on patch 1 which introduces the HAS_IOPORT Kconfig option. There's
> really two options, either the whole series goes via e.g. Arnd's tree
> at once or we first only merge patch 1 and then add the rest per
> subsystem until finally the last patch can remove inb()/outb() when
> HAS_IOPORT is unset.

Well, it looks like you need to decide on the approach then and tell 
people what it is.

If I see an individual patch without context, this is quite hard to 
figure out.


> That said I'm a little unsure about the linked error if that is just
> due to missing HAS_IOPORT or something else. I'll still have to try
> with the instructions in that mail and will report back if it is
> something else.
>
> Thanks,
> Niklas