Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 24 Mar 2023 12:05:28 -0700
In-Reply-To: <20230110175057.715453-1-pgonda@google.com>
Mime-Version: 1.0
References: <20230110175057.715453-1-pgonda@google.com>
Message-ID: <ZB30eAFfZznEEjZ3@google.com>
Subject: Re: [PATCH V6 0/7] KVM: selftests: Add simple SEV test
From:   Sean Christopherson <seanjc@google.com>
To:     Peter Gonda <pgonda@google.com>
Cc:     kvm@vger.kernel.org, linux-kernel@vger.kernel.org,
        marcorr@google.com, michael.roth@amd.com, thomas.lendacky@amd.com,
        joro@8bytes.org, pbonzini@redhat.com, andrew.jones@linux.dev,
        vannapurve@google.com, Ackerley Tng <ackerleytng@google.com>
Content-Type: text/plain; charset="us-ascii"
Precedence: bulk

On Tue, Jan 10, 2023, Peter Gonda wrote:
> This patch series continues the work Michael Roth has done in supporting
> SEV guests in selftests. It continues on top of the work Sean
> Christopherson has sent to support ucalls from SEV guests. Along with a
> very simple version of the SEV selftests Michael originally proposed.

...

> Michael Roth (2):
>   KVM: selftests: sparsebit: add const where appropriate
>   KVM: selftests: add support for protected vm_vaddr_* allocations
> 
> Peter Gonda (5):
>   KVM: selftests: add hooks for managing protected guest memory
>   KVM: selftests: handle protected bits in page tables
>   KVM: selftests: add library for creating/interacting with SEV guests
>   KVM: selftests: Update ucall pool to allocate from shared memory
>   KVM: selftests: Add simple sev vm testing

Lot's of non-trivial feedback.  To help move things along, I pushed a completely
untested (probably doesn't compile) branch to

  https://github.com/sean-jc/linux/tree/x86/sev_selftests_for_peter

that has most of the feedback incorporated.  Feel free to massage/rework things
as needed (and again, it needs testing+polishing), my goal is purely to avoid you
having to duplicate what I've already done as part of working through the review.