Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 24 Mar 2023 12:57:13 -0700
From:   Bjorn Andersson <andersson@kernel.org>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc:     Neil Armstrong <neil.armstrong@linaro.org>,
        Rob Clark <robdclark@gmail.com>,
        Abhinav Kumar <quic_abhinavk@quicinc.com>,
        Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
        Sean Paul <sean@poorly.run>, David Airlie <airlied@gmail.com>,
        Daniel Vetter <daniel@ffwll.ch>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Andy Gross <agross@kernel.org>,
        Konrad Dybcio <konrad.dybcio@linaro.org>,
        linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org,
        freedreno@lists.freedesktop.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/4] arm64: dts: qcom: sm8450: remove invalid
 properties in cluster-sleep nodes
Message-ID: <20230324195713.5blwpv7xjijlrtt5@ripper>
References: <20230323-topic-sm8450-upstream-dt-bindings-fixes-v2-0-0ca1bea1a843@linaro.org>
 <20230323-topic-sm8450-upstream-dt-bindings-fixes-v2-2-0ca1bea1a843@linaro.org>
 <20230324174518.2arvdglqqixmxqcp@ripper>
 <fdd51d3d-a1fd-c3a9-c578-59a11c5213de@linaro.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <fdd51d3d-a1fd-c3a9-c578-59a11c5213de@linaro.org>
Precedence: bulk

On Fri, Mar 24, 2023 at 08:27:12PM +0100, Krzysztof Kozlowski wrote:
> On 24/03/2023 18:45, Bjorn Andersson wrote:
> > On Fri, Mar 24, 2023 at 10:28:47AM +0100, Neil Armstrong wrote:
> >> Fixes the following DT bindings check error:
> > 
> > Is that because idle-state-name and local-timer-stop should not be
> > defined for domain-idle-states or are you just clearing out the
> > dtbs_check warning?
> > 
> > According to cpu-capacity.txt local-timer-stop seems to have been a
> > property relevant for clusters in the past, was this a mistake in the
> > binding or did something change when this was moved to
> > domain-idle-states?
> 
> I cannot find anything about local-timer-stop in cpu-capacity.txt. Where
> do you see it?
> 

Ohh, you're right it's only mentioned in the example.

But idle-states.yaml documents the property for both cpus and clusters,
and it's used throughout the examples.

Our cluster states are defined in domanin-idle-states instead of
idle-state, does this imply that the flag is no longer applicable
per cluster in this mode of operation?

Regards,
Bjorn