Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 24 Mar 2023 22:44:02 +0200
From:   Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To:     Radhey Shyam Pandey <radhey.shyam.pandey@amd.com>
Cc:     vkoul@kernel.org, kishon@kernel.org, michal.simek@xilinx.com,
        linux-kernel@vger.kernel.org, linux-phy@lists.infradead.org,
        linux-arm-kernel@lists.infradead.org, git@amd.com
Subject: Re: [PATCH] phy: xilinx: phy-zynqmp: mention SGMII as supported
 protocol
Message-ID: <20230324204402.GD23868@pendragon.ideasonboard.com>
References: <1679660679-10409-1-git-send-email-radhey.shyam.pandey@amd.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <1679660679-10409-1-git-send-email-radhey.shyam.pandey@amd.com>
Precedence: bulk

Hi Radhey,

Thank you for the patch.

On Fri, Mar 24, 2023 at 05:54:39PM +0530, Radhey Shyam Pandey wrote:
> SGMII is validated on kria KR260 robotics starter kit. So modify the
> comment description to include it in supported controllers list.
> 
> Signed-off-by: Radhey Shyam Pandey <radhey.shyam.pandey@amd.com>
> ---
>  drivers/phy/xilinx/phy-zynqmp.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/phy/xilinx/phy-zynqmp.c b/drivers/phy/xilinx/phy-zynqmp.c
> index 9be9535ad7ab..ebe5ba730234 100644
> --- a/drivers/phy/xilinx/phy-zynqmp.c
> +++ b/drivers/phy/xilinx/phy-zynqmp.c
> @@ -8,9 +8,9 @@
>   * Author: Subbaraya Sundeep <sundeep.lkml@gmail.com>
>   * Author: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
>   *
> - * This driver is tested for USB, SATA and Display Port currently.
> - * Other controllers PCIe and SGMII should also work but that is
> - * experimental as of now.
> + * This driver is tested for USB, SGMII, SATA and Display Port currently.
> + * Other controller i.e PCIe should also work but that is experimental

As only PCIe is left, I'd write

 * PCIe should also work but that is experimental as of now.

With that,

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

Of course it would be even better if you could test PCIe ;-)

> + * as of now.
>   */
>  
>  #include <linux/clk.h>

-- 
Regards,

Laurent Pinchart