Received: by 2002:a05:6358:11c7:b0:104:8066:f915 with SMTP id i7csp1687292rwl; Fri, 24 Mar 2023 14:08:02 -0700 (PDT) X-Google-Smtp-Source: AKy350ZSl6ra9uMko/fZAmcC1Cbw+C0wJ39Y0LyWOcXihxUptKXodarvH9ZdoYyOrpEjHXBdB5wA X-Received: by 2002:a17:906:806:b0:8b1:7841:9f28 with SMTP id e6-20020a170906080600b008b178419f28mr4273674ejd.55.1679692082270; Fri, 24 Mar 2023 14:08:02 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1679692082; cv=none; d=google.com; s=arc-20160816; b=nhrO4dBggwXIQXzowBbsLQAyruxezallDAcj9cKCEmQMtAO06SIbP5m2neVb4DEBk2 1FSpAvoT3+6IKWgfZIAEnU13/jc8be1SceSHhgl7T13nAutmNPbkbxNxDu8haNGCTlM0 j5YvzRuKpsrMPnzbPZAo9xwR39pljDS+DQR6jjlA7Y8wiGaU+arCCxNkoUnJ0RUNFIR7 VznF3/5OlvymQaC2LpQlc1b2ynxP4Xi/vaMTQzXzyJ4ITgqt7rCYeivnyd0i7n9XZzZg hfWADr27vD9k30X18Kq1ji6+5kSG6bn3NVvbAW1co2ID/mbf5LPGktOBaXm+WB50J496 v+pg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=+ElARR84kFp7gt6xLMHjZPfjGKmiuRlyS1NrYeaNaz0=; b=tDCZOWSzGIrj2YxjDeQEecfbasYEMPiuv3AoV0BbVugjwajuDr0PJgwBUqX8TbUUpy PS8HJm/hj2scXGEA0jnwXb8J6Dy2oOZmVn8f3yPq4I5TMe4MSCH4ZthUWVB3wnCpJ0CS /mxMoWjHhcQTJgqeBSJgYrbfJPn1CPJNt1jANgwb3kVdE+pjpmVomsbVYC8x1uwae1/w 05qfVMjV839BcCKUjkASOx+o83Kkq3w0Os/C+EOLDJuTRNRucKzTmycTiBHOJy1Fdg3K yDousrijTpaiQE3c/IJAK2RIlAlILFD/F4uwiwJsg9rMTspyY2JBdCYGg+mtwUlR6II0 RR2w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2022-7-12 header.b="p/Yqekw/"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id r1-20020a1709061ba100b009280d5af3ffsi20733354ejg.877.2023.03.24.14.07.37; Fri, 24 Mar 2023 14:08:02 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2022-7-12 header.b="p/Yqekw/"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231984AbjCXVHV (ORCPT + 99 others); Fri, 24 Mar 2023 17:07:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43384 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230399AbjCXVHQ (ORCPT ); Fri, 24 Mar 2023 17:07:16 -0400 Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E29C718AB2; Fri, 24 Mar 2023 14:07:14 -0700 (PDT) Received: from pps.filterd (m0246632.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 32OL4P04006442; Fri, 24 Mar 2023 21:07:10 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : cc : subject : date : message-id : in-reply-to : references : mime-version : content-type : content-transfer-encoding; s=corp-2022-7-12; bh=+ElARR84kFp7gt6xLMHjZPfjGKmiuRlyS1NrYeaNaz0=; b=p/Yqekw/w/pEMSmOYKn7fTU5FYr/jCO29DbX3nwMmu+0tSXU4b/utzx7FEhLpvI1D4R5 BFWE2d/18+hGQGBMlcX6UpJ5vawXQ8UGJrHexIwH4JZO66QPSybTgeC3PRxAfAAYeI75 Q3VBsvvWmYCkJ6C2zvwBQlmJaLIhqLDRD/nTq4HZw7Ogn3Qz14R4MgNsfzVszTpA7SZD 4xS1cToFUU9lqYL5LgOjJg1xEnEerAH8Jkes6Aks4ulEk/3wBHN2qOAjOTn1stsTovc3 4JKZYihumRRTKS0clbmRnlVuBN4zzFLgN5dsmT7cckoI4ovhZCSzEufjB5sqyKwlb7Ds Qg== Received: from iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta03.appoci.oracle.com [130.35.103.27]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3phkey806x-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 24 Mar 2023 21:07:10 +0000 Received: from pps.filterd (iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (8.17.1.5/8.17.1.5) with ESMTP id 32OJt5aB027817; Fri, 24 Mar 2023 21:07:09 GMT Received: from pps.reinject (localhost [127.0.0.1]) by iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with ESMTPS id 3pgxk4se4y-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 24 Mar 2023 21:07:09 +0000 Received: from iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 32OL76fG017159; Fri, 24 Mar 2023 21:07:09 GMT Received: from ca-mkp2.ca.oracle.com.com (mpeterse-ol9.allregionaliads.osdevelopmeniad.oraclevcn.com [100.100.251.135]) by iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with ESMTP id 3pgxk4se2p-8; Fri, 24 Mar 2023 21:07:09 +0000 From: "Martin K. Petersen" To: ketan.mukadam@broadcom.com, jejb@linux.ibm.com, Tom Rix Cc: "Martin K . Petersen" , linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] scsi: be2iscsi: set some be_main.c variables storage-class-specifier to static Date: Fri, 24 Mar 2023 17:06:59 -0400 Message-Id: <167969123957.59527.2708612963090557447.b4-ty@oracle.com> X-Mailer: git-send-email 2.40.0 In-Reply-To: <20230314005157.536918-1-trix@redhat.com> References: <20230314005157.536918-1-trix@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.254,Aquarius:18.0.942,Hydra:6.0.573,FMLib:17.11.170.22 definitions=2023-03-24_11,2023-03-24_01,2023-02-09_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 suspectscore=0 malwarescore=0 spamscore=0 mlxlogscore=999 adultscore=0 mlxscore=0 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2303200000 definitions=main-2303240160 X-Proofpoint-GUID: bJoePzynSm6iCXUMSV1q0FSQO4-1qMP7 X-Proofpoint-ORIG-GUID: bJoePzynSm6iCXUMSV1q0FSQO4-1qMP7 X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 13 Mar 2023 20:51:57 -0400, Tom Rix wrote: > smatch reports several warnings > drivers/scsi/be2iscsi/be_main.c:148:1: warning: > symbol 'dev_attr_beiscsi_log_enable' was not declared. Should it be static? > drivers/scsi/be2iscsi/be_main.c:158:1: warning: > symbol 'dev_attr_beiscsi_drvr_ver' was not declared. Should it be static? > drivers/scsi/be2iscsi/be_main.c:159:1: warning: > symbol 'dev_attr_beiscsi_adapter_family' was not declared. Should it be static? > drivers/scsi/be2iscsi/be_main.c:160:1: warning: > symbol 'dev_attr_beiscsi_fw_ver' was not declared. Should it be static? > drivers/scsi/be2iscsi/be_main.c:161:1: warning: > symbol 'dev_attr_beiscsi_phys_port' was not declared. Should it be static? > drivers/scsi/be2iscsi/be_main.c:162:1: warning: > symbol 'dev_attr_beiscsi_active_session_count' was not declared. Should it be static? > drivers/scsi/be2iscsi/be_main.c:164:1: warning: > symbol 'dev_attr_beiscsi_free_session_count' was not declared. Should it be static ? > > [...] Applied to 6.4/scsi-queue, thanks! [1/1] scsi: be2iscsi: set some be_main.c variables storage-class-specifier to static https://git.kernel.org/mkp/scsi/c/1efbacd2b95a -- Martin K. Petersen Oracle Linux Engineering