Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <eab20109-ffa2-461c-92ff-3eec4fa5c8a8@collabora.com>
Date:   Sat, 25 Mar 2023 02:12:55 +0500
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.9.0
Cc:     Muhammad Usama Anjum <usama.anjum@collabora.com>,
        damon@lists.linux.dev, linux-mm@kvack.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm/damon/sysfs: make more kobj_type structures constant
Content-Language: en-US
To:     =?UTF-8?Q?Thomas_Wei=c3=9fschuh?= <linux@weissschuh.net>,
        SeongJae Park <sj@kernel.org>,
        Andrew Morton <akpm@linux-foundation.org>
References: <20230324-b4-kobj_type-damon2-v1-1-48ddbf1c8fcf@weissschuh.net>
From:   Muhammad Usama Anjum <usama.anjum@collabora.com>
In-Reply-To: <20230324-b4-kobj_type-damon2-v1-1-48ddbf1c8fcf@weissschuh.net>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Precedence: bulk

On 3/24/23 8:35 PM, Thomas Weißschuh wrote:
> Since commit ee6d3dd4ed48 ("driver core: make kobj_type constant.")
> the driver core allows the usage of const struct kobj_type.
> 
> Take advantage of this to constify the structure definition to prevent
> modification at runtime.
> 
> These structures were not constified in
> commit e56397e8c40d ("mm/damon/sysfs: make kobj_type structures constant")
> as they didn't exist when that patch was written.
> 
> Signed-off-by: Thomas Weißschuh <linux@weissschuh.net>
Reviewed-by: Muhammad Usama Anjum <usama.anjum@collabora.com>

> ---
>  mm/damon/sysfs-schemes.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/mm/damon/sysfs-schemes.c b/mm/damon/sysfs-schemes.c
> index 3cdad5a7f936..50cf89dcd898 100644
> --- a/mm/damon/sysfs-schemes.c
> +++ b/mm/damon/sysfs-schemes.c
> @@ -384,7 +384,7 @@ static struct attribute *damon_sysfs_scheme_filter_attrs[] = {
>  };
>  ATTRIBUTE_GROUPS(damon_sysfs_scheme_filter);
>  
> -static struct kobj_type damon_sysfs_scheme_filter_ktype = {
> +static const struct kobj_type damon_sysfs_scheme_filter_ktype = {
>  	.release = damon_sysfs_scheme_filter_release,
>  	.sysfs_ops = &kobj_sysfs_ops,
>  	.default_groups = damon_sysfs_scheme_filter_groups,
> @@ -503,7 +503,7 @@ static struct attribute *damon_sysfs_scheme_filters_attrs[] = {
>  };
>  ATTRIBUTE_GROUPS(damon_sysfs_scheme_filters);
>  
> -static struct kobj_type damon_sysfs_scheme_filters_ktype = {
> +static const struct kobj_type damon_sysfs_scheme_filters_ktype = {
>  	.release = damon_sysfs_scheme_filters_release,
>  	.sysfs_ops = &kobj_sysfs_ops,
>  	.default_groups = damon_sysfs_scheme_filters_groups,
> 
> ---
> base-commit: 1e760fa3596e8c7f08412712c168288b79670d78
> change-id: 20230324-b4-kobj_type-damon2-0238ee9e8d8c
> 
> Best regards,

-- 
BR,
Muhammad Usama Anjum