Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <3a21a541-d725-a199-0237-ed16cad29a28@amd.com>
Date:   Fri, 24 Mar 2023 16:52:14 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.8.0
Subject: Re: [PATCH v2 3/5] pci/aer: Export cper_print_aer() for CXL driver
 logging
Content-Language: en-US
To:     Bjorn Helgaas <helgaas@kernel.org>
Cc:     alison.schofield@intel.com, vishal.l.verma@intel.com,
        ira.weiny@intel.com, bwidawsk@kernel.org, dan.j.williams@intel.com,
        dave.jiang@intel.com, Jonathan.Cameron@huawei.com,
        linux-cxl@vger.kernel.org, rrichter@amd.com,
        linux-kernel@vger.kernel.org, bhelgaas@google.com
References: <20230324214159.GA2660001@bhelgaas>
From:   Terry Bowman <Terry.Bowman@amd.com>
In-Reply-To: <20230324214159.GA2660001@bhelgaas>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dmdBcXN6Z3hZNEloMEhkeGlkdmxGMXZKVHkzQUJML0tkUGNldXBBeHJOV2RT?=
 =?utf-8?B?YUZOZ3J6UHhCTnljUVNTTFRhYnQ4b2JoK2tKSTYzZWZzeEVRYTdlL0FqL1VH?=
 =?utf-8?B?Vk1ONEw3K1NXYWkyS0xVQkI3VENqcWJZaCs2QVB4WS9hL1NSZTgyUDFJZkpW?=
 =?utf-8?B?c0VCa2NYU2IrYng4N3NuVmM5aUdYVW5MR25sbUFqTnJhdm03Z25xVG8xZTBW?=
 =?utf-8?B?bEdJdFljSHB1ZjJCMmRZTExNcWw5ZTkxejVyRHVBbERGZ0NRUmsweXhQaldJ?=
 =?utf-8?B?YWxiQWU3cUNwd3ZxQlZvejUwVVFSQUtJd1EvVzNwZmdvdml2RlRvNHNTWEJj?=
 =?utf-8?B?WDhzUjlGemZLSlp3bHg0ZXAwTWNBbjFkVDhKTGJVQXNKZkVBZENWRmxmTEk3?=
 =?utf-8?B?Ymp1SGhVd25xK1BPTlBqVU1GNGl3NGFBdStIV1BKRVF0OVZjRXlxNnFQRHRx?=
 =?utf-8?B?aVJHb2llV2FvU2xJSlUvUGlSQ01yaWozeWNMMXRnT2o1ODcrTFFQeVc3RjFH?=
 =?utf-8?B?QnFOSk1oMFJSVm1FMTdLS09UZDZpa3ordTV5Wi8reEk2WXRMMkZaR0tVS3px?=
 =?utf-8?B?eEtYUlZsYXJUaEwwT2owNzJOdkE1Nk9SVFBiT2tUR3ZMd29ieUFkQzRCL04v?=
 =?utf-8?B?Q3k2QkpiZlpuYk1aWi9LLy9SVmVtblBUVzc1STdJNFB6QWJrQVFSLytnVHJL?=
 =?utf-8?B?UmQxYkRvWFlDTFAvejRYUnpqbVA3eTY5ajUrSTV5ODFhaHhrRi9pOTB5Ni85?=
 =?utf-8?B?NzZoS3hpNnhxbFk0UGZQN1c0clArSTJYSXoyRkhCKzNOT0xkanFJYWFqMlBv?=
 =?utf-8?B?SHdudTlodklKQTZaSzJUaWRySXVqSk56WnpXYzIzTENodDBteTN4ZHhtNEZP?=
 =?utf-8?B?T2tTWEs4UFk1Nlk4RTVsVlU2STNkRmFacW5UMEF1NW5OdHl0TEJqTnh4cFhp?=
 =?utf-8?B?ZEdBSmJkSXNSLy9nTURlanBVckVxRzV4MHJ4dXJqbmVqK3k2eHhoRTNFMWFF?=
 =?utf-8?B?djlKYjB2NDl0eVMxVE9FbDd1TTdYcVg5bW41UDY2K2F5N3l4OTR5OE9pQktD?=
 =?utf-8?B?OC96eW1uMG1sYU5jQ3VwcHl3ZldEZlRWTWhEeFo5R0JDM25xQWlTYW16bkRu?=
 =?utf-8?B?K2VzcFhIdlVJd3hJMlBMRlgraHVjZWhyR2xWTU1uTXVQK3ZPbllNOUd0REs4?=
 =?utf-8?B?UHlseWZjSDZHVGgra1Nqa3pPUzdIQ0NXV21XMXkrUkJna2xoK2VPTjJGbmVj?=
 =?utf-8?B?V1NRL003R1crSnB1dTk0SHJJOXZ3SlBlNW5EM1BaWW5rOUgvODVDc1dpTGp1?=
 =?utf-8?B?N0VZNnZLRm4vd0pWVTFEM2tqdTJKYm1xUWFySCtmRkVZcW5yYlFqZ2Q1OWZV?=
 =?utf-8?B?cGEvQjk1b1QzK3ZEU0kyd2VVQ0szUktxOHdWTklraWM1NmVzQkRjV09yaW1a?=
 =?utf-8?B?dTdBZmgva0FHbFNEekZML0ljcXd3a1lTTkY4dkNabFlzQ3pqZG9kZitVaWVt?=
 =?utf-8?B?ZnZuK1BCYVhhc25lS1JweEtVd1dzTmRWQ00xb1BWeXQ5c3VDR0JoaWtqT2R0?=
 =?utf-8?B?Tng0M0tKZ20vU3pHUU14QXQ0d1ZtL28ySUc1aG44enFHWUJrSE83aXNqbTBh?=
 =?utf-8?B?eVZ3VnFRM1JsMEdTaDJCMFc1bDBtUlhRL0JOOW9TMFJjb2Jla01xN2F5MTBa?=
 =?utf-8?B?OE92RXIxSmpOanowMzl0QzdENXZrYjRyNk4rWU51MXBGZ1pJOGpGZi9KV0tj?=
 =?utf-8?B?RmFLbnM3WmpkNktraTYyOHdydVBxN3FBWkQwUVgyais3Q1Zwb0k0Y3p0aWQv?=
 =?utf-8?B?Q2pzOVpZak96SERIL0ViUk5pZzk2MFdOSjVRMWFRT2RSR0tMVkZjNitUSUcx?=
 =?utf-8?B?Yml3SWNCcHlMWEZNd3pLT2E4clRScHlmV3lNdysxY29BZlFQSXE4MEYwekZ5?=
 =?utf-8?B?K3RhVUxZRXNmUEl4bmpZUDh3cTdLSnR6aGlseGJ4OXlkVmE4VWIzZ3p5cGZJ?=
 =?utf-8?B?QlpmbGdoQU9rQWZmVmdQRjVXelVjV0ZMS1BoWWFHWHJmbVorQi94c1E3bGlR?=
 =?utf-8?B?NzdHbXk5WlE3M1VHWXRhWjc5SGtkTVhtWFk5a3ZIWk1LbkRLTzhiNklOSW95?=
 =?utf-8?B?cm5hd0oyR3lMWG82b0FERWUwRllYY0R1QUQwby9DV1pEZWM2a0dlM2RuUTBW?=
 =?utf-8?Q?LZL8/JzyA2+kyWqJC/EC+BRt5LE/ZH4+3o9CbJ8kofqZ?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 38760abe-c25c-4946-cacc-08db2cb209c2
X-MS-Exchange-CrossTenant-AuthSource: DS0PR12MB6390.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Mar 2023 21:52:18.4493
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: PRKNrR6N2vYR4y5Idc/RkOIhAUE2uqzmPA5QkJUPYLbN2ExhNdpiIl8nY5kvuNxSOQRegq6x4XJNCcufiUdY0w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR12MB4470
X-Spam-Status: No, score=-0.2 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
        DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,NICE_REPLY_A,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE
        autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 3/24/23 16:41, Bjorn Helgaas wrote:
> On Thu, Mar 23, 2023 at 04:38:06PM -0500, Terry Bowman wrote:
>> The CXL driver plans to use cper_print_aer() for restricted CXL host
>> (RCH) logging. cper_print_aer() is not exported and as a result is not
>> available to the CXL driver or other loadable modules. Export
>> cper_print_aer() making it available to CXL and other loadable modules.
>>
>> Signed-off-by: Terry Bowman <terry.bowman@amd.com>
>> Cc: Mahesh J Salgaonkar <mahesh@linux.ibm.com>
>> Cc: "Oliver O'Halloran" <oohall@gmail.com>
>> Cc: Bjorn Helgaas <bhelgaas@google.com>
>> Cc: linux-pci@vger.kernel.org
> 
> Acked-by: Bjorn Helgaas <bhelgaas@google.com>
> 
> But please update the subject line to:
> 
>   PCI/AER: Export cper_print_aer() for use by modules
> 
> to match previous history.
> 

Hi Bjorn,

Yes, I'll update the subject line. Thanks.

>> ---
>>  drivers/pci/pcie/aer.c | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/pci/pcie/aer.c b/drivers/pci/pcie/aer.c
>> index 625f7b2cafe4..7f0f52d094a4 100644
>> --- a/drivers/pci/pcie/aer.c
>> +++ b/drivers/pci/pcie/aer.c
>> @@ -809,6 +809,7 @@ void cper_print_aer(struct pci_dev *dev, int aer_severity,
>>  	trace_aer_event(dev_name(&dev->dev), (status & ~mask),
>>  			aer_severity, tlp_header_valid, &aer->header_log);
>>  }
>> +EXPORT_SYMBOL_GPL(cper_print_aer);
>>  #endif
>>  
>>  /**
>> -- 
>> 2.34.1
>>