Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 24 Mar 2023 15:18:09 -0700
From:   Ira Weiny <ira.weiny@intel.com>
To:     Khadija Kamran <kamrankhadijadj@gmail.com>,
        <outreachy@lists.linux.dev>
CC:     Parthiban Veerasooran <parthiban.veerasooran@microchip.com>,
        "Christian Gromm" <christian.gromm@microchip.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        <linux-staging@lists.linux.dev>, <linux-kernel@vger.kernel.org>
Subject: Re: [RESEND PATCH] staging: most: fix line ending with '(' in dim2
Message-ID: <641e21a1235f6_325e1f2949@iweiny-mobl.notmuch>
References: <ZBxLT4w0cKZ/aOZo@khadija-virtual-machine>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <ZBxLT4w0cKZ/aOZo@khadija-virtual-machine>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?Kt07X1UBsLyIS7+cOHysdbQ0Xx8a0pKRmLhWo68Pk865/jw0X748M6PJERX5?=
 =?us-ascii?Q?iX2p0UHXFUy48y4up5EC7xZDQ/niAjbFhpiRvVaKy//VwwycZtifgfmW+sBk?=
 =?us-ascii?Q?1ZDqD/11bnTJabYihP+6U3s6qSkLzOvPCi/KOS7ibC3/pHGTil4k9Bj0uLdN?=
 =?us-ascii?Q?mXdmNFPLWRp594x9v/PXDND52vvtiDxnIULu9NrlK+3ZqlsbpId8FAN+UsDj?=
 =?us-ascii?Q?ZQjh4dfFy8MBrXqCjzIJjX2BSWnfn5KANKKNuXshzm4Co/Ur00qmpzZTQt2G?=
 =?us-ascii?Q?xBKIlyq7dvtAC7mEXv3aThLRH4zRsMh73Cognzz7/Su9i1lI0HxS7m4RTy0E?=
 =?us-ascii?Q?4XydOtqQBmkuQ3ZxhVBY1XFsmSfdxhqh1C+3JlqpEgvVXdCaL1tZeVvKIeOW?=
 =?us-ascii?Q?W6YcrSEfPuO9fRCLHmmdxPXn9wWTpx4F4FhwWj23pRi264PEIG70mgWM+u+s?=
 =?us-ascii?Q?wy/knEb+J7wswAEkfobNuNcd4QoWkv0BbJpOl719okhlev3cG5G4oIEkhF+m?=
 =?us-ascii?Q?SJUQV9FyKvlLi1REIg1tt+jrG9ZWaZ7q5R6SWO21ANgHKarMayAqoEuc9g2Y?=
 =?us-ascii?Q?vDX6D5KODsA30uSsgBkRxIt/6z2JtMinS0xCGUIBeMvfpZGzif/4fcYrk81e?=
 =?us-ascii?Q?ESuE9oXVrew7nkGKegsHmswli2zG/iKipU/0TiIikpPkUZp1jEE3ktkMfXAm?=
 =?us-ascii?Q?V2n6HwMdYOR9ajNrXVfzFJ2o0NvUYa3NEalbtIQY4u3X69lrPls7OelpuoVK?=
 =?us-ascii?Q?Z6Mxq8eivSk6oSfoYrye4IdtuN8g+5ztuDb+k0riX21kTVJ5MW3dSwY5Q2/R?=
 =?us-ascii?Q?YhJT5PAtjBnwRmAR3YzMw/86sgm2mHyZqNyGyN2wxxQwIvcZqnLw42rW51FG?=
 =?us-ascii?Q?TkkDtknk3fm3tx1BQYDjp0ZUkNb7dlwSLC5rGp+HJf0ugf1AmywOWXeGpI4Y?=
 =?us-ascii?Q?+lqe2tMac99Y6yQdl+3Y691/y6AU3JFw0dRbcC2xZDev6Tp/yujcxpFc4yzL?=
 =?us-ascii?Q?8WghUbrtD6EaFafE1aZv+yiEehLczczcF3vpxvArbAaPHoJKbNUnExgX8+oD?=
 =?us-ascii?Q?m+ViiIPaY/Rlk98c4touTLUiulBrwqr2C0PtR56ZvWMfDAluKZAukonsgHc9?=
 =?us-ascii?Q?mIoj7CC80SIfhOynVzX6p8HeiS+VvqyL7FYqfDjDW59nSVh/ssFq/EkHJjfO?=
 =?us-ascii?Q?Cusvq3RQcpvdbZm9b+gS6OiMaIhEdhnrJa8UbIsPIeuEkDFiY3YcTQiQ/xX1?=
 =?us-ascii?Q?JndQeCVEYPuQDPufCapPyaq9OL1bOGhqye23jfFFebmAHPO2M1VPr2ulhinj?=
 =?us-ascii?Q?O2PL6vrJctPT1NoJEV2DId+HgV5x8cYuaIiPxjgya6BWe4iDq2+H+LXIwcpA?=
 =?us-ascii?Q?Z2sTU2ujldJxHUGd5l6wZRR0a9fjg+8/uuzssv4rlIoxckojZTrrmfDU5WIP?=
 =?us-ascii?Q?yF/yIBa18+j+L13nLVK7E2oGGBSMI9Uduwc296ZG7a31rxeX2fZzt3EXJ+Ou?=
 =?us-ascii?Q?gqhLbCjB68siGkxMwpl6MtB33MPkME1FiYUlNB/KHSAjX8KpC291wkg/Djzu?=
 =?us-ascii?Q?vhNnl1SFp0L7lqQwU4W1s8VF8LyuIS4czjTw7XK2?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 3889da08-688b-433a-d8ed-08db2cb5a7bd
X-MS-Exchange-CrossTenant-AuthSource: SA1PR11MB6733.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Mar 2023 22:18:12.0040
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 4xvtNLiTPIDwLyRekH9wIShY0xBr6tJCSlYnLDSC2SinOrZyJkNInExHcuyBXSjQoOptiX97KpZrmRgmg6QE3Q==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR11MB5680
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-2.5 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_PASS,
        SPF_NONE autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Khadija Kamran wrote:
> Splitting function header to multiple lines because of 80 characters per
> line limit, results in ending the function call line with '('.
> This leads to CHECK reported by checkpatch.pl
> 
> Move the function parameters right after the '(' in the function call
> line. Align the rest of the parameters to the opening parenthesis.
> 
> Signed-off-by: Khadija Kamran <kamrankhadijadj@gmail.com>
> ---
>  drivers/staging/most/dim2/hal.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/staging/most/dim2/hal.c b/drivers/staging/most/dim2/hal.c
> index a5d40b5b138a..6abe3ab2b2cf 100644
> --- a/drivers/staging/most/dim2/hal.c
> +++ b/drivers/staging/most/dim2/hal.c
> @@ -346,9 +346,8 @@ static void dim2_clear_ctram(void)
>  		dim2_clear_ctr(ctr_addr);
>  }
>  
> -static void dim2_configure_channel(
> -	u8 ch_addr, u8 type, u8 is_tx, u16 dbr_address, u16 hw_buffer_size,
> -	u16 packet_length)
> +static void dim2_configure_channel(u8 ch_addr, u8 type, u8 is_tx, u16 dbr_address,

NIT: This introduces a long (> 80 char) line for not a great reason.
Since you are changing it anyway how about?

static void dim2_configure_channel(u8 ch_addr, u8 type, u8 is_tx,
				   u16 dbr_address, u16 hw_buffer_size,
				   u16 packet_length)

Ira

> +				   u16 hw_buffer_size, u16 packet_length)

>  {
>  	dim2_configure_cdt(ch_addr, dbr_address, hw_buffer_size, packet_length);
>  	dim2_configure_cat(MLB_CAT, ch_addr, type, is_tx ? 1 : 0);
> -- 
> 2.34.1
> 
>