Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 24 Mar 2023 15:21:54 -0700
From:   Ira Weiny <ira.weiny@intel.com>
To:     Khadija Kamran <kamrankhadijadj@gmail.com>,
        <outreachy@lists.linux.dev>
CC:     Parthiban Veerasooran <parthiban.veerasooran@microchip.com>,
        "Christian Gromm" <christian.gromm@microchip.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        <linux-staging@lists.linux.dev>, <linux-kernel@vger.kernel.org>
Subject: Re: [RESEND PATCH] staging: most: fix line ending with '(' in video
Message-ID: <641e228264b79_325e1f294fc@iweiny-mobl.notmuch>
References: <ZBxL/yqLU1dEQlta@khadija-virtual-machine>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <ZBxL/yqLU1dEQlta@khadija-virtual-machine>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?pbJiv+AogSDvcbhOf68hwbbFxi5ofutqJD51buhyq9d/aEihVzA7DWrn3hnD?=
 =?us-ascii?Q?jqyeFaCJtGqM3pA2ydS5QDFdyHl94iGpTW2XUqeSO4E23I/QQK/iI8jmVbBo?=
 =?us-ascii?Q?4yV5s68boCJvDIMR5TvEZu0TghRAp3Uy/e8BT3EshQVV1ehcWh2tJR/Mu7ry?=
 =?us-ascii?Q?lTqNtRWDkWNvafmak/dL0iFgxnJZfRn4RiaO0G0YlhOLxDbSO5fP0SjTdE5g?=
 =?us-ascii?Q?+VAMczYLclOb6PHPEi2Jx8hPchw6AvhlBUPNrW2YII9DZH6zbC4GmRJdPfY1?=
 =?us-ascii?Q?N2ri7ixC73R87drE51dnlYKH+25bMZ86Fj5dYpiXoK9APSlLbpSjO0TUoequ?=
 =?us-ascii?Q?XoFEBCc4mNj2P9/XNzLYIPXu/+82nlFYF5Qi0SYiNca0xpZsHwA3+PnA2FRe?=
 =?us-ascii?Q?DoQntg6ycVzyJXtmOU1aWDwUPbt/TwyOKu4TPz8WeI4vu6QQpQLX2GlM2zQG?=
 =?us-ascii?Q?J8cx/2d1OapZiWBRkqgHqFnq1mGUKDqKj/FY1EZAmjBPzTq30IitGuv8Y6De?=
 =?us-ascii?Q?6vm6/DTK34l30t12DzzG9Nt6zWm12ucG809rQ/amMpHQfhb0YoMzIB6nDbbX?=
 =?us-ascii?Q?QW0eUkdX/T635A1td4VO8IffcjAAzvA11sa0LEiq6VhexbhEteqqXIjPtghf?=
 =?us-ascii?Q?UG6nnhA6enwD5IGzMLjiMKp5KTm0gLp5JaNvzyR2F8wfGqjYPeAaJwvDCAHO?=
 =?us-ascii?Q?GhqbP9KcDdhR/WkyN42kpmDgO5gs/LLfVzh+ChLypVTF1Zw2dOzsf9IjRqoF?=
 =?us-ascii?Q?+5A3/cVVX52WiFwH9Zv1S7RBkDBxTrsshTghzeADLVSCMbeMC3njNdVXk5/3?=
 =?us-ascii?Q?n5oTebvvWz7+qxJH8eF6DsR4Bb63zltX2wVXT9IE8Xy3Uos+xF5osDtxeOIl?=
 =?us-ascii?Q?kypiMwmt62epsGK9ih6rsLSCmwZW4X7M+EX3BQltVgI+zXtB+pIwfthlye1Q?=
 =?us-ascii?Q?vgjz6obAb0hyD2AOyZhwhb+WCrA1r2hHcZBr0fyYWHWVu3++1QHpGqktcWZt?=
 =?us-ascii?Q?Ko0x8NqxXPxy0wsWh60P41l3+cTHL+xoznBBEwa7h5OlpMho5coVW/+rRkEV?=
 =?us-ascii?Q?mvdk/+6knghZDvsGB61lJNg7VGNH7NoYhvbsajHkphlKThCznNKMgupSalN9?=
 =?us-ascii?Q?DXhQ21i/z9VEmUQMthHx4c6YN4noKL6XCiGtLcAQs7IdyMyu+f+NDMz2XW7r?=
 =?us-ascii?Q?5sLGLdIVfa+0gHHs41ikMK/wz555hBApCtDz8mNE5wInh1ulJyf198BIAptO?=
 =?us-ascii?Q?811TM4yiK9tGGvEQmrSLMiPl7QaCD5zXPxOXricjAwekSVueOpIZq+QOB5Ot?=
 =?us-ascii?Q?s8YsLo7DF82Xjp4byb81iZrop0jGD8A9LeecnffxM2Vpjh3Jx8f6gCsZYty+?=
 =?us-ascii?Q?qj41DapH19B3taa8hZhkGNxFzQ4j73Ke3EuJ5xcjqKqGuDolhV7EwnKwTPaj?=
 =?us-ascii?Q?h4C1AYucVtxeMNzlYHPugjsFDtkH65bM1XJ2LI3b3O+8jwMsP6uBJCpam4ml?=
 =?us-ascii?Q?NA8xTSlTiBF9JkMUwzOgnFFbJ0yHTiP9jl3yGWXVNUM1RB22wTZ0Zg3x4KfU?=
 =?us-ascii?Q?SZEks4jdbGghjAxAtJ3XeZPYzGFYVjYt97VkjtxP?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 4bb70b95-c0ac-450d-a5c0-08db2cb62e6b
X-MS-Exchange-CrossTenant-AuthSource: SA1PR11MB6733.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Mar 2023 22:21:58.0658
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 4MAHVN+WZ54ctq/oXSDPX0XMg0g7PVj+YtHdg8SYUxKCOVsX5qrzMbsaUJEWUgkpSQiulaOssXm0eb3SNAbd/Q==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR11MB5680
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-2.5 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE,
        SPF_NONE autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Khadija Kamran wrote:
> Splitting function header to multiple lines because of 80 characters per
> line limit, results in ending the function call line with '('.
> This leads to CHECK reported by checkpatch.pl
> 
> Move the function parameters right after the '(' in the function call
> line.
> 
> Signed-off-by: Khadija Kamran <kamrankhadijadj@gmail.com>
> ---
>  drivers/staging/most/video/video.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/most/video/video.c b/drivers/staging/most/video/video.c
> index ffa97ef21ea5..6254a5df2502 100644
> --- a/drivers/staging/most/video/video.c
> +++ b/drivers/staging/most/video/video.c
> @@ -365,8 +365,7 @@ static const struct video_device comp_videodev_template = {
>  
>  /**************************************************************************/
>  
> -static struct most_video_dev *get_comp_dev(
> -	struct most_interface *iface, int channel_idx)
> +static struct most_video_dev *get_comp_dev(struct most_interface *iface, int channel_idx)

I know the 80 char limit is not strictly enforced anymore but I, and some
other maintainers, like to see it adhered to unless there is a really good
reason to violate it.  How about?

static struct most_video_dev *get_comp_dev(struct most_interface *iface,
					   int channel_idx)

Ira

>  {
>  	struct most_video_dev *mdev;
>  	unsigned long flags;
> -- 
> 2.34.1
> 
>