Received: by 2002:a05:6358:11c7:b0:104:8066:f915 with SMTP id i7csp1765044rwl; Fri, 24 Mar 2023 15:25:54 -0700 (PDT) X-Google-Smtp-Source: AKy350ahCoZMuSY82ATTVMN7FRoHlDYAuJYmME+V87V8QtHLEYL2zAK9SPNpmgetmWcg9ks9RPtZ X-Received: by 2002:a17:906:2dd6:b0:931:462f:f141 with SMTP id h22-20020a1709062dd600b00931462ff141mr3901796eji.20.1679696754376; Fri, 24 Mar 2023 15:25:54 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1679696754; cv=none; d=google.com; s=arc-20160816; b=btINvcxNf4mmeiYEM35Jsq0ysHGSAQt/rWZa0syxyOLs6YJlGOm55GT/e4cDIBQiAy +4eJawtNGpBbCDR+6YfN9TKzIbvM8DjB/55Y4iXP17tXf65fZ55gY3eZ7EV1mVHkqOoM 8enk+WM9z8/Q2GdwAg35661iT29Av6Yty6WumR7ZuD4W2ZD3k5a7ZE1c2Qhp7OuOtx4T u3GtK4Ht5hngjQ6UBJSwSl/rHW7borEyYHGSc56weaAvgAHaw9M4J/gZ48hV0LnevBKL njdGM/TBK86lIFMrjvdW5bNXyj7yC7V4iRaavTPxAeObXRh05TSPBXNVJXnwUEqThDMp 9Xgg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=qfo0BLzIV++drYzkU45P3MSEyypvlv0tFWK+3aZYqRo=; b=GlOflOlyv/DZAZQJL0KBGVRF0i/BzuZiy8yvAvM5bYRC8htA85m4hCepIKoFSIydGC VPhrc+Zyz4Vk8Uj5OShtO62e48dDT8zQEwHRWHlk7dw3tvppqviWMgYOqFBlo7VaGAA8 LytMsJwJ5+upuEymHMa0LOADY58CIFOgb2kAl6EbL54u8Rag5wFq9uOTrGBjC+uEX8qU xbT5lv9PbnvwSPZ3ewLJQbp51cR5RttdIP+j27Wu1DCwXdAcAXv6XeWMKsSrs20EYJ4C HHICnuLGro6CDlssmgTgP5lq3YEJfX1UPXZqdy0nbpXkX/YkinV9abnTmcAstB1EhMGJ v1fA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=SnvgZqIe; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id f2-20020a170906138200b00925a9b6ed47si1719400ejc.755.2023.03.24.15.25.26; Fri, 24 Mar 2023 15:25:54 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=SnvgZqIe; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231833AbjCXWXY (ORCPT + 99 others); Fri, 24 Mar 2023 18:23:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33468 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231716AbjCXWXP (ORCPT ); Fri, 24 Mar 2023 18:23:15 -0400 Received: from mail-wr1-x434.google.com (mail-wr1-x434.google.com [IPv6:2a00:1450:4864:20::434]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 456B24EC7 for ; Fri, 24 Mar 2023 15:23:14 -0700 (PDT) Received: by mail-wr1-x434.google.com with SMTP id v1so3181129wrv.1 for ; Fri, 24 Mar 2023 15:23:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1679696593; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=qfo0BLzIV++drYzkU45P3MSEyypvlv0tFWK+3aZYqRo=; b=SnvgZqIejzPP+txUq1VaZBVdHE+2/Me7UoF0OmMrSrSmyJNRffn0WcWtjcOLpWn032 AEJnxRB/HIm7aXAbqN9r6bollXZxi761HkVtNTByH3s9rdmxukvM5mcINdJGCpLaaHPE UjqZXzF1n8O69n0Qgg1FFSA2euWoe/3ZWZ/Jqttol53t1AWM0kAdZyc+g1EKHWRT6oLs 1DIKDEb+Iq8Pj7n2ncwHFESoPBuSeF3tjaOJbu+f9yrU0dxvdPRTqeOTgXWkU6vHPjr7 ZSYNA8uqr0oCDnCIBYuwMGvkHNCYl1oqWKLfFEL+2rIVpnDWfHjeZnBjfdb85haGPtxX eW/Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679696593; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=qfo0BLzIV++drYzkU45P3MSEyypvlv0tFWK+3aZYqRo=; b=mzWAKjxWx8i6XHZ5L2+6Ica8xtbZ2dSVWtkyv7AKP3ktP3k7xv11s5rl7BkqbmItob bwFn82U4fi3WgYGHBqhkhbPtmPWBQ5FnRhQFoT9B2YBmNR4SlRhUuJFY1Bz/NLrP90ut 1kxaGJ0wLNGvlL8EGQuTFBPdOQenDncS0EDjdTnNZNfwt8uiNLKZC4AsulNax1t+FTgI oKZNawuUAgCF4/b1bD9aAcKuR/kA2lnordx7+NK71rrAcHIAd+me6dqA1TOflO0gV6E7 bxMcLPIqnvruKX7SfI8+0YyT0jweUcIGF0wuX0CYJj7l0mQO+D7I2ZIVMIhEmx+gzOFM XYVA== X-Gm-Message-State: AAQBX9c0a5xkoJIJb95EnFxKek+ODLHFgj5RI11HKbnax86DCeKhMeDo 5jeRmVGvCOcB7LM47rOIA5Q= X-Received: by 2002:a5d:63c1:0:b0:2cf:e8d2:b550 with SMTP id c1-20020a5d63c1000000b002cfe8d2b550mr3394545wrw.14.1679696592715; Fri, 24 Mar 2023 15:23:12 -0700 (PDT) Received: from khadija-virtual-machine.localdomain ([39.41.14.14]) by smtp.gmail.com with ESMTPSA id m8-20020a5d4a08000000b002c3f03d8851sm19161446wrq.16.2023.03.24.15.23.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 24 Mar 2023 15:23:12 -0700 (PDT) From: Khadija Kamran To: outreachy@lists.linux.dev Cc: gregkh@linuxfoundation.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH v4 3/4] staging: rtl8192e: add spaces around binary operators Date: Sat, 25 Mar 2023 03:23:03 +0500 Message-Id: <44a545cf8e99ebfdbfc3f5bb314f3828abe98558.1679696291.git.kamrankhadijadj@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-0.2 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Use spaces around binary operators as suggested by Linux kernel coding style guidelines. Issues reported by checkpatch.pl for the following binary operators: + , - , * , | , << Signed-off-by: Khadija Kamran --- drivers/staging/rtl8192e/rtllib_rx.c | 54 ++++++++++++++-------------- 1 file changed, 27 insertions(+), 27 deletions(-) diff --git a/drivers/staging/rtl8192e/rtllib_rx.c b/drivers/staging/rtl8192e/rtllib_rx.c index 7144a0630ea6..f627dfe66d90 100644 --- a/drivers/staging/rtl8192e/rtllib_rx.c +++ b/drivers/staging/rtl8192e/rtllib_rx.c @@ -356,7 +356,7 @@ rtllib_rx_frame_decrypt_msdu(struct rtllib_device *ieee, struct sk_buff *skb, } /* this function is stolen from ipw2200 driver*/ -#define IEEE_PACKET_RETRY_TIME (5*HZ) +#define IEEE_PACKET_RETRY_TIME (5 * HZ) static int is_duplicate_packet(struct rtllib_device *ieee, struct rtllib_hdr_4addr *header) { @@ -936,7 +936,7 @@ static int rtllib_rx_check_duplicate(struct rtllib_device *ieee, if (GetTs(ieee, (struct ts_common_info **)&pRxTS, hdr->addr2, (u8)Frame_QoSTID((u8 *)(skb->data)), RX_DIR, true)) { - if ((fc & (1<<11)) && (frag == pRxTS->rx_last_frag_num) && + if ((fc & (1 << 11)) && (frag == pRxTS->rx_last_frag_num) && (WLAN_GET_SEQ_SEQ(sc) == pRxTS->rx_last_seq_num)) return -1; pRxTS->rx_last_frag_num = frag; @@ -1619,23 +1619,23 @@ static int rtllib_qos_convert_ac_to_parameters(struct rtllib_qos_parameter_info case 1: /* BIT(0) | BIT(3) */ if (acm) - qos_data->wmm_acm |= (0x01<<0)|(0x01<<3); + qos_data->wmm_acm |= (0x01 << 0) | (0x01 << 3); break; case 2: /* BIT(4) | BIT(5) */ if (acm) - qos_data->wmm_acm |= (0x01<<4)|(0x01<<5); + qos_data->wmm_acm |= (0x01 << 4) | (0x01 << 5); break; case 3: /* BIT(6) | BIT(7) */ if (acm) - qos_data->wmm_acm |= (0x01<<6)|(0x01<<7); + qos_data->wmm_acm |= (0x01 << 6) | (0x01 << 7); break; case 0: default: /* BIT(1) | BIT(2) */ if (acm) - qos_data->wmm_acm |= (0x01<<1)|(0x01<<2); + qos_data->wmm_acm |= (0x01 << 1) | (0x01 << 2); break; } @@ -1979,7 +1979,7 @@ static void rtllib_parse_mife_generic(struct rtllib_device *ieee, info_element->data[3] == 0x04) { netdev_dbg(ieee->dev, "MFIE_TYPE_WZC: %d bytes\n", info_element->len); - network->wzc_ie_len = min(info_element->len+2, MAX_WZC_IE_LEN); + network->wzc_ie_len = min(info_element->len + 2, MAX_WZC_IE_LEN); memcpy(network->wzc_ie, info_element, network->wzc_ie_len); } } @@ -2139,10 +2139,10 @@ int rtllib_parse_info_param(struct rtllib_device *ieee, if (info_element->data[2] & 1) network->dtim_data |= RTLLIB_DTIM_MBCAST; - offset = (info_element->data[2] >> 1)*2; + offset = (info_element->data[2] >> 1) * 2; - if (ieee->assoc_id < 8*offset || - ieee->assoc_id > 8*(offset + info_element->len - 3)) + if (ieee->assoc_id < 8 * offset || + ieee->assoc_id > 8 * (offset + info_element->len - 3)) break; offset = (ieee->assoc_id / 8) - offset; @@ -2357,7 +2357,7 @@ static inline int rtllib_network_init( if (rtllib_is_empty_essid(network->ssid, network->ssid_len)) network->flags |= NETWORK_EMPTY_ESSID; stats->signal = 30 + (stats->SignalStrength * 70) / 100; - stats->noise = rtllib_translate_todbm((u8)(100-stats->signal)) - 25; + stats->noise = rtllib_translate_todbm((u8)(100 - stats->signal)) - 25; memcpy(&network->stats, stats, sizeof(network->stats)); @@ -2545,22 +2545,22 @@ static inline void rtllib_process_probe_response( "'%s' ( %pM ): %c%c%c%c %c%c%c%c-%c%c%c%c %c%c%c%c\n", escape_essid(info_element->data, info_element->len), beacon->header.addr3, - (le16_to_cpu(beacon->capability) & (1<<0xf)) ? '1' : '0', - (le16_to_cpu(beacon->capability) & (1<<0xe)) ? '1' : '0', - (le16_to_cpu(beacon->capability) & (1<<0xd)) ? '1' : '0', - (le16_to_cpu(beacon->capability) & (1<<0xc)) ? '1' : '0', - (le16_to_cpu(beacon->capability) & (1<<0xb)) ? '1' : '0', - (le16_to_cpu(beacon->capability) & (1<<0xa)) ? '1' : '0', - (le16_to_cpu(beacon->capability) & (1<<0x9)) ? '1' : '0', - (le16_to_cpu(beacon->capability) & (1<<0x8)) ? '1' : '0', - (le16_to_cpu(beacon->capability) & (1<<0x7)) ? '1' : '0', - (le16_to_cpu(beacon->capability) & (1<<0x6)) ? '1' : '0', - (le16_to_cpu(beacon->capability) & (1<<0x5)) ? '1' : '0', - (le16_to_cpu(beacon->capability) & (1<<0x4)) ? '1' : '0', - (le16_to_cpu(beacon->capability) & (1<<0x3)) ? '1' : '0', - (le16_to_cpu(beacon->capability) & (1<<0x2)) ? '1' : '0', - (le16_to_cpu(beacon->capability) & (1<<0x1)) ? '1' : '0', - (le16_to_cpu(beacon->capability) & (1<<0x0)) ? '1' : '0'); + (le16_to_cpu(beacon->capability) & (1 << 0xf)) ? '1' : '0', + (le16_to_cpu(beacon->capability) & (1 << 0xe)) ? '1' : '0', + (le16_to_cpu(beacon->capability) & (1 << 0xd)) ? '1' : '0', + (le16_to_cpu(beacon->capability) & (1 << 0xc)) ? '1' : '0', + (le16_to_cpu(beacon->capability) & (1 << 0xb)) ? '1' : '0', + (le16_to_cpu(beacon->capability) & (1 << 0xa)) ? '1' : '0', + (le16_to_cpu(beacon->capability) & (1 << 0x9)) ? '1' : '0', + (le16_to_cpu(beacon->capability) & (1 << 0x8)) ? '1' : '0', + (le16_to_cpu(beacon->capability) & (1 << 0x7)) ? '1' : '0', + (le16_to_cpu(beacon->capability) & (1 << 0x6)) ? '1' : '0', + (le16_to_cpu(beacon->capability) & (1 << 0x5)) ? '1' : '0', + (le16_to_cpu(beacon->capability) & (1 << 0x4)) ? '1' : '0', + (le16_to_cpu(beacon->capability) & (1 << 0x3)) ? '1' : '0', + (le16_to_cpu(beacon->capability) & (1 << 0x2)) ? '1' : '0', + (le16_to_cpu(beacon->capability) & (1 << 0x1)) ? '1' : '0', + (le16_to_cpu(beacon->capability) & (1 << 0x0)) ? '1' : '0'); if (rtllib_network_init(ieee, beacon, network, stats)) { netdev_dbg(ieee->dev, "Dropped '%s' ( %pM) via %s.\n", -- 2.34.1