Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 24 Mar 2023 15:23:53 -0700
From:   Ira Weiny <ira.weiny@intel.com>
To:     Khadija Kamran <kamrankhadijadj@gmail.com>,
        <outreachy@lists.linux.dev>
CC:     Parthiban Veerasooran <parthiban.veerasooran@microchip.com>,
        "Christian Gromm" <christian.gromm@microchip.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        <linux-staging@lists.linux.dev>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] staging: most: fix line ending with '(' in video/
Message-ID: <641e22f97f91b_325e1f29438@iweiny-mobl.notmuch>
References: <ZBytWDocM7XbXkRx@khadija-virtual-machine>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <ZBytWDocM7XbXkRx@khadija-virtual-machine>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?40rYWuL7ZvcT5omywPR11EztsXlNZV72cs9/mdAmP2LkolcWO1jtPIr5Hx0V?=
 =?us-ascii?Q?hg0F4zCHSU64kq7wreT7ypm8QAIT4Q6ssnn6+qZ+VcVS5YHdPYvvaKFIHfr9?=
 =?us-ascii?Q?795uckNTFSaD6GuWpSxFtP+BAkL+oOfslhCe63oRgbIlpgNyg3AGJ2UAZkr9?=
 =?us-ascii?Q?0/U+yyKw5H0/U4YugMB126gZ+s0nBub/IT3HUv8ef+PGYM+UDI0kAeuDoLoB?=
 =?us-ascii?Q?OwX3x7gVxo8vUJonDlegoVypATptMoYqvdmNZXYQgzGvzXaMQU6rCgi8rDyK?=
 =?us-ascii?Q?LK6hl2aoXC9cfWtOGkcASbLgzf/iXptGBfrQIzrFMX0ByfLUqZ40uN1+DBQn?=
 =?us-ascii?Q?w0R0l1ndTBIqaeQ7nC1S39dU0p/DWb+GZOevh68Ns7TGdvhoPe0BojdZDRa/?=
 =?us-ascii?Q?D5e86JKIOznZIcNLOrA+kT6hWjsqzwaMRaIKqpqaYpGURMHSjYDaUEy0ZAZo?=
 =?us-ascii?Q?tMcGeFcbgB8/Vs8a1vNLZzqcRzf1LkAEaM2NlV7SWBFebttq/J3WtRTFS1DS?=
 =?us-ascii?Q?9vgTyZne0EEFm7t1gCv3f6/xkcsvCwTABODVBdNC+/ObuowcuWDvImDBN1EF?=
 =?us-ascii?Q?4GUmsL27rnpl/e+EG3hCBz+HnWXDXihqHSW4MClZmpoT/jEv1KSgdPYSyC0b?=
 =?us-ascii?Q?3xPBCutcoFpezj5jr4daEN6yABLB8mkaa5BiWX3iTS+BWhqsalZX4EPBviEl?=
 =?us-ascii?Q?O0y8TiNBAnXpWfUhjh245mC2EX8RnkrPJXJhuEDdwSZHbHCQ5vYOTPYjKD7n?=
 =?us-ascii?Q?KVPWTls9q18wloyvSFeeVPVIDlLdJSy1lHoLMkhvaZaJiE4bPylpdhJ5ewFI?=
 =?us-ascii?Q?ffdzdkh0YJV6es6eoivdc6A72NBywk7LFI9gi98+MQ4qjC9cPhyV3VIxaMj5?=
 =?us-ascii?Q?Nx/NJTRojiXNx8giLEvUSU1sner/Fsj0OlEw7sfgtOHlBAht6TSO5M1pNJBm?=
 =?us-ascii?Q?m8M1hJgYQvJni47/25Da0gCFS+cP524I+/glzYaTv9uBdK4sZ9ld+6ZOKQrI?=
 =?us-ascii?Q?lUq7I3HSPec3iQmvbj7GD8FnW3/h9xYnrQoCXvRNVz8AOspBKUphz5xIW3Lo?=
 =?us-ascii?Q?2hWU1Vl1dOX9oI3K3SHoay9gM7tuJTu5zl37BV05WZb0qG56dwaNi+54qwWL?=
 =?us-ascii?Q?tO21Lj6xfKDHwkhA4a8eS12iTwrzMBFQaphU3aG1Y6GrvJsJFzpWN4cfHAKc?=
 =?us-ascii?Q?HjKRwLZRFXIkmXlqsk1wmamhMIDXy91yfjZd3n4D33ZqkyBnOWOv32ACVGHI?=
 =?us-ascii?Q?nr69YzBeMyaw5Jp2oSudIYxfQNhQ4DsUNshZ+2AlRMiYCIpXkwbPp/4Ej/SX?=
 =?us-ascii?Q?3oJmj+czs9bL9zbAWrlHYmrsKBd50hEWzJrUBAk5kvMQj4ucVWs6ddjMf6vx?=
 =?us-ascii?Q?xjNhzT3cuq6U0HZ3XWDj21PD0rvY1YLApkwlSm+EnCI4ITPJNU1+3m94s2z6?=
 =?us-ascii?Q?Z4w4/20ZWBHoSUnh94t4Ctd3y1dIjnlVz/+Cx5OJBaXmOJUBXObdp9HUUnto?=
 =?us-ascii?Q?41/N0FKlbAaSEtvARjzWKciBW1ktP/de6hTXnD8soSjzx4QHuZzSdkmVDG+Z?=
 =?us-ascii?Q?cFMwljOO0/BgmLqmhABoY9jQ2kTgMR8ygW6GX9tI?=
X-MS-Exchange-CrossTenant-Network-Message-Id: b1f411cf-692e-4f24-c3e3-08db2cb67543
X-MS-Exchange-CrossTenant-AuthSource: SA1PR11MB6733.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Mar 2023 22:23:56.8290
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: frjyVG6ItFzjBa3C614sCP1Kkg77CrWvX0Gt4sv5HQ2rgq7j7p4q3fCgh0latcgJZYJ/V4ZrgFJcbX74ltSjLw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR11MB7390
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-2.5 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE
        autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Khadija Kamran wrote:
> Splitting function header to multiple lines because of 80 characters per
> line limit, results in ending the function call line with '('.
> This leads to CHECK reported by checkpatch.pl
> 
> Move the function parameters right after the '(' in the function call
> line.
> 
> Signed-off-by: Khadija Kamran <kamrankhadijadj@gmail.com>
> ---
> 
> Changes in v2:
>  - Changed the subject name because there was another patch for most/
>    with the same name. This was causing confusion.
> 
>  drivers/staging/most/video/video.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/most/video/video.c b/drivers/staging/most/video/video.c
> index ffa97ef21ea5..6254a5df2502 100644
> --- a/drivers/staging/most/video/video.c
> +++ b/drivers/staging/most/video/video.c
> @@ -365,8 +365,7 @@ static const struct video_device comp_videodev_template = {
>  
>  /**************************************************************************/
>  
> -static struct most_video_dev *get_comp_dev(
> -	struct most_interface *iface, int channel_idx)
> +static struct most_video_dev *get_comp_dev(struct most_interface *iface, int channel_idx)

Same comment as the previous version I saw.

Ira

>  {
>  	struct most_video_dev *mdev;
>  	unsigned long flags;
> -- 
> 2.34.1
> 
>