Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 24 Mar 2023 15:24:27 -0700
From:   Ira Weiny <ira.weiny@intel.com>
To:     Khadija Kamran <kamrankhadijadj@gmail.com>,
        <outreachy@lists.linux.dev>
CC:     Parthiban Veerasooran <parthiban.veerasooran@microchip.com>,
        "Christian Gromm" <christian.gromm@microchip.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        <linux-staging@lists.linux.dev>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3] staging: most: fix line ending with '(' in dim2/
Message-ID: <641e231b9862e_325e1f294e3@iweiny-mobl.notmuch>
References: <ZByu29jb1mE3KOsn@khadija-virtual-machine>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <ZByu29jb1mE3KOsn@khadija-virtual-machine>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?+L4UlgZZSfo4vJtSBWgQp6dgahzXnX9Rt0zINrZTKPNFWe2sdZKYO3/TkHYx?=
 =?us-ascii?Q?9dti9jdmrJ8N9995FlLMSVzInFN32IdR0iuQyxS3/Fu7jB5MZXX84ZfG0v2J?=
 =?us-ascii?Q?md4GbKCe6Szbvdf8ZcmhOsTNlrMI9aGvvsn4O5aesEdjnLzBE6MpDVhDIIG/?=
 =?us-ascii?Q?/2BdWaIFEjOeJNfzSw7TYcfNj2gAA1fBG3lZyxT7fDq/R7xFGWcZN+F9IAx3?=
 =?us-ascii?Q?+yYdF7yAGHo3YyT6cDtzGExI0hA0S0azWR/KxL/FmOOGX/5WFG9BGaIJCmBj?=
 =?us-ascii?Q?IK/TkGyEATquILcIHrytkun4r527/i6RrQZVYQpRnLw2gWDmv8Nre5N3oxn7?=
 =?us-ascii?Q?QvbiD3Y1kH/yLXNFDFVCDA/w4vumZB5WBo/pC6rZ359JaUjrFblxfl7JAa4E?=
 =?us-ascii?Q?TMi2XY+i7GA6B+ztv7BxcwnUxEr5NDl2fPcu2+aPbK/iCSzpFeCCWDizlwZw?=
 =?us-ascii?Q?r96DMctt/nYYY26TUYEsbVbpMNHE7rFaZySw5HGcrxHDyaP9cDTmc2MY8UY3?=
 =?us-ascii?Q?WGtvur/kjjpGIzS6KNoimbbmYugP+YTUkhxucI/eALBph3cgyjKtvIfIGTwR?=
 =?us-ascii?Q?Z6wZpPT8cMzckKMTgoUKa5+rprGYXlShkEStoOBP/O1y5FGpgICiQJ6AIeDu?=
 =?us-ascii?Q?zYhglhboc8icvo0Z78+EG7uc0P7FkSWgDjBTLz34tRvnsyoCRpMHf888XCqP?=
 =?us-ascii?Q?ilyZT/m/zs/5JwEAo5MbjW/6W0cKc6ne0gkiREvqzhXql6nmb7epahE+9iav?=
 =?us-ascii?Q?SnzqydsDdC4NKwWKdt6YrUP8awjog8X6kdLlGTZr0k82Vf6TXRQ5cBC07k6t?=
 =?us-ascii?Q?1zvfG22ri7lHCZjlD1R7Sg/xNeA0nuuVHiYrOG6JR5NucYN24bFNreZgRT0g?=
 =?us-ascii?Q?J5fCZjnTf1HqqCY8VQBhmrGvKMAy2fXZ3l6alHHKNe+20L2BIrMHFHXoZTIz?=
 =?us-ascii?Q?z2q4ESj2PdWMUzHiZGZvEqCq/XD+hqIsTxsV8FI+tlmXn/MLcecrJAiJ5KMx?=
 =?us-ascii?Q?vu9aKnMTrafF/nNkgqtqH8ixJt6Uib4zmGSWLpJfewtaW2uxHcAZHP42y7dr?=
 =?us-ascii?Q?HIdy3WewznmA78KGrIEdS37pV6D/BVffbMFTdzQgutSHTs76XI3wXUwWmYT5?=
 =?us-ascii?Q?QCDf+teS5Z9oI58s5G/8LKqSwt2MV+PPVYAV/VoQkz3IEb5Bfl/GfEhDPElA?=
 =?us-ascii?Q?4sJIjtzkWh0ck6C37+SvMkLuPd5fl9C037PIXttadJW/TM2UrcqNr5ZJdbGE?=
 =?us-ascii?Q?RgnTQrQNqF+h2trSQoeM8ymIFb96klQSbrak7hx9J6C7wme7+6OdgncqIiYp?=
 =?us-ascii?Q?jp47XPC228JxkWzAooBhO/oIKdM165lnyVPErWQ4aF/7ZGaK/EOSgQQWmGic?=
 =?us-ascii?Q?FOF5I5QS89fGIg9Fdwp6Rf77HKOk4Wy976jHWQsPPKBUSzCn0Az/WVPkELRG?=
 =?us-ascii?Q?swNu9RBqFt0YoQDMMzeGlQi93viWnTT/3sLMRA4suAl0TkaIpGjQgnP5fF/H?=
 =?us-ascii?Q?TZK3dAYc2SuJspBrIqUHh8oK49oNsEc6HpeHGgjXJKhqg5tNkwzd1ROhUzTM?=
 =?us-ascii?Q?nMMRwjnGN+ynVm7ZcqvWx2oBRPJneS44xQxAR/Tb?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 5d44f753-5afd-433d-8a22-08db2cb6898a
X-MS-Exchange-CrossTenant-AuthSource: SA1PR11MB6733.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Mar 2023 22:24:30.8316
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: S2afp0qdsYPYfZaPHTv9PnEZwBXTlRYzVKD8X0e5mls3IjKcet/GV4E8rfAie2XWD89mdYREyPU0ezdtxQbDBQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA0PR11MB4767
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-2.5 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE
        autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Khadija Kamran wrote:
> Splitting function header to multiple lines because of 80 characters per
> line limit, results in ending the function call line with '('.
> This leads to CHECK reported by checkpatch.pl
> 
> Move the function parameters right after the '(' in the function call
> line. Align the rest of the parameters to the opening parenthesis.
> 
> Signed-off-by: Khadija Kamran <kamrankhadijadj@gmail.com>
> ---
> 
> Changes in v3:
>  - Changed the subject because another patch for 'most/' with the same
>    name was causing confusion.
> 
> Changes in v2:
>  - Changed the description
> 
>  drivers/staging/most/dim2/hal.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/staging/most/dim2/hal.c b/drivers/staging/most/dim2/hal.c
> index a5d40b5b138a..6abe3ab2b2cf 100644
> --- a/drivers/staging/most/dim2/hal.c
> +++ b/drivers/staging/most/dim2/hal.c
> @@ -346,9 +346,8 @@ static void dim2_clear_ctram(void)
>  		dim2_clear_ctr(ctr_addr);
>  }
>  
> -static void dim2_configure_channel(
> -	u8 ch_addr, u8 type, u8 is_tx, u16 dbr_address, u16 hw_buffer_size,
> -	u16 packet_length)
> +static void dim2_configure_channel(u8 ch_addr, u8 type, u8 is_tx, u16 dbr_address,
> +				   u16 hw_buffer_size, u16 packet_length)

Same comment as the previous version I saw.

Ira

>  {
>  	dim2_configure_cdt(ch_addr, dbr_address, hw_buffer_size, packet_length);
>  	dim2_configure_cat(MLB_CAT, ch_addr, type, is_tx ? 1 : 0);
> -- 
> 2.34.1
> 
>