Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Sat, 25 Mar 2023 15:38:04 +0800
From:   Xu Yilun <yilun.xu@intel.com>
To:     Tom Rix <trix@redhat.com>
Cc:     Michal Simek <michal.simek@amd.com>, linux-kernel@vger.kernel.org,
        monstr@monstr.eu, michal.simek@xilinx.com, git@xilinx.com,
        Moritz Fischer <mdf@kernel.org>, Wu Hao <hao.wu@intel.com>,
        linux-arm-kernel@lists.infradead.org, linux-fpga@vger.kernel.org
Subject: Re: [PATCH] fpga: xilinx-pr-decoupler: Use readl wrapper instead of
 pure readl
Message-ID: <ZB6k3B64h4r1WQQZ@yilunxu-OptiPlex-7050>
References: <0381e4e8061c2fee182a104768e84feff3a82d25.1679412800.git.michal.simek@amd.com>
 <18e45db9-0b7d-abc3-5564-93968819f877@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <18e45db9-0b7d-abc3-5564-93968819f877@redhat.com>
Precedence: bulk

On 2023-03-21 at 10:10:14 -0700, Tom Rix wrote:
> 
> On 3/21/23 8:33 AM, Michal Simek wrote:
> > Driver has IO wrappers but xlnx_pr_decouple_read() is not used and readl is
> > used instead which is just wrong.
> > It is also generating sparse issue that xlnx_pr_decouple_read() is unused.
> > 
> > Signed-off-by: Michal Simek <michal.simek@amd.com>
> > ---
> > 
> > Created based on discussion with Tom here
> > https://lore.kernel.org/r/20230317230617.1673923-1-trix@redhat.com
> > ---
> >   drivers/fpga/xilinx-pr-decoupler.c | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/fpga/xilinx-pr-decoupler.c b/drivers/fpga/xilinx-pr-decoupler.c
> > index 2d9c491f7be9..b76d85449b8f 100644
> > --- a/drivers/fpga/xilinx-pr-decoupler.c
> > +++ b/drivers/fpga/xilinx-pr-decoupler.c
> > @@ -69,7 +69,7 @@ static int xlnx_pr_decoupler_enable_show(struct fpga_bridge *bridge)
> >   	if (err)
> >   		return err;
> > -	status = readl(priv->io_base);
> > +	status = xlnx_pr_decouple_read(priv, CTRL_OFFSET);
> 
> Thanks for the change.
> 
> Reviewed-by: Tom Rix <trix@redhat.com>

Acked-by: Xu Yilun <yilun.xu@intel.com>

Applied.

> 
> >   	clk_disable(priv->clk);
>