Received: by 2002:a05:6358:11c7:b0:104:8066:f915 with SMTP id i7csp232917rwl; Sat, 25 Mar 2023 01:04:58 -0700 (PDT) X-Google-Smtp-Source: AKy350a5W2lUzdQ+U6cjJsVxUe0GvWnqWXX93xFCtv2vv00ixIgYszGpmIN1eQZdmqnOIN13jlsm X-Received: by 2002:aa7:c54f:0:b0:4fa:4bc4:a911 with SMTP id s15-20020aa7c54f000000b004fa4bc4a911mr6028572edr.13.1679731497965; Sat, 25 Mar 2023 01:04:57 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1679731497; cv=none; d=google.com; s=arc-20160816; b=W+6MqMExXvw/849H0XJvKsKLjllhSozF8TP1AiZ/2537IiN+Yar0hzQc30x5hNzKho Ip/P9qGbcqsQ8iMy6gHLwLQ1bZyWPcH5wfvR8Av0gETC/S7eulsmBOHpwa/Q6+JiTViJ 8N/INKHVic1YKurscp9KNODuj5Aynau3uv9hwSub2Yn523UP585U9tVatmxsEJ6Wwk2y jJciXcN594ER7CkyidO+QwDd+M/cds+22spnr4Tu/f8w29YzwIroALJVrRobvUR5dDc9 qynwzKYydQLdGOVg3wkAQ7GqPi5dDTRq9kq3alXuYu7oSLGiCOT4XJrg6tSfMgBelVKu ujnw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:sender:hmm_source_type :hmm_attache_num:hmm_source_ip; bh=NWCh3vByxHKtodM2hZozCVExADtS5B5qvJm1GswpL/I=; b=Miw1GZiPIx47oqv9HUXsfL5wl7bttKxN6JF6YihxgqxFDkkVp8f8FZcHp4A5WMoZ7I /ZCt/TsWwgM3UAl2DkEuvbn6SKm5qTK23ddvwYAY0fHvNa/t3N5vqzqOj7CeNOsh9JIn fyvAcqE3+hYBR774u2GfT6sfCppMbs2wGHGZ26IFLpDNpLOke71zQtCdAQJ2stdRQhut 2+MkBQ9OYw6fdTUYzILLlCK7mYudLh9JTV9xkzNu8NibVe5lBO/Qn7ehkGmhNRCdLBFo 04GkTfCOx0P32owPqx+SPlK6Jryh1FK/f7WJQOdunpbMFXAp4Oo/hWdR4l6pwvoDBhbI RDcA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id z7-20020aa7c647000000b004fb4fc2e5f4si8531778edr.314.2023.03.25.01.04.29; Sat, 25 Mar 2023 01:04:57 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231513AbjCYHqn (ORCPT + 99 others); Sat, 25 Mar 2023 03:46:43 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38966 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229699AbjCYHqm (ORCPT ); Sat, 25 Mar 2023 03:46:42 -0400 Received: from 189.cn (ptr.189.cn [183.61.185.102]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 4B0221353B for ; Sat, 25 Mar 2023 00:46:40 -0700 (PDT) HMM_SOURCE_IP: 10.64.8.43:33334.1902543559 HMM_ATTACHE_NUM: 0000 HMM_SOURCE_TYPE: SMTP Received: from clientip-114.242.206.180 (unknown [10.64.8.43]) by 189.cn (HERMES) with SMTP id BAD471001EF; Sat, 25 Mar 2023 15:46:36 +0800 (CST) Received: from ([114.242.206.180]) by gateway-151646-dep-7b48884fd-tj646 with ESMTP id 5e01f141a15042c193eaa3c38bd182e1 for maarten.lankhorst@linux.intel.com; Sat, 25 Mar 2023 15:46:38 CST X-Transaction-ID: 5e01f141a15042c193eaa3c38bd182e1 X-Real-From: 15330273260@189.cn X-Receive-IP: 114.242.206.180 X-MEDUSA-Status: 0 Sender: 15330273260@189.cn From: Sui Jingfeng <15330273260@189.cn> To: Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Daniel Vetter , suijingfeng , liyi Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: [PATCH] drm/fbdev-generic: optimize out a redundant assignment clause Date: Sat, 25 Mar 2023 15:46:36 +0800 Message-Id: <20230325074636.136833-1-15330273260@189.cn> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=0.6 required=5.0 tests=FREEMAIL_ENVFROM_END_DIGIT, FREEMAIL_FROM,FROM_LOCAL_DIGITS,FROM_LOCAL_HEX,RCVD_IN_MSPIKE_H2, SPF_HELO_PASS,SPF_PASS autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The assignment already done in drm_client_buffer_vmap(), just trival clean, no functional change. Signed-off-by: Sui Jingfeng <15330273260@189.cn> --- drivers/gpu/drm/drm_fbdev_generic.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/drm_fbdev_generic.c b/drivers/gpu/drm/drm_fbdev_generic.c index 4d6325e91565..1da48e71c7f1 100644 --- a/drivers/gpu/drm/drm_fbdev_generic.c +++ b/drivers/gpu/drm/drm_fbdev_generic.c @@ -282,7 +282,7 @@ static int drm_fbdev_damage_blit(struct drm_fb_helper *fb_helper, struct drm_clip_rect *clip) { struct drm_client_buffer *buffer = fb_helper->buffer; - struct iosys_map map, dst; + struct iosys_map map; int ret; /* @@ -302,8 +302,7 @@ static int drm_fbdev_damage_blit(struct drm_fb_helper *fb_helper, if (ret) goto out; - dst = map; - drm_fbdev_damage_blit_real(fb_helper, clip, &dst); + drm_fbdev_damage_blit_real(fb_helper, clip, &map); drm_client_buffer_vunmap(buffer); -- 2.25.1