Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <42bbac46-782b-e2ac-67f3-37489e3a2047@kernel.org>
Date:   Sat, 25 Mar 2023 15:03:06 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.8.0
Subject: Re: [PATCH 1/2] arm64: dts: ti: k3-am625-sk: Add ti,vbus-divider
 property to usbss1
To:     Nishanth Menon <nm@ti.com>
Cc:     vigneshr@ti.com, kristo@kernel.org, srk@ti.com,
        r-gunasekaran@ti.com, linux-usb@vger.kernel.org,
        linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
        Dhruva Gole <d-gole@ti.com>
References: <20230324133150.43224-1-rogerq@kernel.org>
 <20230324133150.43224-2-rogerq@kernel.org>
 <20230324181435.i2n2q6cvh6x4kabw@repeal>
Content-Language: en-US
From:   Roger Quadros <rogerq@kernel.org>
In-Reply-To: <20230324181435.i2n2q6cvh6x4kabw@repeal>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 24/03/2023 20:14, Nishanth Menon wrote:
> On 15:31-20230324, Roger Quadros wrote:
>> From: Dhruva Gole <d-gole@ti.com>
>>
>> The property "ti,vbus-divider" is needed for both usbss0 and usbss1 as
>> both USB0 and USB1 have the same external voltage divider circuit.
>>
>> Signed-off-by: Dhruva Gole <d-gole@ti.com>
>> Signed-off-by: Roger Quadros <rogerq@kernel.org>
>> ---
>>  arch/arm64/boot/dts/ti/k3-am625-sk.dts | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/arch/arm64/boot/dts/ti/k3-am625-sk.dts b/arch/arm64/boot/dts/ti/k3-am625-sk.dts
>> index 67dc26fc23e4..be027fad5f61 100644
>> --- a/arch/arm64/boot/dts/ti/k3-am625-sk.dts
>> +++ b/arch/arm64/boot/dts/ti/k3-am625-sk.dts
>> @@ -482,6 +482,7 @@ &usbss0 {
>>  
>>  &usbss1 {
>>  	status = "okay";
>> +	ti,vbus-divider;
>>  };
>>  
> 
> 1. Does'nt this need a fixes tag?
> 2. lakml is missing in CC

Will fix both issues.

> 
>>  &usb0 {
>> -- 
>> 2.34.1
>>
> 

cheers,
-roger