Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Sat, 25 Mar 2023 16:58:49 +0100
From:   Simon Horman <simon.horman@corigine.com>
To:     Tom Rix <trix@redhat.com>
Cc:     aspriel@gmail.com, franky.lin@broadcom.com,
        hante.meuleman@broadcom.com, kvalo@kernel.org, davem@davemloft.net,
        edumazet@google.com, kuba@kernel.org, pabeni@redhat.com,
        nathan@kernel.org, ndesaulniers@google.com,
        johannes.berg@intel.com, quic_srirrama@quicinc.com,
        alexander@wetzel-home.de, shaul.triebitz@intel.com,
        linux-wireless@vger.kernel.org,
        brcm80211-dev-list.pdl@broadcom.com,
        SHA-cyfmac-dev-list@infineon.com, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org, llvm@lists.linux.dev
Subject: Re: [PATCH] wifi: mac80211: remove unused has_5g variable
Message-ID: <ZB8aOahMb4PQoGQK@corigine.com>
References: <20230325130343.1334209-1-trix@redhat.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230325130343.1334209-1-trix@redhat.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?q2CLgUT4dlrZzKSN4zStrcedvIwxwYjb8IYHBaLpwBQOaTlzmDKAK/4sD3MJ?=
 =?us-ascii?Q?aupH7v66XxTHfuLd1OAuOplZeDzg1/dbGhy0E1e+cYYcv3YKPa3lHzd0r3yl?=
 =?us-ascii?Q?DavZN367Q00WMg7lgZwge6GxG6+3CAfCc7hL+8YdcZjeXqoLvXuGNSFkoMg8?=
 =?us-ascii?Q?1NCkqdcSA6w7MkNJvXiA/TXk6s2ev9Ed50x96+i8Jt/jh+52fI3UdRcCHzDw?=
 =?us-ascii?Q?fVoJwEeDQvDUZRvmmAO0zPT+UIK7MskjRrvtL/ndDy3+7D6Gr/4EDVl8WM84?=
 =?us-ascii?Q?h22KQFBHaGYSnOQ6i6INI1U4iXAse0RXwY516dDs0MXzpIkgdV5fIb94ClxI?=
 =?us-ascii?Q?g2cea+ziqriaEHX0Nh8cQGX/FHyuBuE7+uCbMLaA7nHaDIBJJXhAS2wZbi7K?=
 =?us-ascii?Q?8p4C2nAkJg5Rm7auEiYPTZEd+JAtgS8EFzO3F+0a0ex90BUFw2E+rk+CU/Py?=
 =?us-ascii?Q?R/usz3aCOnkuQhKH5jyraNVH00q3jZBN+3NKfzI90qCRIWnT/Hyt7WukRgU3?=
 =?us-ascii?Q?EzPrYsn0qMeF0j9NzQlK8jv+X2jFCZ+L9J7D9oH0WF7WkTNEA02KdPxox98e?=
 =?us-ascii?Q?PI3Hm9xk7+aL+10IIY1Ndv9RxqG4XayzlguRoAaRJb59ePWDE/54X5H632B3?=
 =?us-ascii?Q?ZqHhauViXvQjxC5fD2cpPII7nvg1+It6Tz0dswMEAWraF5I73JIeGQb4+3jh?=
 =?us-ascii?Q?IksU3PJOM/DFESVRB2hdQ1nDo5frfmmA8n0xfeq3loaeFHNbqDfsw+EACEQu?=
 =?us-ascii?Q?t0++G1MZ6mR8Ccbu6vfJYGwjbjm6WwKQ8rTmCV5ydA41KkIUIO+48SWHR10e?=
 =?us-ascii?Q?Vppzjv3u3Bssb+2Yjt4x6ZHI4lZhIwa8/ut0Zzv+4ok8E2o1nzzYfHeB4CUa?=
 =?us-ascii?Q?MXfNmDN3P+fnFF7HfhRcYIWT7w5l0IPdNVoeZnWBE/ACkEDil9U2L3kpzeg8?=
 =?us-ascii?Q?KtI/lBgQaeIAB2Jl4o9Nyi0/eVwoz92saJE0F+fiad4W9JZpLROFbbWddcOY?=
 =?us-ascii?Q?tn6LT4L5zCcqoEH2YTGBCxcsMnT4QNX7WePsfZnlDvWMH8E/kHoAYPH9Q9La?=
 =?us-ascii?Q?bV4yXdBIqeOfRyJgQHm1OmR+irNgt4J0AAfJbvRTi4LglLtUs9qyVDeFlfYg?=
 =?us-ascii?Q?L+hY6O0+3y3EH74DCM9sTWTe5Zyf9E6wFWUwvRPn8eIe/p4BejvMbCw0IZmm?=
 =?us-ascii?Q?1e1EpSv8YlIOui3mt7pyCFVCBQAWzrSVBxxe5mbrXdvBu8PYMraJw/RBq5+r?=
 =?us-ascii?Q?v2eNqKXPIuBZlJQHl61G7I4wnKZtvOFTA1XcYN/pjQ5dG6+anji6Q4pQUrD6?=
 =?us-ascii?Q?FmRHK4/WWOHeuVk6QfFH6vkRju8VJ+BnWiNauuFluUlTJTK2boYO3C1ULbcd?=
 =?us-ascii?Q?zbM81KEjshIo+tqnT+dkWt5QIgdxU2H7Q1RrCfkhIxakz4ijG/t/gQrxTTRZ?=
 =?us-ascii?Q?FFIGvebBV/2SNGXfq0iA9IWor3Wmpg9OpQMnAR+hOFMb9A1D0PhMBqb4U84O?=
 =?us-ascii?Q?e9LjKAd5DQ/9nRP3qZgJIhTHQ02gE9UPTW8dWKWMJAmevoRe8xzaT9toonbM?=
 =?us-ascii?Q?XpZG+uc8qo2pw+07CPfBhu3EhRDt+ZrBqXMZ0JDg9vWB6CA1aPPmdsAs+6bN?=
 =?us-ascii?Q?XzdQ2t0YIelaVN9kKid2MpQh23ObflWQkmDXuB3DT3O2EqnV1x8pcK7tzJcV?=
 =?us-ascii?Q?HiQRHw=3D=3D?=
X-OriginatorOrg: corigine.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 1a20e63d-aa00-4c38-e55d-08db2d49d883
X-MS-Exchange-CrossTenant-AuthSource: PH0PR13MB4842.namprd13.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Mar 2023 15:58:59.4254
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: kMNIb0f0kXw88K+amuM0gYgMY/7RYURzgpaSiGOiGwXqYeSa41nheLMS6/EnAaXkRHyxqA+1/k9ZtESsgIJCcKUgWp8qDUPUo40KZMvXr0g=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR13MB4621
X-Spam-Status: No, score=-0.0 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS
        autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Sat, Mar 25, 2023 at 09:03:43AM -0400, Tom Rix wrote:
> clang with W=1 reports
> drivers/net/wireless/broadcom/brcm80211/brcmsmac/mac80211_if.c:1051:6: error:
>   variable 'has_5g' set but not used [-Werror,-Wunused-but-set-variable]
>         int has_5g = 0;
>             ^
> This variable is not used so remove it.
> 
> Signed-off-by: Tom Rix <trix@redhat.com>

Reviewed-by: Simon Horman <simon.horman@corigine.com>