Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Sat, 25 Mar 2023 17:09:46 +0100
From:   Pavel Machek <pavel@ucw.cz>
To:     Joseph Strauss <jstrauss@mailbox.org>
Cc:     lee@kernel.org, jansimon.moeller@gmx.de, conor@kernel.org,
        christophe.jaillet@wanadoo.fr, linux-leds@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] Add multicolor support to BlinkM LED driver
Message-ID: <20230325160946.GC1820@bug>
References: <20221228010958.9670-1-jstrauss@mailbox.org>
 <ZBw5E4ecNvfgd0RB@duo.ucw.cz>
 <20230325155355.gxnjpyl3mnyq2lst@libretux>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230325155355.gxnjpyl3mnyq2lst@libretux>
User-Agent: Mutt/1.5.23 (2014-03-12)
Precedence: bulk

On Sat 2023-03-25 10:53:55, Joseph Strauss wrote:
> On 23/03/23 12:33PM, Pavel Machek wrote:
> > Hi!
> > 
> > > In the blinkm_probe function, the multicolor LED class is registered
> > > after the regular LED classes. The blinkm_set_mc_brightness() function
> > > had to be added to calculate the three color components and then set the
> > > fields of the blinkm_data structure accordingly.
> > 
> > It needs to be either single multicolor LED or three separate
> > LEDs. But not both at the same time.
> > 
> 
> Thank you for the feedback! How would you suggest I go about handling
> this? Is there a preferred way to ask the user which way they want to
> control the LED (Kconfig?), or should I remove the code for three
> separate LEDs entirely? Originally, I didn't delete the code because I
> thought it would be bad to remove the existing interface.

It kind of is bad. ... but hopefully blinkm users can adjust.

You could do Kconfig if it was easy.

BR,
									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html