Received: by 2002:a05:6358:11c7:b0:104:8066:f915 with SMTP id i7csp704843rwl; Sat, 25 Mar 2023 09:25:53 -0700 (PDT) X-Google-Smtp-Source: AK7set+xQPtcGNrFGj1WI/8c+xeYviiocholGT7t8y6bCDDHmxJ95iq9OTNkzNddfw77AFkbeAO3 X-Received: by 2002:a05:6a20:bf18:b0:dc:43e8:54b7 with SMTP id gc24-20020a056a20bf1800b000dc43e854b7mr5635429pzb.43.1679761553064; Sat, 25 Mar 2023 09:25:53 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1679761553; cv=none; d=google.com; s=arc-20160816; b=hWdDFfSsJ4gqMKzR/4csNjR/yfMmzXBf2UvZfoX+BPxDjtZ4lJ728MoITokQdvmEc1 NJgOgK7GTXe+gkB8GHZWj3euuRLh/tJRZXMdTU0u4i1kxNRDrYcvEhLR0vqapS3IjhMi hJcg1fQ0iUrmzmj6WaP8TrcwovdZ3hnBBDpF+aoCaD3ISuViG6JQQ7jN5l84TuAFCjOD tVSJSG6mha+AGj03SAWxWul0hrIkYbJk9ggU7+cmkIlLWFlhLsf3swzuJVlo5v1lOIjF pbqWMxfj99YxS1rahJW1+13WkukYuL8qETWiWUaYvX4QML9Sg2rY8q0tSO2xllvG/w0h jDXA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=lOc/aCbyyLCUUZYp9RCYBzV8oifezBMIUmCcCgYuPLA=; b=A0QEFJ0Z5dDcRnC9/wqpuc2qVpmiftccgE/VoWIRWqsnTMEP2ZICzPO0lBm6nuHkYF w7YsPW8Us5+EqqFEaie/PJ4phNopqC9buOMFWbQ3mf77HrE6UcxU4uUFuef9iWqh/BpE R4HBS8ZeErigT3QYC0/Wwop72U0ZogbnGRaIc2mfHEYf7yrQy+srwqYTbr8wAkoSahvE OYs56HaXfJlZU+pJ6+v1rvMNNrg3DnroNSg2PTj3jjhGk3jUeD4TUZTWaXVv2JSem3po YzLFz/y1MTeqtOvo7F4h6O7RSfhum9IcrkbkJs6xE2yKYKifN2Jld6Wi4UMsyloGCPPO 0s7Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=LL4+uqFV; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id o2-20020a655202000000b0050f76fb84adsi15823477pgp.575.2023.03.25.09.25.41; Sat, 25 Mar 2023 09:25:53 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=LL4+uqFV; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231808AbjCYQUP (ORCPT + 99 others); Sat, 25 Mar 2023 12:20:15 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39634 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231561AbjCYQUO (ORCPT ); Sat, 25 Mar 2023 12:20:14 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8353EF97F; Sat, 25 Mar 2023 09:20:13 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id E307E60C82; Sat, 25 Mar 2023 16:20:12 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id BA234C433EF; Sat, 25 Mar 2023 16:20:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1679761212; bh=RgI9q5WzQBkRWeNGghQLt89IvUaWcS8RWnyJkhSvJi4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=LL4+uqFV4y7Qqie7uM1+j08QWkZCzZye5kNta06r3PzK/adhocna4hPcbdNfuGfGj //Wss/eotWxBgVN5M18iRCjemSQLOuB437D0+101miMlzB3jVgwOIIHdU3//YDHuKv Re/GmLEP2qaxnDFjybDC+a1gxPqydrWJDCv8U0Jk= Date: Sat, 25 Mar 2023 17:20:09 +0100 From: Greg Kroah-Hartman To: Ye Xiang Cc: Arnd Bergmann , Matthias Kaehlcke , Lee Jones , Wolfram Sang , Tyrone Ting , Mark Brown , Linus Walleij , Bartosz Golaszewski , linux-usb@vger.kernel.org, linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org, linux-gpio@vger.kernel.org, srinivas.pandruvada@intel.com, heikki.krogerus@linux.intel.com, andriy.shevchenko@linux.intel.com, sakari.ailus@linux.intel.com, zhifeng.wang@intel.com, wentong.wu@intel.com, lixu.zhang@intel.com Subject: Re: [PATCH v7 1/6] usb: Add support for Intel LJCA device Message-ID: References: <20230325154711.2419569-1-xiang.ye@intel.com> <20230325154711.2419569-2-xiang.ye@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230325154711.2419569-2-xiang.ye@intel.com> X-Spam-Status: No, score=-5.2 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI,SPF_HELO_NONE, SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Mar 25, 2023 at 11:47:06PM +0800, Ye Xiang wrote: > This patch implements the USB part of Intel USB-I2C/GPIO/SPI adapter > device named "La Jolla Cove Adapter" (LJCA). > > The communication between the various LJCA module drivers and the > hardware will be muxed/demuxed by this driver. Three modules ( > I2C, GPIO, and SPI) are supported currently. > > Each sub-module of LJCA device is identified by type field within > the LJCA message header. > > The minimum code in ASL that covers this board is As this requires ACPI, why are you not saying so in your Kconfig entry? What good would this driver be without ACPI enabled? thanks, greg k-h