Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Sat, 25 Mar 2023 18:33:34 +0100
From:   Pavel Machek <pavel@ucw.cz>
To:     Fenglin Wu <quic_fenglinw@quicinc.com>
Cc:     linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org,
        lee@kernel.org, krzysztof.kozlowski@linaro.org,
        linux-leds@vger.kernel.org, quic_collinsd@quicinc.com,
        quic_subbaram@quicinc.com, Luca Weiss <luca.weiss@fairphone.com>
Subject: Re: [PATCH v8 1/2] leds: flash: add driver to support flash LED
 module in QCOM PMICs
Message-ID: <ZB8wbv93+Vmx3trt@duo.ucw.cz>
References: <20230303095023.538917-1-quic_fenglinw@quicinc.com>
 <20230303095023.538917-2-quic_fenglinw@quicinc.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
        protocol="application/pgp-signature"; boundary="SNocmiwjTKO0+lmp"
Content-Disposition: inline
In-Reply-To: <20230303095023.538917-2-quic_fenglinw@quicinc.com>
Precedence: bulk


--SNocmiwjTKO0+lmp
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hi!

> Add initial driver to support flash LED module found in Qualcomm
> Technologies, Inc. PMICs. The flash module can have 3 or 4 channels
> and each channel can be controlled indepedently and support full scale
> current up to 1.5 A. It also supports connecting two channels together
> to supply one LED component with full scale current up to 2 A. In that
> case, the current will be split on each channel symmetrically and the
> channels will be enabled and disabled at the same time.


> +static int qcom_flash_strobe_set(struct led_classdev_flash *fled_cdev, b=
ool state)
> +{
> +	struct qcom_flash_led *led =3D flcdev_to_qcom_fled(fled_cdev);
> +	int rc;
> +
> +	rc =3D set_flash_current(led, led->flash_current_ma, FLASH_MODE);
> +	if (rc)
> +		return rc;
> +
> +	rc =3D set_flash_timeout(led, led->flash_timeout_ms);
> +	if (rc)
> +		return rc;
> +
> +	rc =3D set_flash_module_en(led, state);
> +	if (rc)
> +		return rc;
> +
> +	return set_flash_strobe(led, SW_STROBE, state);
> +}

Should we disable the module before setting the current? It might be
already active due to torch mode...


> +		return -EINVAL;
> +	}
> +
> +	flash_data->v4l2_flash =3D devm_kcalloc(dev, count,
> +			sizeof(*flash_data->v4l2_flash), GFP_KERNEL);
> +	if (!flash_data->v4l2_flash)
> +		return -ENOMEM;
> +
> +	device_for_each_child_node(dev, child) {
> +		led =3D devm_kzalloc(dev, sizeof(*led), GFP_KERNEL);
> +		if (!led) {
> +			rc =3D -ENOMEM;
> +			goto release;
> +		}
> +
> +		led->flash_data =3D flash_data;
> +		rc =3D qcom_flash_register_led_device(dev, child, led);
> +		if (rc < 0)
> +			goto release;
> +
> +		flash_data->leds_count++;
> +	}

Do you need to do of_node_put in error paths?

BR,
							Pavel
--=20
People of Russia, stop Putin before his war on Ukraine escalates.

--SNocmiwjTKO0+lmp
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iF0EABECAB0WIQRPfPO7r0eAhk010v0w5/Bqldv68gUCZB8wbgAKCRAw5/Bqldv6
8tBgAJ9UbKwCsuWIQ0IHnZPvZFTRfnPQ1ACgs8lE0snt0pnVCsxH55R3wMfwOrE=
=umcN
-----END PGP SIGNATURE-----

--SNocmiwjTKO0+lmp--