Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Sat, 25 Mar 2023 18:12:23 +0000
From:   Mark Brown <broonie@kernel.org>
To:     Dylan Van Assche <me@dylanvanassche.be>
Cc:     Banajit Goswami <bgoswami@quicinc.com>,
        Jaroslav Kysela <perex@perex.cz>,
        Takashi Iwai <tiwai@suse.com>,
        Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
        Liam Girdwood <lgirdwood@gmail.com>,
        alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org,
        ~postmarketos/upstreaming@lists.sr.ht, phone-devel@vger.kernel.org,
        Joel Selvaraj <joelselvaraj.oss@gmail.com>,
        Caleb Connolly <caleb@connolly.tech>
Subject: Re: [PATCH v3 1/1] sound: soc: codecs: wcd-mbhc-v2: expose ALSA
 control for jack
Message-ID: <ZB85h55to1MsQnnh@sirena.org.uk>
References: <20230325142142.24337-1-me@dylanvanassche.be>
 <20230325142142.24337-2-me@dylanvanassche.be>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="BY1KhK6s61gDAstw"
Content-Disposition: inline
In-Reply-To: <20230325142142.24337-2-me@dylanvanassche.be>
Precedence: bulk


--BY1KhK6s61gDAstw
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Sat, Mar 25, 2023 at 03:21:42PM +0100, Dylan Van Assche wrote:

> =20
>  	mutex_lock(&mbhc->lock);
> =20
> +	ret =3D snd_jack_add_new_kctl(mbhc->jack->jack, "Headset Jack", WCD_MBH=
C_JACK_MASK);
> +	if (ret)
> +		dev_warn(component->dev, "failed creating Headset Jack kctl with err: =
%d\n", ret);
> +

No, drivers should not be open coding userspace reporting - there
is no reason for this device to be special, or for this device to
duplicate what machine drivers and the core are doing.  Any
configuration should be done by the machine driver, the ASoC core
jack handling already creates userspace controls when asked.

--BY1KhK6s61gDAstw
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmQfOYYACgkQJNaLcl1U
h9D8yAf/fy9sMmjyaQSaCVRAtU6vPerFG2ZHD4sxzKPFhQb/dYDzG1AIAN+Dcp6p
TNKiM3DeqpzAV9GsThFTdllqXMAu79UOYhkPiPhjqUIH7gCli6TD0nhE7FerQWs0
MNYJFlZb9ZanjrSLm9QX0nraG9B/2mFgfK5ug7nH2WpNnuTm+5jwztOISRpAhOmm
/dWq7YTfT9CZdJkruUFsq0OgvDHnR294QQbzziUeRVX69msTC9h7BQVFk09Unvf7
wIP0p7qOLGuMjanJ/SyKU51V1Z078t7TrQhrPDzIW95oXgJeDAdmsqkeIfZDoAMm
mRLRKpwn0bVRbSCjisW24bgr/1tajQ==
=yrsm
-----END PGP SIGNATURE-----

--BY1KhK6s61gDAstw--