Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Sat, 25 Mar 2023 18:05:09 +0000
From:   Mark Brown <broonie@kernel.org>
To:     "Ye, Xiang" <xiang.ye@intel.com>
Cc:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Arnd Bergmann <arnd@arndb.de>,
        Matthias Kaehlcke <mka@chromium.org>,
        Lee Jones <lee@kernel.org>, Wolfram Sang <wsa@kernel.org>,
        Tyrone Ting <kfting@nuvoton.com>,
        Linus Walleij <linus.walleij@linaro.org>,
        Bartosz Golaszewski <brgl@bgdev.pl>, linux-usb@vger.kernel.org,
        linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-spi@vger.kernel.org, linux-gpio@vger.kernel.org,
        srinivas.pandruvada@intel.com, heikki.krogerus@linux.intel.com,
        andriy.shevchenko@linux.intel.com, sakari.ailus@linux.intel.com,
        zhifeng.wang@intel.com, wentong.wu@intel.com, lixu.zhang@intel.com
Subject: Re: [PATCH v7 1/6] usb: Add support for Intel LJCA device
Message-ID: <ZB831a6F4A7qufqs@sirena.org.uk>
References: <20230325154711.2419569-1-xiang.ye@intel.com>
 <20230325154711.2419569-2-xiang.ye@intel.com>
 <ZB8fOTpD/uuexaV1@kroah.com>
 <ZB8u3wWTQhg4PvQe@ye-NUC7i7DNHE>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="I1JUvLiN+7x9W5nz"
Content-Disposition: inline
In-Reply-To: <ZB8u3wWTQhg4PvQe@ye-NUC7i7DNHE>
Precedence: bulk


--I1JUvLiN+7x9W5nz
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Sun, Mar 26, 2023 at 01:26:55AM +0800, Ye, Xiang wrote:
> On Sat, Mar 25, 2023 at 05:20:09PM +0100, Greg Kroah-Hartman wrote:

> > As this requires ACPI, why are you not saying so in your Kconfig entry?

> I would add a `depends on ACPI` item on the Kconfig entry so that the
> CONFI_ACPI macro can be removed from usb-ljca, because our use case with

> LJCA currently needs the ACPI binding.

> > What good would this driver be without ACPI enabled?
> Before, I just tried to make it compatible with other platforms that
> don't support ACPI but want to use LJCA device. But, We don't have
> this use case until now.

If it builds without ACPI then making the dependency ACPI ||
COMPILE_TEST will help improve build coverage for people doing
treewide or subsystem work.

--I1JUvLiN+7x9W5nz
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmQfN9QACgkQJNaLcl1U
h9Czwwf6ArYM8v1lofvQGzA3fN/lMF0ReqYQ8ak9S50cX4SEtxJf6V6NRY1edhF2
s7B8J/EBXct79tSjmEwAns4JjXlmRHl6ol+k0uRwTV45xjQKnrFgl/Jo/qz54jHS
NICX0Z5a2X/ivC8hZFKHYhEGfd1WwH1TJK1VmJLXoWwaXYyAem2sOXDZjAVIX5v+
oxk7Mt+CuqvIHR+UvazsQrL6y8FPEYHZg4VYQa9vI/PIiPEEotBGVluOgJLdCPWh
0pRr2+qDRA72Qfi7ftOBjVh5v56xLGazodEVjkcF6GrzNVGoJkyb9KokSIcB2yJp
Jkp5hspCPznPJXsgr7TMFH70wkCYQg==
=Nq0E
-----END PGP SIGNATURE-----

--I1JUvLiN+7x9W5nz--