Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Sat, 25 Mar 2023 21:16:22 +0100
From:   Pavel Machek <pavel@ucw.cz>
To:     Rodrigo Siqueira <Rodrigo.Siqueira@amd.com>
Cc:     airlied@gmail.com, daniel@ffwll.ch, amd-gfx@lists.freedesktop.org,
        Anthony Koo <anthony.koo@amd.com>,
        Iswara Negulendran <iswara.nagulendran@amd.com>,
        Felipe Clark <felipe.clark@amd.com>,
        Harry Wentland <Harry.Wentland@amd.com>,
        dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drm/display: Add missing OLED Vesa brightnesses
 definitions
Message-ID: <ZB9Wltd9jiI7ktse@duo.ucw.cz>
References: <20230322160513.1438881-1-Rodrigo.Siqueira@amd.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
        protocol="application/pgp-signature"; boundary="vZOsuThjzQLN1+xx"
Content-Disposition: inline
In-Reply-To: <20230322160513.1438881-1-Rodrigo.Siqueira@amd.com>
Precedence: bulk


--vZOsuThjzQLN1+xx
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Wed 2023-03-22 10:05:13, Rodrigo Siqueira wrote:
> Cc: Anthony Koo <anthony.koo@amd.com>
> Cc: Iswara Negulendran <iswara.nagulendran@amd.com>
> Cc: Felipe Clark <felipe.clark@amd.com>
> Cc: Harry Wentland <Harry.Wentland@amd.com>
> Signed-off-by: Rodrigo Siqueira <Rodrigo.Siqueira@amd.com>

Some changelog would be useful.


> +++ b/include/drm/display/drm_dp.h
> @@ -977,6 +977,8 @@
>  # define DP_EDP_BACKLIGHT_FREQ_AUX_SET_CAP		(1 << 5)
>  # define DP_EDP_DYNAMIC_BACKLIGHT_CAP			(1 << 6)
>  # define DP_EDP_VBLANK_BACKLIGHT_UPDATE_CAP		(1 << 7)
> +#define DP_EDP_OLED_VESA_BRIGHTNESS_ON      0x80
> +# define DP_EDP_OLED_VESA_CAP				(1 << 4)
> =20

Are you fixing a compile problem? Otherwise this should go in with the
user...

BR,
							Pavel
--=20
People of Russia, stop Putin before his war on Ukraine escalates.

--vZOsuThjzQLN1+xx
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iF0EABECAB0WIQRPfPO7r0eAhk010v0w5/Bqldv68gUCZB9WlgAKCRAw5/Bqldv6
8hNeAJ9Z6iHpiX7M02eWAO5DogqxZDen0gCffJw9G0L8fNgcM6poGr+ycBvtTFw=
=pb8n
-----END PGP SIGNATURE-----

--vZOsuThjzQLN1+xx--