Received: by 2002:a05:6358:11c7:b0:104:8066:f915 with SMTP id i7csp1008933rwl; Sat, 25 Mar 2023 15:50:34 -0700 (PDT) X-Google-Smtp-Source: AKy350Yx47l1ghsbSx+81E1SGsw/IyqGS7A+Nr1n7EWhAaTBG46gY2bjA4xIZWNtRZ1v+5r+v6fy X-Received: by 2002:a17:90a:b397:b0:23f:7ff6:eba with SMTP id e23-20020a17090ab39700b0023f7ff60ebamr7844798pjr.0.1679784633760; Sat, 25 Mar 2023 15:50:33 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1679784633; cv=none; d=google.com; s=arc-20160816; b=Yx1UctFo0Jybdx6oFaQZ72ZqaiHYHqTxr/h1Ype/RDpSq+a4rjmDotVxvPB9kbwK4h f2U3XMGAXxJnToNT9GYHVEADdzDnWTu/y7hMBipu9QgEJ4x++Wym4X6rkehbu1vR1g8x sxeYlye7Wb4/Pa8d/XcltMtQK3R7q6zUGTOgo479ZhuxO4DuRpywPlBYbAJ6TSCVwEX3 lMc1XAwuXkazIPpTLYrRk2WmVexpsXmlQK8VOHogMLSwKlkxAC3iPn2gOtkiApQNKQuG N9HxO6VnbsS8QiKT4LgeWW4zBKtg+XDmHVktlhTyuOR28boIdIBhbxqywwp4NrmSD6lW xUEw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=TqqLr0HdfLVy+kabXjW3SaE/44BpMzhkuGlj04Y0hIc=; b=ReZ2mS4C4zZvIlwuAZG4DwaIL3ZLOSDIZfmglHnTCQUX7U3H4MTPBV1VH6kFbjUbaf PBYnl9ooFGLe13tIGs7gsadBtnN/iCqr0U7KdGzAhmUZ4WmFe2EwxyUMCnKTM4953skg l6r7tRZ2TTDMnUSzV4uu440jbitZOo6G1QKqGmXLynhdVpEik/ROlVrLsY3zvf05oBE+ lKpimWsjK4APpDq1haOrBCBuk8q+DV16G9tpRxfxqdabDzdiYPH50G6T6LAJou6jLYFA PnR4QCyKzNsVz9aE/IgQfbrwP9wuaYEmXcN/VgTM9ZAtXQXc5MMZ7srQE8cKWgkhdh8j 36pQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=U+6nM9g0; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id 204-20020a6307d5000000b005133c334fe6si2227152pgh.805.2023.03.25.15.50.20; Sat, 25 Mar 2023 15:50:33 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=U+6nM9g0; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231370AbjCYW1L (ORCPT + 99 others); Sat, 25 Mar 2023 18:27:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42112 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229460AbjCYW1K (ORCPT ); Sat, 25 Mar 2023 18:27:10 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3F79E7ECF; Sat, 25 Mar 2023 15:27:08 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 7452560DB9; Sat, 25 Mar 2023 22:27:07 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 42DA0C433D2; Sat, 25 Mar 2023 22:27:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1679783226; bh=Q1bKTClEuBaOpbRZAO3AJ33e5TyraS8c50q00hE8OrM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=U+6nM9g0zg7W2kYLAN9MJ/gl+50xPyW1wq7KwPEk1OaOcaEUCfzrIEhb15Sy1taM/ i5fnBonLNHyFVCgWHCvsLTFbKy2pp24iQVny7NtTIuhxEsL/WCQaVkKQl0oCln4g4U ewnEBpMoZW1VqyW9QPvp1ZtY8kTvH9zt2XIVkync= Date: Sat, 25 Mar 2023 23:27:03 +0100 From: Greg Kroah-Hartman To: Ye Xiang Cc: Arnd Bergmann , Matthias Kaehlcke , Lee Jones , Wolfram Sang , Tyrone Ting , Mark Brown , Linus Walleij , Bartosz Golaszewski , linux-usb@vger.kernel.org, linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org, linux-gpio@vger.kernel.org, srinivas.pandruvada@intel.com, heikki.krogerus@linux.intel.com, andriy.shevchenko@linux.intel.com, sakari.ailus@linux.intel.com, zhifeng.wang@intel.com, wentong.wu@intel.com, lixu.zhang@intel.com Subject: Re: [PATCH v7 1/6] usb: Add support for Intel LJCA device Message-ID: References: <20230325154711.2419569-1-xiang.ye@intel.com> <20230325154711.2419569-2-xiang.ye@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230325154711.2419569-2-xiang.ye@intel.com> X-Spam-Status: No, score=-2.5 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Mar 25, 2023 at 11:47:06PM +0800, Ye Xiang wrote: > +static void ljca_aux_release(struct device *dev) {} Sorry, but creating an empty release function just to shut the kernel up is NOT how to properly do this, you all know better. This is totally broken. The kernel was telling you what you had to do, don't think that you are being smarter than it by doing this, otherwise we would have never had the kernel spit out that error in the first place, right? Now I will ask you to follow the proper Intel kernel review rules and get proper approval for the patchset before submitting it to us again, as basic things like this are not supposed to be caught by us, but by your internal review process first. good luck! greg k-h