Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Sun, 26 Mar 2023 17:04:59 +0800
From:   "Ye, Xiang" <xiang.ye@intel.com>
To:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>
CC:     Arnd Bergmann <arnd@arndb.de>,
        Matthias Kaehlcke <mka@chromium.org>,
        "Lee Jones" <lee@kernel.org>, Wolfram Sang <wsa@kernel.org>,
        Tyrone Ting <kfting@nuvoton.com>,
        Mark Brown <broonie@kernel.org>,
        Linus Walleij <linus.walleij@linaro.org>,
        Bartosz Golaszewski <brgl@bgdev.pl>,
        <linux-usb@vger.kernel.org>, <linux-i2c@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>, <linux-spi@vger.kernel.org>,
        <linux-gpio@vger.kernel.org>, <srinivas.pandruvada@intel.com>,
        <heikki.krogerus@linux.intel.com>,
        <andriy.shevchenko@linux.intel.com>,
        <sakari.ailus@linux.intel.com>, <zhifeng.wang@intel.com>,
        <wentong.wu@intel.com>, <lixu.zhang@intel.com>
Subject: Re: [PATCH v7 1/6] usb: Add support for Intel LJCA device
Message-ID: <ZCAKuyNHpp9EJff8@ye-NUC7i7DNHE>
References: <20230325154711.2419569-1-xiang.ye@intel.com>
 <20230325154711.2419569-2-xiang.ye@intel.com>
 <ZB91Nz52TEd34IST@kroah.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <ZB91Nz52TEd34IST@kroah.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?NPMmLxkU0ccqVtMW/b1zeW8w/FhZ1M3jmaalBb2abdvSlppR+Yod4UAVlW9H?=
 =?us-ascii?Q?eaigChME6jqZi8q6L9FE0AfVgIY9k04PgOjL1wSfJKtg/4ekciGy4cmlIKGE?=
 =?us-ascii?Q?vl4anPdjQyundhMIy9+j5y9lsSombyAm71nxT/pud7D7wT0ZnFuMb7K6p8yY?=
 =?us-ascii?Q?C0qRIqdLV93EN3M6asEpg+tOGrMfU/JeqGHuVMTU9/IVKfhQtDdmfMPvC9kp?=
 =?us-ascii?Q?t4+V+oPmqu4E6cMyaxcQy4H8++6YdHpvk9rJRq7gY4EXRohtfwrBZBJv2xWI?=
 =?us-ascii?Q?o4IL+tQqqlIzK6qg3JzjqMF3REwuqcJ4kbhTlLMOqKSllutEqULntsHl9uZT?=
 =?us-ascii?Q?+Rq0vB1qO4TCvGiBh9Yv43bwYkC8b2tWDDFLoMbSQx+nmHWcvfVRYHLpV+kX?=
 =?us-ascii?Q?vZx+7db9Fd82ef8RqO6rUmWikxhccLSWsIlZptlzZ6ksZlx6oc3h+0i8ptjk?=
 =?us-ascii?Q?eY09z3eJ8jOc/Z8D2GvIdtqvmdqeOQJZBPx4DOnh5Zv2wbcnp4i3XlxlXsj1?=
 =?us-ascii?Q?RZ1Gy0fyPezA4ZbSVWNiJGYS3Lw2QzgIJCZkUo5552ygucVC3xN36R0K/Tvm?=
 =?us-ascii?Q?HuNJDsAT2surcG7sXw98FMiIpUmA5gAyDP6Bi39UpQeDzjejXA6k9CwUfW1y?=
 =?us-ascii?Q?LXS6Yhk+oJRJCWYlOQdN9q00+yZDjJ7bgcr+kJcu6aEa6TzZLlKY2NlvUnkg?=
 =?us-ascii?Q?b4uPc1tuA8Ba8WDI4s9iYLJRWsxOf0JWclZIFkY3DcBePmQymneuWxNrjWug?=
 =?us-ascii?Q?egkOT6ECWXDsP1I6BUK4hTmsQy26i34snG616p6x11tBiZa6eIqYfOnncUvZ?=
 =?us-ascii?Q?O1O6OP45k6ADMzn41ZEI3MK0wob2YiULdFvP/VyJp09qq76WC7HAfvxkd5XV?=
 =?us-ascii?Q?UB3q/m/E+eSEi1fHDPssvjo0KDj149PEfFv09qNmPOwFh/zlH6TsEjehc+tz?=
 =?us-ascii?Q?Zs8WH5DPhpNX85bV1bMwMbElGWmGYStYle+633wVpgH18XJvSUAHJmexlz5+?=
 =?us-ascii?Q?Kuh5r9AI8IJ2SvDFQ76HJyNmxs2uffX5M2+Er6nPvYAbMq5C5+cWk+ZDfCHC?=
 =?us-ascii?Q?Uw+nSAD4tPeh1KbeaIA1ZMlNlFgOLRfo1EfEC9faEwkUQuNvWkieeVzGxA9J?=
 =?us-ascii?Q?zlPdDCVfmEfojFU3EPeneCqvMTitErpJn7B2UIN5y4wK+WEfAfFNQ+fW9Qwk?=
 =?us-ascii?Q?+fgWGkYxMlwbVFqkjYYJRPUCh9VcufoYtX/lHOZ/VMn9jEEYanzxE3+RbZZj?=
 =?us-ascii?Q?k0Lw9cg3kkYGIzWWPclGOJHsejo5GMC0usmUjM3jYlw5Jv3OToHDMnJeW7bg?=
 =?us-ascii?Q?ST6GmBpqc3iIV21WbuEqSCdO2dTPG8TfekY/kvymcVeRYNZiEZdZHo7UcnoS?=
 =?us-ascii?Q?aq9Mu8/QIRHhGDFWzdMM2BlC1vnEz2TLMMKq/mTr14yCEt/3vIJvyVLfilIL?=
 =?us-ascii?Q?UDkIL5J1dHBFzzi1fJFCOuaNDWIMpnkXW9esRpcWOG8UWYlBCpSMnz0YtZCT?=
 =?us-ascii?Q?4j2iX2HG70JgEsasJKaz3m97egGd0kB3Q0XMpSuCyUx1wER/4XHxuBoFNS1L?=
 =?us-ascii?Q?65IvzEA8bjm9V0R1y+2ZXd3fdoT/AvmuliOb1B4Z?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 77b4fd87-63cb-436d-0a90-08db2dd92ece
X-MS-Exchange-CrossTenant-AuthSource: DM5PR11MB1418.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Mar 2023 09:05:02.1965
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: rkDZiJX2Q5sFZNLOcGHq3+co3g/+rEAolAzml5ssS/rFc9ufOOzWtxJ1Y0sD5ZRE9VE/ZA1Nv9gVZbXOlULlng==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR11MB5970
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-2.5 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_PASS,
        SPF_NONE autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Sat, Mar 25, 2023 at 11:27:03PM +0100, Greg Kroah-Hartman wrote:
> On Sat, Mar 25, 2023 at 11:47:06PM +0800, Ye Xiang wrote:
> > +static void ljca_aux_release(struct device *dev) {}
> 
> Sorry, but creating an empty release function just to shut the kernel up
> is NOT how to properly do this, you all know better.  This is totally
> broken.  The kernel was telling you what you had to do, don't think that
> you are being smarter than it by doing this, otherwise we would have
> never had the kernel spit out that error in the first place, right?
Got it. Will use the release callback to free memory used by the auxiliary
device instead.
> 
> Now I will ask you to follow the proper Intel kernel review rules and
> get proper approval for the patchset before submitting it to us again,
> as basic things like this are not supposed to be caught by us, but by
> your internal review process first.
Thanks. I will get approval on Intel's internal review first before sending
the next version out for review.

--
Thanks
Ye Xiang