Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Sun, 26 Mar 2023 14:46:52 +0200
From:   Nam Cao <namcaov@gmail.com>
To:     Tom Rix <trix@redhat.com>
Cc:     gregkh@linuxfoundation.org, nathan@kernel.org,
        ndesaulniers@google.com, artur.bujdoso@gmail.com,
        linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
        llvm@lists.linux.dev
Subject: Re: [PATCH] staging: rtl8723bs: remove unused pHalData variable
Message-ID: <ZCA+vIjUFHZFUFPC@nam-dell>
References: <20230326122321.1352337-1-trix@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230326122321.1352337-1-trix@redhat.com>
Precedence: bulk

On Sun, Mar 26, 2023 at 08:23:21AM -0400, Tom Rix wrote:
> clang with W=1 reports
> drivers/staging/rtl8723bs/hal/hal_btcoex.c:1182:23: error: variable
>   'pHalData' set but not used [-Werror,-Wunused-but-set-variable]
>         struct hal_com_data *pHalData;
>                              ^
> This variable is not used so remove it.
> 
> Signed-off-by: Tom Rix <trix@redhat.com>
> ---
>  drivers/staging/rtl8723bs/hal/hal_btcoex.c | 4 ----
>  1 file changed, 4 deletions(-)
> 
> diff --git a/drivers/staging/rtl8723bs/hal/hal_btcoex.c b/drivers/staging/rtl8723bs/hal/hal_btcoex.c
> index e36f8c369a04..0cb2adcc1f78 100644
> --- a/drivers/staging/rtl8723bs/hal/hal_btcoex.c
> +++ b/drivers/staging/rtl8723bs/hal/hal_btcoex.c
> @@ -1179,10 +1179,6 @@ bool hal_btcoex_IsBtDisabled(struct adapter *padapter)
>  
>  void hal_btcoex_SetChipType(struct adapter *padapter, u8 chipType)
>  {
> -	struct hal_com_data *pHalData;
> -
> -
> -	pHalData = GET_HAL_DATA(padapter);
>  }

If this function doesn't do anything, does it not make more sense to
just remove this function entirely?

Best regards,
Nam