Received: by 2002:a05:6358:11c7:b0:104:8066:f915 with SMTP id i7csp1656849rwl; Sun, 26 Mar 2023 06:53:42 -0700 (PDT) X-Google-Smtp-Source: AKy350Ydp5GOosvlmC0FMjSVO8Yh4hYAVER2bjGz93GkOLlxu0dvwjfSq0kFZDHzOozfCOzep5w+ X-Received: by 2002:a17:90b:3807:b0:240:1d2b:1363 with SMTP id mq7-20020a17090b380700b002401d2b1363mr9973783pjb.34.1679838822589; Sun, 26 Mar 2023 06:53:42 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1679838822; cv=none; d=google.com; s=arc-20160816; b=q5ZsocpC3Lf+i5Vi1i7h8STW922HIHjag0pbeub8tcLmJyvSifaO5rrIvfni/1nIwQ 5xh5cuzFPlUrmfNzOL2HN5Ii3aoKOFtYetQu4IUycF+O7LvUt1K2Qywn8R0/iTouQ4Bb zqiAQgbI3sk+FYkC1f28Qn+pkzveMnPhehXcu2E8Vs9cZkrNAANJoX7KyASBBZ8qU1Nj +pW0iBI6trF5jpVCjxuoahxAUun5rugwv5kSLwhI3u1pxspozZllGMBDLNovvKLTtM2x l6cVSLbL44LEpqShS1vPuFdJCyk0Mn0X7sW1ZJJWYj8timPlTP1/qH4Z0gHmDOssdXgS fT5A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:dkim-signature; bh=C/PLvzD8RSWpsnRBqcXlxbiX4+dIwDLvRo2aNxelbg0=; b=FfhmJr9WEdT1mvNq3WbUp4sIiX/r4vQf+3rzF8w8OjK7Noai5+OQsn/85rjnaSSVsE SmF495fNJsUoDOdu/0J5gmvDZIeAGzjAnz7FV/0xXrbddiZDrv4//EXkjqUxUlWrZLD1 tLnUZrFEc7I0cLhPSKMujIm+GdLaLbHvo9BvKUikLYhTsKSKS/tmccLgtumJffZPNwUv hIMhquqnk5pauGF5Z/EngikJlh1WNEEZNfylbFa5q5jkGQdJgo7w3xcq6fxnAg0MkIBE DBuvyT3olTXMvtx0lydQHhf1qrM3N90d8oSlPfKUkhD3pFtBMaJNwy0UlyrenYK76GJa gtlw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=GzYRuNnq; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id y23-20020a63de57000000b0051339e73e3asi3617220pgi.314.2023.03.26.06.53.31; Sun, 26 Mar 2023 06:53:42 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=GzYRuNnq; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231915AbjCZNtw (ORCPT + 99 others); Sun, 26 Mar 2023 09:49:52 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49378 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230399AbjCZNtu (ORCPT ); Sun, 26 Mar 2023 09:49:50 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1CD6C76A3 for ; Sun, 26 Mar 2023 06:49:49 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id D28E4B80315 for ; Sun, 26 Mar 2023 13:49:47 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8DE25C433EF; Sun, 26 Mar 2023 13:49:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1679838586; bh=6fOgTWzVrss+rb+Gr+qQbntTVt0XT8KX+kHdAaZ3HtA=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=GzYRuNnqfoW++B4B/A0ZPhpUmdgvLw5ZhY0SbxrabINuECe6frEtW96QLgDaiUzyg Ocq/5SIw7PUrv/wdsWvkpjzisy4OXh7JUCecBDV0etbW87rGWA+YAEhJ2NoqWBCU3S 7m/LDuyXbInDb7HZXAp40QksPSz+1peE2UCSRWE7k4Kqn1uPqabuUF0wFSDzrQLCrg r4un2ChuAZl4l9e2+iFQipLONsU2sMr6yzpGoMYFIUKIZhXGxqPBRElHN5XGS4aZYk v75TlMqD6ir+Y7m+PaX+WslflEcknBYfwIQm0bj8E5SYHU3SO2Ui7bQXw7qptkkP0S 38ML2h2UtttnA== Message-ID: <7cb351fa-1f93-6acc-a64d-1107d7e9f032@kernel.org> Date: Sun, 26 Mar 2023 21:49:44 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH] f2fs: remove else in f2fs_write_cache_pages() Content-Language: en-US To: Yangtao Li , Jaegeuk Kim Cc: linux-f2fs-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org References: <20230320173137.64413-1-frank.li@vivo.com> From: Chao Yu In-Reply-To: <20230320173137.64413-1-frank.li@vivo.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-2.5 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2023/3/21 1:31, Yangtao Li wrote: > As Christoph Hellwig point out: > > Please avoid the else by doing the goto in the branch. > > Signed-off-by: Yangtao Li Reviewed-by: Chao Yu Thanks,