Received: by 2002:a05:6358:11c7:b0:104:8066:f915 with SMTP id i7csp1967672rwl; Sun, 26 Mar 2023 12:52:06 -0700 (PDT) X-Google-Smtp-Source: AKy350bG6Y9+yp+98Yrmj/perQkNTsQSVtJ50Ot14CbR4UX1gA0+EjFxyIBr9vLdnQ7mh60nFA0B X-Received: by 2002:a17:902:d501:b0:19c:a9b8:58eb with SMTP id b1-20020a170902d50100b0019ca9b858ebmr11790169plg.12.1679860325916; Sun, 26 Mar 2023 12:52:05 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1679860325; cv=none; d=google.com; s=arc-20160816; b=kmhKRzAXusBD2b39RameWjRf61t7vGNzuSq1Pg0umGubxSTP/wxsZQ1nYnEG2Ymygq aFAyHjmfx5DG1CgItrk2yxaKxXZWEu8T+vIwR7H9sACgSpzQ6t3a1T2T54vu7E4NZFtV uheFhBxkwq7pAjTZnwkeBJhR8oUaPeqnbpCmcYAvJ/snm5zBAvSw+r6x5ZfffqpNgGEU TqtkAXViTL2/QnyJ0eXgEzSKKwqa8ds32Ce6LxcNHSGofPNbUCj72XCd3U+o5YwNduVF rQSDeUs/+BzBwSTA1veS8PNkdMSe8X78lF9kuhRMeCBQLHYkH7TH2+vjhqw9pig+1LkS v/TA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-transfer-encoding :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=GidJKYIOLmvfz4aB/GwhhYhvXHg30d4L87WaccShj0g=; b=zE5/nr8vC6li+74LyLxiWlvPtrHp8wgSvPK6z9TnJSuyO/g6iLcPcpAKvWWJYza4YZ mniKWRKTRnjuJ3k9mrYUMzvPjNd0DwVci6mOlXS1djq4sLAk9FHlMCz2mG4SOi2mFRei xWpeaePHMEsEL/JDuxC0lyGoYdqTWLBWFWXPSTcKRv/Cap/fhJgI+tu5mRWeHfdGdpv6 XgYFO8FkIyZwzsb8JaUnqxmNs8j8g5YrbrtD8OQmo8zv9vU3qvWYIWZUy+E+NwWeqBth GmLsD45qwcDEFIOEdTbAm6kYAIyVHXY3oknoyxuxJQD+g+mZJ0HB2H3Bgv6nevNhD9ws s9Tg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=UhEGBET9; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id 63-20020a630042000000b0050fa329e784si14865991pga.280.2023.03.26.12.51.54; Sun, 26 Mar 2023 12:52:05 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=UhEGBET9; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229592AbjCZTeo (ORCPT + 99 others); Sun, 26 Mar 2023 15:34:44 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35086 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229458AbjCZTen (ORCPT ); Sun, 26 Mar 2023 15:34:43 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A306449E6; Sun, 26 Mar 2023 12:34:40 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 2AC0760ECB; Sun, 26 Mar 2023 19:34:40 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id AA8E5C433D2; Sun, 26 Mar 2023 19:34:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1679859279; bh=GidJKYIOLmvfz4aB/GwhhYhvXHg30d4L87WaccShj0g=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=UhEGBET99VkJodmP+8qQRBHYJ0gnbGFiAzKvHIWfXt4zsogzzY+CFizrzU44Ih6+n rT5fuQwYM+89Ms9v5uCcL0di/veqyw7LbSM4WRvWVC1mjcqSR/ntmexyIdQVI7MFSN WQIziWdI5nva5bPTQcS96T5K0RlvSEQbYmJ2ioVXupEtubh9zREDYcFlCHzznU3dwX 39pKh1V+3UPt5dNvbP20tGgcRQokJ+AIJCnjFwnD4dvqyDd7fd3u4nPEykfvpINsnd 6lBAK/0GDLy/dGMw2arzCt6KW4nyiDfgjmx8z5BDeHZZzJN44Akd1Rj8bB1cLPJ2mb uHUXh68B6VnaQ== Date: Sun, 26 Mar 2023 21:34:35 +0200 From: Frederic Weisbecker To: "Joel Fernandes (Google)" Cc: linux-kernel@vger.kernel.org, Greg Kroah-Hartman , "Rafael J. Wysocki" , Frederic Weisbecker , Thomas Gleixner , Ingo Molnar , "Paul E. McKenney" , Josh Triplett , Zhouyi Zhou , Will Deacon , Marc Zyngier , rcu , stable@vger.kernel.org Subject: Re: [PATCH v2 04/13] tick/nohz: Fix cpu_is_hotpluggable() by checking with nohz subsystem Message-ID: References: <20230325173316.3118674-1-joel@joelfernandes.org> <20230325173316.3118674-5-joel@joelfernandes.org> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20230325173316.3118674-5-joel@joelfernandes.org> X-Spam-Status: No, score=-2.5 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Le Sat, Mar 25, 2023 at 05:33:07PM +0000, Joel Fernandes (Google) a ?crit : > For CONFIG_NO_HZ_FULL systems, the tick_do_timer_cpu cannot be offlined. > However, cpu_is_hotpluggable() still returns true for those CPUs. This causes > torture tests that do offlining to end up trying to offline this CPU causing > test failures. Such failure happens on all architectures. It might be worth noting that hotplug failure is fine on hotplug testing. The issue here is the repetitive error message in the logs. Other than that: Acked-by: Frederic Weisbecker