Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Sun, 26 Mar 2023 17:13:18 -0400
From:   William Breathitt Gray <william.gray@linaro.org>
To:     Jonathan Cameron <jic23@kernel.org>
Cc:     Lars-Peter Clausen <lars@metafoo.de>, linux-iio@vger.kernel.org,
        linux-kernel@vger.kernel.org,
        Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Subject: Re: [PATCH v2] iio: addac: stx104: Migrate to the regmap API
Message-ID: <ZCC1bhdHymSBMQOX@fedora>
References: <20230324030916.396569-1-william.gray@linaro.org>
 <20230326164920.1e4575f9@jic23-huawei>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="1hFa8m5aSKcaoSMl"
Content-Disposition: inline
In-Reply-To: <20230326164920.1e4575f9@jic23-huawei>
Precedence: bulk


--1hFa8m5aSKcaoSMl
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Sun, Mar 26, 2023 at 04:49:20PM +0100, Jonathan Cameron wrote:
> On Thu, 23 Mar 2023 23:09:16 -0400
> William Breathitt Gray <william.gray@linaro.org> wrote:
>=20
> > The regmap API supports IO port accessors so we can take advantage of
> > regmap abstractions rather than handling access to the device registers
> > directly in the driver.
> >=20
> > Suggested-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> > Signed-off-by: William Breathitt Gray <william.gray@linaro.org>
>=20
> I would have preferred slightly if you had avoided reording the probe
> (previously gpio chip was registered before iio device and now it is afte=
r)
> but it make no real difference so I'm not that bothered.
>=20
> A few other minor comments. Biggest one being that the defines should be
> prefixed.
>=20
> Thanks,
>=20
> Jonathan

Hi Jonathan,

I'll be submitting a v3 soon addressing your comments as well as some
minor fixes to v2; I'll make the regmap_read_poll_timeout() change as a
follow-up patch as suggested.

Regarding the GPIO code reordering in the probe, I decided to move it
after the iio device registration so that all the IIO-related code is
grouped together and finished before we deal with GPIO-related stuff.
Given that all the original gpio chip code is removed anyway in this
patch, I figure this is a minor enough cleanup to perform here. If you
aren't too strongly opposed to this change I'll keep it in v3 as it
avoids the hassle of creating a separate patch for such a trivial
change.

William Breathitt Gray

--1hFa8m5aSKcaoSMl
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEARYKAB0WIQSNN83d4NIlKPjon7a1SFbKvhIjKwUCZCC1bgAKCRC1SFbKvhIj
K3gKAP4im9weEqAgUf5gXPQ5DqmrLHtP+vf1hUdjwMTWuLxulwD+Nxc7CxSgYBky
olZG9H8YrFmtmtgBft7xrYp1AoTWWQw=
=8rwi
-----END PGP SIGNATURE-----

--1hFa8m5aSKcaoSMl--