Received: by 2002:a05:6358:11c7:b0:104:8066:f915 with SMTP id i7csp2061700rwl; Sun, 26 Mar 2023 15:06:26 -0700 (PDT) X-Google-Smtp-Source: AKy350ZvjJl9bA8Gc2l1EvmJBexJpCdI1m9FmfCH6Mwu0Q1Hym12U+Z/q9KKDXHaxTun/7oP91k/ X-Received: by 2002:a17:903:2948:b0:19c:f232:21ca with SMTP id li8-20020a170903294800b0019cf23221camr8970172plb.3.1679868386435; Sun, 26 Mar 2023 15:06:26 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1679868386; cv=none; d=google.com; s=arc-20160816; b=RHzcugGRV/kXjAsimcm5QNPn5u9/dcZaEoH+24LLFMgtH8RyF8/UXGvOA4JNlYFCXz rRjPjTsaiCWcysmeFbxQOn2w8qQRyLdjHh4imjrE2YExEtLv427kygOQqf4DOykhS6jh UiqboiWCR+nWq9UXZHch4RUY2lrhDIcSz7n8vScJolKt+Px8jP8b6G4ULQJ6tjCokgle 4XZEx6LaCUgxJDHd5VesSes7HR2Ms5zF6XBimsZqp9eDQOt94ZIlGuikTdxbb4l7tw83 VxSYMAkAuCe9SCVHerL9s5YfWTkJdXA+ma8qQRBSKAfMlFdihg2WtAy7e9uGf1UxR8CK 8JXw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=GIc/+PDO2htV2jMp3KoF29hKZ12iZrid4FdCljLl48k=; b=dT54mgf6n5kl2Wl8qUjTQIWTJYP+qqKKZC6n22wLPeBr/aGg+w4aPJMw8Sn44MWPBM CwpRuKMoDWIDiiZCyZclnuENLU0upWy5HGu4srNEXUBskEgGxCp9YmBigoLGbMUUXkMK 8SlW3I7rZS7c8rrZoVjjrc6TQ+nVhYuECz+vFc08ox5kSOJUrvZ/xC9s9ZR/G10/LcZ0 FOiLJPoD2q6YW4833wfzfxdwGYyZHJ1cRQpjxI1/zdpghn86vj1xwVQZ4txFkMH0Mcuj uWO7+ZSJpyy/T7D+19O8n88bX3FG7hptyp1nXQl3Toit/X0m2LpOkJ+PYgeqkThaZYAl HPvA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=afaLl3Ha; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id g1-20020a170902fe0100b0019aaf311eaesi25358808plj.267.2023.03.26.15.06.15; Sun, 26 Mar 2023 15:06:26 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=afaLl3Ha; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230418AbjCZWCn (ORCPT + 99 others); Sun, 26 Mar 2023 18:02:43 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35216 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229546AbjCZWCl (ORCPT ); Sun, 26 Mar 2023 18:02:41 -0400 Received: from mail-yb1-xb31.google.com (mail-yb1-xb31.google.com [IPv6:2607:f8b0:4864:20::b31]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DE8E959F9 for ; Sun, 26 Mar 2023 15:02:39 -0700 (PDT) Received: by mail-yb1-xb31.google.com with SMTP id n125so8210297ybg.7 for ; Sun, 26 Mar 2023 15:02:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1679868159; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=GIc/+PDO2htV2jMp3KoF29hKZ12iZrid4FdCljLl48k=; b=afaLl3Ha4GhPKcKshef+64lLZtACUvVS/1jAuXiJO7hdtSCrNjJ83E8oq5/9midSG1 1fZuC5nCf/LPJoMTg1uQtioaulMia4KDC7k1qRAwPHNsW7ehCS+UcuEC+VTTrVfJTJ0A gA+/YGB2UnIjcaAMzIm7zjFqilwua3AeEOWAiZPEgU1k3I3+7xfpqxiF+a7YV5fNSqXE 0jVitL1jMy/PkvR+OtowmcyL9F4gw4vNVBuOnI7LpDXbCIKwKeYtTFemF0YihbK5JwFm V7s87ESYtCcbmaadxyYcysQmkVdQBI/iPK6Qj+KeCaASiGYQMb5CANXTHbXwHLhEK1q3 kvgA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679868159; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=GIc/+PDO2htV2jMp3KoF29hKZ12iZrid4FdCljLl48k=; b=rVjy6so+daORjyfblMyi5HwSffiJBO4HVdgcp1pn+QaXAG+zrI1uaMpNGhCh6Gbk7l BoKlb75vnFRZbsTngjOVXSzoReK6WJJ0sNQizoZxDa8waEz4L1d736dK5bwRceHMc87+ GUv8hObE8v9zDYCYsRkYvHV/UFK7/oAS6lnKPBc2gbPw6cmLo58rJqRzGXDds8hxR00f aFfC6+Ii7SL6pLkVf4ug9mnf4kcQ4B5rC1nJRHeae4oTFy1d3NWu2zayXrIs6t5sjh7x /GMXwjC4QVBncitvh9EExUzkWQ+wqC+qX40RemqeyNYlfoBS4fraQC/CfjUZsWMiXC/P rvcw== X-Gm-Message-State: AAQBX9dmzbMMmJ218b9YIfUtVE0ULhbRQ7DOde3p6iuif15HJ7eYVEvi rWIR8Z1YoUTaF5ZPmppfz1+g9ePLV7/cLkF8pSkTzQ== X-Received: by 2002:a05:6902:1201:b0:b6c:4d60:1bd6 with SMTP id s1-20020a056902120100b00b6c4d601bd6mr6141431ybu.9.1679868159111; Sun, 26 Mar 2023 15:02:39 -0700 (PDT) MIME-Version: 1.0 References: <1677774797-31063-1-git-send-email-quic_vpolimer@quicinc.com> <1677774797-31063-15-git-send-email-quic_vpolimer@quicinc.com> <20230326162723.3lo6pnsfdwzsvbhj@ripper> In-Reply-To: <20230326162723.3lo6pnsfdwzsvbhj@ripper> From: Dmitry Baryshkov Date: Mon, 27 Mar 2023 01:02:28 +0300 Message-ID: Subject: Re: [PATCH v14 14/14] drm/msm/dp: set self refresh aware based on PSR support To: Bjorn Andersson Cc: Vinod Polimera , dri-devel@lists.freedesktop.org, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, robdclark@gmail.com, dianders@chromium.org, swboyd@chromium.org, quic_kalyant@quicinc.com, quic_khsieh@quicinc.com, quic_vproddut@quicinc.com, quic_bjorande@quicinc.com, quic_abhinavk@quicinc.com, quic_sbillaka@quicinc.com Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-0.2 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 26 Mar 2023 at 19:24, Bjorn Andersson wrote: > > On Thu, Mar 02, 2023 at 10:03:17PM +0530, Vinod Polimera wrote: > > For the PSR to kick in, self_refresh_aware has to be set. > > Initialize it based on the PSR support for the eDP interface. > > > > When I boot my sc8280xp devices (CRD and X13s) to console with this > patch included I get a login prompt, and then there are no more screen > updates. > > Switching virtual terminal (ctrl+alt+fN) causes the screen to redraw. > > Blindly login in and launching Wayland works and from then on screen > updates works as expected. > > Switching from Wayland to another virtual terminal causes the problem to > re-appear, no updates after the initial refresh, switching back go the > Wayland-terminal crashed the machine. > > > > Reverting this single patch resolves both the issue with the console > updating as exected and flipping between the virtual terminal with > Wayland and the others no longer crashes my machine. I hope Vinod Polimera can assist in solving the issue. In the worst case we will have to revert this commit, shortcutting the PSR until it is properly debugged. > > Regards, > Bjorn > > > Signed-off-by: Vinod Polimera > > --- > > drivers/gpu/drm/msm/dp/dp_drm.c | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/drivers/gpu/drm/msm/dp/dp_drm.c b/drivers/gpu/drm/msm/dp/dp_drm.c > > index 029e08c..785d766 100644 > > --- a/drivers/gpu/drm/msm/dp/dp_drm.c > > +++ b/drivers/gpu/drm/msm/dp/dp_drm.c > > @@ -117,6 +117,8 @@ static int edp_bridge_atomic_check(struct drm_bridge *drm_bridge, > > if (WARN_ON(!conn_state)) > > return -ENODEV; > > > > + conn_state->self_refresh_aware = dp->psr_supported; > > + > > if (!conn_state->crtc || !crtc_state) > > return 0; > > > > -- > > 2.7.4 > > -- With best wishes Dmitry