Received: by 2002:a05:6358:11c7:b0:104:8066:f915 with SMTP id i7csp2116222rwl; Sun, 26 Mar 2023 16:19:51 -0700 (PDT) X-Google-Smtp-Source: AKy350aNGprZiE9P5iy5Fk8osyZnjxU08dA/8FagQU2/WMi//9BgkRyW61vdegDmrDskKwHjTJdB X-Received: by 2002:a17:90b:4b49:b0:237:2f3c:a1cd with SMTP id mi9-20020a17090b4b4900b002372f3ca1cdmr11467209pjb.19.1679872791405; Sun, 26 Mar 2023 16:19:51 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1679872791; cv=none; d=google.com; s=arc-20160816; b=zj17JOKHK+kjVSPGSzlD5Jh36Dy4HAQOVm4JaH0e3cllhEMPzoGPoZs1j0zkuKOARz o99tMemdTqo1OcC0L9ugIgoKWZR085vLici7p5yslLBs2snzW12ljaBezOiPwgb03QAs CRNvgKoB4x5oga9UY/jM95Sb8a0LfEnJcwceDpKbc1BHksFcs3LHKk5dXCDJ87NZe3VM U6WM7sDopAsFQ970oITMHo0sdAXe5pcj45knkrlaYOO/3YCPTn57vpuTK/7wLz4AySqU 5dPqQ8+1gU8rz2HSl46eO4q76zcHtluT+MakmujPku+KogtBK2TjzNVFKnLPBSzLKDcY jxAA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=M7NmYC/Iylm9myghHwqILim55SAUt9QrM+UZYk0eJlw=; b=VoEHqgzjIc/lKwPVrpkdNMPNSBmCpnSiTFYwtA8aofem5FnvOhIQ5c1cQyfkrnkFNP 6E/YEPb0EoMO8lZHYMHMtA0ZMLpOEoC4jX+yohI0RNMWNOo+xNwXkS2Fg/yG81OsXel2 gSqoRuTqUYgCw19yV1pB6S1t2olPgamaFGv/xIrFMiuYQ5af+y3CltpHrYcVyqp+NpvS uwdyNX2xKP/SPzoO7vDModSlFVFofyxHOFGFKxF7kMP1rEgsT1gwx9AInlUZh9z8q8nx LWrZJV+RF0Az59x3IRHuNkHRAFb14T8q4e5PcKxwhOVFfWPkXIQeiLcdTRB/KnwNC0LL 4HXA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id z10-20020a170903018a00b001a055028d0csi28603867plg.56.2023.03.26.16.19.39; Sun, 26 Mar 2023 16:19:51 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229765AbjCZXTg (ORCPT + 99 others); Sun, 26 Mar 2023 19:19:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46836 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229471AbjCZXTf (ORCPT ); Sun, 26 Mar 2023 19:19:35 -0400 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9A884449F for ; Sun, 26 Mar 2023 16:19:34 -0700 (PDT) Received: by verein.lst.de (Postfix, from userid 2407) id A249268B05; Mon, 27 Mar 2023 01:19:31 +0200 (CEST) Date: Mon, 27 Mar 2023 01:19:31 +0200 From: Christoph Hellwig To: Liu Shixin Cc: Seth Jennings , Dan Streetman , Vitaly Wool , Andrew Morton , Nathan Chancellor , Christoph Hellwig , linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH -next v7 1/4] mm/zswap: remove zswap_entry_cache_{create,destroy} helper function Message-ID: <20230326231931.GA19631@lst.de> References: <20230325071420.2246461-1-liushixin2@huawei.com> <20230325071420.2246461-2-liushixin2@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230325071420.2246461-2-liushixin2@huawei.com> User-Agent: Mutt/1.5.17 (2007-11-01) X-Spam-Status: No, score=0.0 required=5.0 tests=SPF_HELO_NONE,SPF_NONE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Looks good: Reviewed-by: Christoph Hellwig