Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 27 Mar 2023 01:26:25 +0200
From:   Christoph Hellwig <hch@lst.de>
To:     Liu Shixin <liushixin2@huawei.com>
Cc:     Seth Jennings <sjenning@redhat.com>,
        Dan Streetman <ddstreet@ieee.org>,
        Vitaly Wool <vitaly.wool@konsulko.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        Nathan Chancellor <nathan@kernel.org>,
        Christoph Hellwig <hch@lst.de>, linux-kernel@vger.kernel.org,
        linux-mm@kvack.org
Subject: Re: [PATCH -next v7 3/4] mm/zswap: replace
 zswap_init_{started/failed} with zswap_init_state
Message-ID: <20230326232625.GC19631@lst.de>
References: <20230325071420.2246461-1-liushixin2@huawei.com> <20230325071420.2246461-4-liushixin2@huawei.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230325071420.2246461-4-liushixin2@huawei.com>
User-Agent: Mutt/1.5.17 (2007-11-01)
Precedence: bulk

On Sat, Mar 25, 2023 at 03:14:19PM +0800, Liu Shixin wrote:
> -/* used by param callback function */
> -static bool zswap_init_started;
> +#define ZSWAP_UNINIT		0x0
> +#define ZSWAP_INIT_SUCCEED	0x1
> +#define ZSWAP_INIT_FAILED	0x2

This should be a (named) enum.