Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230326001535.149539-1-bigbeeshane@gmail.com>
 <20230326184040.33008-1-bigbeeshane@gmail.com> <20230326184040.33008-2-bigbeeshane@gmail.com>
 <0711b320-6c36-6564-70d2-35fc76ac1ebc@linaro.org>
In-Reply-To: <0711b320-6c36-6564-70d2-35fc76ac1ebc@linaro.org>
From:   Shane Francis <bigbeeshane@gmail.com>
Date:   Mon, 27 Mar 2023 00:31:18 +0100
Message-ID: <CABnpCuC1PLYT82A2iMPkPgRPB0mzGUfF=wBzPpAp+YMN_VfGjg@mail.gmail.com>
Subject: Re: [PATCH v2 2/3] dt-bindings: clock: update rk3588 clock definitions
To:     Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc:     robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
        heiko@sntech.de, devicetree@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org,
        linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Hi

> We did not finish discussion yet, so sending new version 50 minutes
> after your last reply does not give me a chance to respond.

I was refreshing the patch set to address your comments on the new DTS
setup for the R6S, I did not change this portion of the patch.

I apologise for missing some of the rules here, I am just onboarding this
device for a personal project, but will leave it here for now.


Regards


On Sun, Mar 26, 2023 at 9:04=E2=80=AFPM Krzysztof Kozlowski
<krzysztof.kozlowski@linaro.org> wrote:
>
> On 26/03/2023 20:40, Shane Francis wrote:
> > Some vendor uboot bootloaders use the target kernels DTB image to
> > determine the target clock speeds for some PLLs, currently this can cau=
se
> > uboot to set the clock rate for gpll incorrectly on to cpll (breaking)
> > RGMII.
>
> Do not attach (thread) your patchsets to some other threads (unrelated
> or older versions). This buries them deep in the mailbox and might
> interfere with applying entire sets.
>
> >
> > This change starts the PLL clock definitions from 1 to correct this
> > miss-match
> >
> > This could be handled by uboot bu updating mappings in that code base
> > however not all devices will have a replaceable uboot (in cases such as
> > when a secure boot chain is implemented)
> >
> > Signed-off-by: Shane Francis <bigbeeshane@gmail.com>
> > ---
> >  .../dt-bindings/clock/rockchip,rk3588-cru.h   | 1442 ++++++++---------
> >  1 file changed, 721 insertions(+), 721 deletions(-)
> >
> > diff --git a/include/dt-bindings/clock/rockchip,rk3588-cru.h b/include/=
dt-bindings/clock/rockchip,rk3588-cru.h
> > index b5616bca7b44..d63b07d054b7 100644
> > --- a/include/dt-bindings/clock/rockchip,rk3588-cru.h
> > +++ b/include/dt-bindings/clock/rockchip,rk3588-cru.h
>
> We did not finish discussion yet, so sending new version 50 minutes
> after your last reply does not give me chance to respond.
>
> Best regards,
> Krzysztof
>