Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Sun, 26 Mar 2023 20:01:23 -0400
From:   William Breathitt Gray <william.gray@linaro.org>
To:     Johannes Berg <johannes.berg@intel.com>,
        Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
        Al Viro <viro@zeniv.linux.org.uk>
Cc:     linux-iio@vger.kernel.org, Jonathan Cameron <jic23@kernel.org>,
        Andrew Morton <akpm@linux-foundation.org>,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/3] counter: 104-quad-8: Refactor to buffer states
 for CMR, IOR, and IDR
Message-ID: <ZCDc0zPtPSyDgOaF@fedora>
References: <cover.1679605919.git.william.gray@linaro.org>
 <c5adb13b4b0887beb1df40b34d2ef03d63a2860d.1679605919.git.william.gray@linaro.org>
 <ZB2OG4zZXsqqyN8v@smile.fi.intel.com>
 <ZB2Ob9VGe3GoEVko@smile.fi.intel.com>
 <ZB2k9m7rL7Hpy/zU@fedora>
 <ZB2qI7k/Igws5khg@smile.fi.intel.com>
 <ZB3DJjQLa48AodSD@fedora>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="VOBZKfGdbh/Z/7o0"
Content-Disposition: inline
In-Reply-To: <ZB3DJjQLa48AodSD@fedora>
Precedence: bulk


--VOBZKfGdbh/Z/7o0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Fri, Mar 24, 2023 at 11:35:02AM -0400, William Breathitt Gray wrote:
> There are eight calls to quad8_control_register_update() in 104-quad-8:
>=20
>         quad8_control_register_update(priv, priv->idr, id, DISABLE_INDEX_=
MODE, INDEX_MODE);
>         quad8_control_register_update(priv, priv->cmr, id, mode_cfg, QUAD=
RATURE_MODE);
>         quad8_control_register_update(priv, priv->ior, event_node->channe=
l, flg_pins, FLG_PINS);
>         quad8_control_register_update(priv, priv->idr, channel_id, index_=
polarity, INDEX_POLARITY);
>         quad8_control_register_update(priv, priv->idr, channel_id, synchr=
onous_mode, INDEX_MODE);
>         quad8_control_register_update(priv, priv->cmr, count->id, count_m=
ode, COUNT_MODE);
>         quad8_control_register_update(priv, priv->ior, count->id, enable,=
 AB_GATE);
>         quad8_control_register_update(priv, priv->ior, count->id, !preset=
_enable, LOAD_PIN);

I attempted the cross-compiling using an x86-64 system and I was able to
recreate the build error. I tried to isolate the problem line by
commenting out quad8_control_register_update() calls and discover that
this appears to be an inline issue after all: if there are more than six
calls to quad8_control_register_update() are in the code, then the
'__bad_mask' build error occurs.

The build error doesn't occur if I force the inline via __always_inline,
so I'll add that to quad8_control_register_update() to resolve this
issue and submit a v3 patchset later this week.

William Breathitt Gray

--VOBZKfGdbh/Z/7o0
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEARYKAB0WIQSNN83d4NIlKPjon7a1SFbKvhIjKwUCZCDc0wAKCRC1SFbKvhIj
K6DUAQCHK6g+zrtL2opXqvDT2GFt26czSyY6ss78QElPdbKgbgEA7jhk8Q8oAeE2
fnq8aYq272RzeXV1qKomPviXXtZMbgc=
=2imo
-----END PGP SIGNATURE-----

--VOBZKfGdbh/Z/7o0--