Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   ye xingchen <yexingchen116@gmail.com>
To:     mcgrof@kernel.org
Cc:     akpm@linux-foundation.org, chi.minghao@zte.com.cn,
        hch@infradead.org, keescook@chromium.org, linmiaohe@huawei.com,
        linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-mm@kvack.org, vbabka@suse.cz, willy@infradead.org,
        ye.xingchen@zte.com.cn, yexingchen116@gmail.com, yzaikin@google.com
Subject: Re: [PATCH V5 1/2] mm: compaction: move compaction sysctl to its own file
Date:   Mon, 27 Mar 2023 02:49:39 +0000
Message-Id: <20230327024939.75976-1-ye.xingchen@zte.com.cn>
In-Reply-To: <ZB3n1pJZsOK+E/Zk@bombadil.infradead.org>
References: <ZB3n1pJZsOK+E/Zk@bombadil.infradead.org>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Precedence: bulk

>> >$ ./scripts/bloat-o-meter vmlinux.old vmlinux
>> >add/remove: 1/0 grow/shrink: 1/2 up/down: 346/-350 (-4)
>> >Function                                     old     new   delta
>> >vm_compaction                                  -     320    +320
>> >kcompactd_init                               167     193     +26
>> >proc_dointvec_minmax_warn_RT_change          104      10     -94
>> >vm_table                                    2112    1856    -256
>> >Total: Before=19287558, After=19287554, chg -0.00%
>> >
>> >So I don't think we need to pause this move or others where are have savings.
>> >
>> >Minghao, can you fix the commit log, and explain how you are also saving
>> >4 bytes as per the above bloat-o-meter results?
>> 
>> $ ./scripts/bloat-o-meter vmlinux vmlinux.new
>> add/remove: 1/0 grow/shrink: 1/1 up/down: 350/-256 (94)
>> Function                                     old     new   delta
>> vm_compaction                                  -     320    +320
>> kcompactd_init                               180     210     +30
>> vm_table                                    2112    1856    -256
>> Total: Before=21104198, After=21104292, chg +0.00%
>> 
>> In my environment, kcompactd_init increases by 30 instead of 26.
>> And proc_dointvec_minmax_warn_RT_change No expansion.
>
>How about a defconfig + compaction enabled? Provide that information
>and let Vlastimal ACK/NACK the patch.
I use x86_defconfig and linux-next-20230327 branch
$ make defconfig;make all -j120
CONFIG_COMPACTION=y

add/remove: 1/0 grow/shrink: 1/1 up/down: 350/-256 (94)
Function                                     old     new   delta
vm_compaction                                  -     320    +320
kcompactd_init                               180     210     +30
vm_table                                    2112    1856    -256
Total: Before=21119987, After=21120081, chg +0.00%