Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Alexander Stein <alexander.stein@ew.tq-group.com>
To:     peng.fan@oss.nxp.com, linux-arm-kernel@lists.infradead.org
Cc:     Markus.Niebel@ew.tq-group.com, abailon@baylibre.com,
        abelvesa@kernel.org, aford173@gmail.com,
        devicetree@vger.kernel.org, djakov@kernel.org, festevam@gmail.com,
        kernel@pengutronix.de, krzysztof.kozlowski+dt@linaro.org,
        l.stach@pengutronix.de, laurent.pinchart@ideasonboard.com,
        linux-arm-kernel@lists.infradead.org, linux-imx@nxp.com,
        linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org,
        marex@denx.de, paul.elder@ideasonboard.com, peng.fan@nxp.com,
        robh+dt@kernel.org, s.hauer@pengutronix.de, shawnguo@kernel.org,
        gerg@kernel.org, Greg Ungerer <gerg@linux-m68k.org>
Subject: Re: [PATCH V3 7/7] arm64: dts: imx8mp: add interconnect for hsio blk ctrl
Date:   Mon, 27 Mar 2023 08:27:31 +0200
Message-ID: <2678294.mvXUDI8C0e@steina-w>
Organization: TQ-Systems GmbH
In-Reply-To: <20230327045037.593326-1-gerg@linux-m68k.org>
References: <20220703091451.1416264-8-peng.fan@oss.nxp.com> <20230327045037.593326-1-gerg@linux-m68k.org>
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset="iso-8859-1"
Precedence: bulk

Hi Greg,

Am Montag, 27. M=E4rz 2023, 06:50:37 CEST schrieb Greg Ungerer:
> On 2/3/22 17:13, Peng Fan wrote:
> > From: Peng Fan <peng.fan@nxp.com>
> >=20
> > Add interconnect property for hsio blk ctrl
> >=20
> > Signed-off-by: Peng Fan <peng.fan@nxp.com>
> > ---
> >=20
>  > arch/arm64/boot/dts/freescale/imx8mp.dtsi | 5 +++++
>  > 1 file changed, 5 insertions(+)
> >=20
> > diff --git a/arch/arm64/boot/dts/freescale/imx8mp.dtsi
> > b/arch/arm64/boot/dts/freescale/imx8mp.dtsi index
> > 08bd57742294..9cceeeeb26be 100644
> > --- a/arch/arm64/boot/dts/freescale/imx8mp.dtsi
> > +++ b/arch/arm64/boot/dts/freescale/imx8mp.dtsi
> > @@ -1109,6 +1109,11 @@ hsio_blk_ctrl: blk-ctrl@32f10000 {
> >=20
> >  						<&pgc_hsiomix>,=20
<&pgc_pcie_phy>;
> >  			=09
> >  				power-domain-names =3D "bus", "usb",=20
"usb-phy1",
> >  			=09
> >  						     "usb-phy2",=20
"pcie", "pcie-phy";
> >=20
> > +				interconnects =3D <&noc=20
IMX8MP_ICM_NOC_PCIE &noc IMX8MP_ICN_HSIO>,
> > +						<&noc=20
IMX8MP_ICM_USB1 &noc IMX8MP_ICN_HSIO>,
> > +						<&noc=20
IMX8MP_ICM_USB2 &noc IMX8MP_ICN_HSIO>,
> > +						<&noc=20
IMX8MP_ICM_PCIE &noc IMX8MP_ICN_HSIO>;
> > +				interconnect-names =3D "noc-pcie",=20
"usb1", "usb2", "pcie";
> >=20
> >  				#power-domain-cells =3D <1>;
> >  		=09
> >  			};
> >  	=09
> >  		};
>=20
> This change completely breaks USB for me on a new iMX8mp platform I am
> working with. Before this change normal USB probe looks good:
>=20
>     xhci-hcd xhci-hcd.0.auto: xHCI Host Controller
>     xhci-hcd xhci-hcd.0.auto: new USB bus registered, assigned bus number=
 1
>     xhci-hcd xhci-hcd.0.auto: hcc params 0x0220fe6d hci version 0x110 qui=
rks
> 0x0000000000010010 xhci-hcd xhci-hcd.0.auto: irq 206, io mem 0x38100000
>     xhci-hcd xhci-hcd.0.auto: xHCI Host Controller
>     xhci-hcd xhci-hcd.0.auto: new USB bus registered, assigned bus number=
 2
>     xhci-hcd xhci-hcd.0.auto: Host supports USB 3.0 SuperSpeed
>     usb usb1: New USB device found, idVendor=3D1d6b, idProduct=3D0002,
> bcdDevice=3D 6.03 usb usb1: New USB device strings: Mfr=3D3, Product=3D2,
> SerialNumber=3D1 usb usb1: Product: xHCI Host Controller
>     usb usb1: Manufacturer: Linux 6.3.0-rc4-dirty xhci-hcd
>     ....
>=20
> But after this commit is applied, no USB probe messages at all.
>=20
> USB worked fine in 6.0 for me, but when I switched up to 6.1 USB was brok=
en,
> I bisected to this as being the offending commit. This is still broken for
> me in todays 6.3-rc4. If I revert this change (and only this change) USB
> works again.
>=20
> Any thoughts on why this breaks USB?

Maybe you are missing CONFIG_INTERCONNECT_IMX8MP?

Best regards,
Alexander

=2D-=20
TQ-Systems GmbH | M=FChlstra=DFe 2, Gut Delling | 82229 Seefeld, Germany
Amtsgericht M=FCnchen, HRB 105018
Gesch=E4ftsf=FChrer: Detlef Schneider, R=FCdiger Stahl, Stefan Schneider
http://www.tq-group.com/