Received: by 2002:a05:6358:11c7:b0:104:8066:f915 with SMTP id i7csp2484652rwl; Mon, 27 Mar 2023 00:23:27 -0700 (PDT) X-Google-Smtp-Source: AKy350aIv3LP79WOOd8uJ5FLBFM3vr+5GJ/ddL9/oYLUsjjMK5jCcMtiR4lybCXuRhyNnBhkMJFG X-Received: by 2002:a17:906:3601:b0:8fc:c566:dc67 with SMTP id q1-20020a170906360100b008fcc566dc67mr12372210ejb.64.1679901806820; Mon, 27 Mar 2023 00:23:26 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1679901806; cv=none; d=google.com; s=arc-20160816; b=g/03AIG3KcFuyUIdf139cRXHK6ZyYnLFtvc64+mf9G9+0VDHdCGr1myZjS7v3NdIhi SJMieXl4jLJWyZlQ5Tn0kab77F2bfTEoMyXYoEKBna3wJ22U9rJGvR3Z/IdzlzTYnkdW 10888dda+Cvgm6DN+Ojb/Zp9rZJzM6LkEJouLSDHz+4jo2nhsvvtNsmFDKV8IYCK/m50 S9IcHXy4/HnuSro710JmdOre5+WP/MUlM5O5IfBXSylkPpcUyPdEijWTN5l9PTDYOSnZ EDpLRhdgkpaK+3/mgIe12PwrpNNj196kgoqrOR0B4Jvp9oTDnPhxFFKZv8UJtN0uWMHL wwdA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:in-reply-to:references:date:message-id :from:subject:content-transfer-encoding:mime-version:dkim-signature; bh=V4YAtvsmgItAekQX4pJa9Ac5mbxWjX7suWAI0ujXEqg=; b=b5GtAwmPa9T/u00mJ+ds3dLBs61M37+r73/o4h32deTmKK/GvTL1pN+zNQ+AU4Vj8J tOO2scqaoQG5u59wYKC2ObA9D/t50vl5mo43xzWrzIAUMP1HcdgS7S10gbmmD4qEwlmk Z8NjPevg1lS1Mhvn6B8+/6IaG8ExXiAIFRy+4Fs+oWQStTg4CLXF/v7XyX6K/Djtv+w1 h4dlYaY+lIVa4tjuvhI6ZS8c4tgPrwWoize4SuHT11yjKKqt299RJJDdbPnxiUouRbyL Szi/7BHhN/hDF+sgTKmkjHg7VZKZ+co+mluXIe8MJ681cFCALeOwvQWPkzPZf2yUbXZ6 Wu0g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=l5bV+NYL; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id l8-20020a1709066b8800b00931b7294f0asi24143600ejr.410.2023.03.27.00.23.02; Mon, 27 Mar 2023 00:23:26 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=l5bV+NYL; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232464AbjC0HUX (ORCPT + 99 others); Mon, 27 Mar 2023 03:20:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49876 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232433AbjC0HUU (ORCPT ); Mon, 27 Mar 2023 03:20:20 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 805D612D; Mon, 27 Mar 2023 00:20:19 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 1071660FF8; Mon, 27 Mar 2023 07:20:19 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPS id 3BDD7C4339C; Mon, 27 Mar 2023 07:20:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1679901618; bh=Fmno9IUHFL/QJZTBpdI7jH/KHqpYXwLcCK8t+LApJ4o=; h=Subject:From:Date:References:In-Reply-To:To:Cc:From; b=l5bV+NYLBrhR08OenBels8TTFjCmkZ+e0XLLHTTqX3K6mqooCMef7QbZrvf1GzKpB sHDGPBe1wBi5pAKSgS8JZHzFLeuqTbQj51NsL5BaiV1bHe+r/+xNjhBIqxD8Ez3+is ++62mnLEHHHgTJTDzzji9gjnaknpomHmpqAonS09oOu9WAA36uqrIUnu3U+BQhMlOs LzRNLeDn5pwwFeio3GAKUoIFWYqwPvJ2qedC/8t++u5MVBjp0Ux0C7uOxgbMl4aXcZ zzLqvKzEFW1gqt3tmLDjyYtWgRodFIaMPGka4vo/Cr7Cqo4s7wrStrZDcZwmmBUp0C jAM0vmiA+fs8w== Received: from aws-us-west-2-korg-oddjob-1.ci.codeaurora.org (localhost.localdomain [127.0.0.1]) by aws-us-west-2-korg-oddjob-1.ci.codeaurora.org (Postfix) with ESMTP id 1C784E2A038; Mon, 27 Mar 2023 07:20:18 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: Re: [PATCH net] vsock/loopback: use only sk_buff_head.lock to protect the packet queue From: patchwork-bot+netdevbpf@kernel.org Message-Id: <167990161811.4487.17278563612725612411.git-patchwork-notify@kernel.org> Date: Mon, 27 Mar 2023 07:20:18 +0000 References: <20230324115450.11268-1-sgarzare@redhat.com> In-Reply-To: <20230324115450.11268-1-sgarzare@redhat.com> To: Stefano Garzarella Cc: netdev@vger.kernel.org, bobby.eshleman@bytedance.com, davem@davemloft.net, pabeni@redhat.com, edumazet@google.com, linux-kernel@vger.kernel.org, avkrasnov@sberdevices.ru, kuba@kernel.org, virtualization@lists.linux-foundation.org, syzbot+befff0a9536049e7902e@syzkaller.appspotmail.com X-Spam-Status: No, score=-2.5 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello: This patch was applied to netdev/net.git (main) by David S. Miller : On Fri, 24 Mar 2023 12:54:50 +0100 you wrote: > pkt_list_lock was used before commit 71dc9ec9ac7d ("virtio/vsock: > replace virtio_vsock_pkt with sk_buff") to protect the packet queue. > After that commit we switched to sk_buff and we are using > sk_buff_head.lock in almost every place to protect the packet queue > except in vsock_loopback_work() when we call skb_queue_splice_init(). > > As reported by syzbot, this caused unlocked concurrent access to the > packet queue between vsock_loopback_work() and > vsock_loopback_cancel_pkt() since it is not holding pkt_list_lock. > > [...] Here is the summary with links: - [net] vsock/loopback: use only sk_buff_head.lock to protect the packet queue https://git.kernel.org/netdev/net/c/b465518dc27d You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html