Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 27 Mar 2023 10:11:56 +0200
From:   Miquel Raynal <miquel.raynal@bootlin.com>
To:     Christophe Kerello <christophe.kerello@foss.st.com>
Cc:     <richard@nod.at>, <vigneshr@ti.com>,
        <linux-mtd@lists.infradead.org>, <linux-kernel@vger.kernel.org>,
        <linux-stm32@st-md-mailman.stormreply.com>
Subject: Re: [PATCH] mtd: rawnand: stm32_fmc2: do not support EDO mode
Message-ID: <20230327101156.0ec2816a@xps-13>
In-Reply-To: <fcb600af-88dc-55a7-917e-4cf4673c2973@foss.st.com>
References: <20230324160918.826452-1-christophe.kerello@foss.st.com>
        <20230324172528.4d3ccd4b@xps-13>
        <f4c32aa5-e5b1-6465-7708-ef0281baf0af@foss.st.com>
        <fcb600af-88dc-55a7-917e-4cf4673c2973@foss.st.com>
Organization: Bootlin
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Hi Christophe,

christophe.kerello@foss.st.com wrote on Mon, 27 Mar 2023 10:02:13 +0200:

> Hello Miquel,
>=20
> On 3/24/23 17:34, Christophe Kerello wrote:
> > Hello Miquel,
> >=20
> > On 3/24/23 17:25, Miquel Raynal wrote: =20
> >> Hi Christophe,
> >>
> >> christophe.kerello@foss.st.com wrote on Fri, 24 Mar 2023 17:09:18 +010=
0:
> >> =20
> >>> FMC2 controller does not support EDO mode (timings mode 4 and 5).
> >>>
> >>> Signed-off-by: Christophe Kerello <christophe.kerello@foss.st.com>
> >>> Fixes: 2cd457f328c1 ("mtd: rawnand: stm32_fmc2: add STM32 FMC2 NAND >=
>> flash controller driver")
> >>> ---
> >>> =C2=A0 drivers/mtd/nand/raw/stm32_fmc2_nand.c | 3 +++
> >>> =C2=A0 1 file changed, 3 insertions(+)
> >>>
> >>> diff --git a/drivers/mtd/nand/raw/stm32_fmc2_nand.c >>> b/drivers/mtd=
/nand/raw/stm32_fmc2_nand.c
> >>> index 5d627048c420..3abb63d00a0b 100644
> >>> --- a/drivers/mtd/nand/raw/stm32_fmc2_nand.c
> >>> +++ b/drivers/mtd/nand/raw/stm32_fmc2_nand.c
> >>> @@ -1531,6 +1531,9 @@ static int >>> stm32_fmc2_nfc_setup_interface(s=
truct nand_chip *chip, int chipnr,
> >>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 if (IS_ERR(sdrt))
> >>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 return PTR_ERR=
(sdrt);
> >>> +=C2=A0=C2=A0=C2=A0 if (sdrt->tRC_min < 30000) =20
> >>
> >> When introducing NV-DDR support we as well added a timings.mode field,
> >> perhaps you could use it? =20
> >=20
> > Yes, I can use it. It will be done in V2.
> >=20
> > Regards,
> > Christophe Kerello.
> >  =20
>=20
> I had a look at Kernel LTS, and timings.mode was introduced on Kernel LTS=
 5.10. As this patch has also to be applied on Kernel LTS 5.4, my proposal =
is to send a new patch set. The first patch will be the current patch (fix =
for all Kernel LTS) and the second patch will use timings.mode instead of c=
hecking tRC_min timings for next Kernel delivery. Is this proposal acceptab=
le?

Works for me!

Thanks,
Miqu=C3=A8l