Received: by 2002:a05:6358:11c7:b0:104:8066:f915 with SMTP id i7csp2539534rwl; Mon, 27 Mar 2023 01:25:07 -0700 (PDT) X-Google-Smtp-Source: AKy350bu/Lzpzuua34t3wcXGUEHX7hYGf1KVR0HVEYciCew5vI72Z37bqeZY10fJRHHg1oVptXRe X-Received: by 2002:a17:906:7fd1:b0:86f:64bb:47eb with SMTP id r17-20020a1709067fd100b0086f64bb47ebmr11702987ejs.3.1679905507334; Mon, 27 Mar 2023 01:25:07 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1679905507; cv=none; d=google.com; s=arc-20160816; b=KyQn+XiyMividNsy/h6dpjiU2Tr5kUtCXz6cmNmvJjIU07FvJP8HzRQBM5rPOWlUfb r2azf9lKyJHl0AWP4jQ7Zjs6J7vfldi2lbGZJBD4zW8UKpQ7YqbsNMTxYB2+52iv2Svm bkg3esj8pNL9ayORN/uIcRCHDMR9aGovUhi3cr7/OXsCcI9+71ruu9KC6BhFnwiEdBVT zYJ0Q1dD9mh71cd18UOe3tkGUia8wvTLdZvEOCSz/4KPrElUqBXJNZPYa4yNI1Fuplr4 tYDdRWQ3sqRHRUf6OIucQxwdAS/ET7FFBKz3ydKUxNgnYvL+9mYd5RowhVcBldayIwfx VL0g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:mail-followup-to:message-id:subject:cc:to:from:date :dkim-signature; bh=wH3obomwuRGdKjPAhLtm6bX6Oavf5FaaB4mMjZ7CVTg=; b=KYdFzQGCoTEeMUjvFD0DHwuhzxX/Qu5uJGmIVYMF/7HLFmbbH8VyavhZXWaUFlRQK6 +Hb+He/X4ogJLZYkihHvAKKkOfwD38f2c9BaZwImJa0/OADluBH+NIK1mIiu0z9wuTdr YdBZoJzdCTbsHn3CQktgxBUxuc36WaJEnxWAbvMJCr62spcDJ8Qp/5rMZ9esn0uwd4E2 63RLN+q1IsD0YhI9oYouyg1wpCt0L9C9iFQsZQZ6E2K+v9+zng1/ewPUTW1ZvOS0XSjX 3PvYcYQGBuQyi+SRk9X4pBcPVRU9uSeIILpWjJYP2Wxk+/siAyYCCOBbqm14g3Jsqt2/ 2P8w== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail (test mode) header.i=@sang-engineering.com header.s=k1 header.b=AWKXt0Pl; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id s16-20020a170906061000b008b593e8957esi25160569ejb.884.2023.03.27.01.24.42; Mon, 27 Mar 2023 01:25:07 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=fail (test mode) header.i=@sang-engineering.com header.s=k1 header.b=AWKXt0Pl; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232545AbjC0IPa (ORCPT + 99 others); Mon, 27 Mar 2023 04:15:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45704 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233026AbjC0IPI (ORCPT ); Mon, 27 Mar 2023 04:15:08 -0400 Received: from mail.zeus03.de (www.zeus03.de [194.117.254.33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 88FF949E8 for ; Mon, 27 Mar 2023 01:15:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple; d=sang-engineering.com; h= date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=k1; bh=dBOXurVqj/MpMeq7Dle54wgSV5Q1 alYox1rkTkRCkMo=; b=AWKXt0Plw+rjd7A3YnNT0Fp9WhzaT4NndoV8v4KBzk3c awUQC+4QF6w/JhTh7g0AKsKOjLa1Q3+1OIcDRuHc6+kiYNHWBHJ1/q+PTGaKijVF 5Zbo6utek8eQ3yzr/x1foY44zomLKuV4Ctn1gEDug/4p2qG1YbRi6ymOgiBrDLg= Received: (qmail 3059495 invoked from network); 27 Mar 2023 10:14:58 +0200 Received: by mail.zeus03.de with ESMTPSA (TLS_AES_256_GCM_SHA384 encrypted, authenticated); 27 Mar 2023 10:14:58 +0200 X-UD-Smtp-Session: l3s3148p1@fcW5Vt33HLQujnv6 Date: Mon, 27 Mar 2023 10:14:58 +0200 From: Wolfram Sang To: Sergey Shtylyov Cc: Jakub Kicinski , Geert Uytterhoeven , netdev@vger.kernel.org, linux-renesas-soc@vger.kernel.org, Geert Uytterhoeven , "David S. Miller" , Eric Dumazet , Paolo Abeni , linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next] sh_eth: remove open coded netif_running() Message-ID: Mail-Followup-To: Wolfram Sang , Sergey Shtylyov , Jakub Kicinski , Geert Uytterhoeven , netdev@vger.kernel.org, linux-renesas-soc@vger.kernel.org, Geert Uytterhoeven , "David S. Miller" , Eric Dumazet , Paolo Abeni , linux-kernel@vger.kernel.org References: <20230321065826.2044-1-wsa+renesas@sang-engineering.com> <79d945a4-e105-4bc4-3e73-64971731660e@omp.ru> <20230323094034.5b021c65@kernel.org> <6d2f216c-df1d-9ab5-353c-de5e5e082b57@omp.ru> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="2MGGcozzLoV/RlMr" Content-Disposition: inline In-Reply-To: <6d2f216c-df1d-9ab5-353c-de5e5e082b57@omp.ru> X-Spam-Status: No, score=-0.2 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL,SPF_HELO_PASS,SPF_NONE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --2MGGcozzLoV/RlMr Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable > > Nope - one is under rtnl_lock, the other under just RCU, IIRC. > > So this patch just makes the race worse, but it was already > > racy before. >=20 > How about reverting it then? Agreed. Will send a revert. --2MGGcozzLoV/RlMr Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEOZGx6rniZ1Gk92RdFA3kzBSgKbYFAmQhUHcACgkQFA3kzBSg KbYxbg/+KHZbqTHMix9aCgZXPrX01VDK5eK8U6kE5L+WHoU3RBqqTO1Y3CDf86Mm T8FFmPGGdP1gQTtpw5uSEDli8AgetRTWvc2T81sw7YDXmR0b5e1eZDacmzxvyi6p UCF7F6XVnN//1iOVRNdfxeGtK6NASezdITOtgbotF9aZrmy9c0lapd2xfFTOMXUk +AuL4TRSnxTyCLgieguHbrPdhGq3qbPfVcH88vdnyqINBf1d/Z+8L6QJtWL11qPk pcqTnFByZ6pU384XS4C/vVejmSujQIpuvyHx3K+okTq5EHJoAPrXRdboX6MOCxAt shQkOmT19YXHpYxve7AfWSEKUINj3fCU4V41YNXHN12DBbGqbcjPrgPcMN9R/7jN GMNVMkx7uylXaDfAWnzax6t5J+W/AqB3R2BOHDtjvXaKYikCg+Sx2MgqdI/leZt1 OwYrndoDPzofzBQ1Tcd4Qu5hk94RimpfwngbWkehWa5mXYtLRqgoUNhYcWvkEUZI Dn6oO+SBKrpacqDH7QI+Q9gh6y2cDwuxLu2FIeHkj1EEzVoVfI6VEBRHd5DY/fsR zfQnT+WUIcNZbgstdHKI0BaIc0UOltSabcb90F4tmkoFFH3E7hSt8MVhsmiyRi7J NICb9J/HySL8P5FeSEt2Qw1vP9gh/aM6BfIv4JyXAFbE9aGdDkI= =6y40 -----END PGP SIGNATURE----- --2MGGcozzLoV/RlMr--