Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230306044737.862-1-honda@mechatrax.com> <6e1fe1015235ae7d7eb9ef2526fd64b6d6d628d7.camel@gmail.com>
 <CA+Tz-SHQxNzx=eS8ex=3Hps0th5bTY+K1qSWrZqWC8ryv+d0RA@mail.gmail.com>
In-Reply-To: <CA+Tz-SHQxNzx=eS8ex=3Hps0th5bTY+K1qSWrZqWC8ryv+d0RA@mail.gmail.com>
From:   Masahiro Honda <honda@mechatrax.com>
Date:   Mon, 27 Mar 2023 18:01:14 +0900
Message-ID: <CA+Tz-SFbt2RAz3POMRoTHqz+tNyQOn3UsssZV9EvHUhhR+XJbQ@mail.gmail.com>
Subject: Re: [PATCH] Fix IRQ issue by setting IRQ_DISABLE_UNLAZY flag
To:     =?UTF-8?B?TnVubyBTw6E=?= <noname.nuno@gmail.com>
Cc:     Lars-Peter Clausen <lars@metafoo.de>,
        Michael Hennerich <Michael.Hennerich@analog.com>,
        Jonathan Cameron <jic23@kernel.org>, linux-iio@vger.kernel.org,
        linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Hi, Nuno

> On Mon, Mar 6, 2023 at 10:30=E2=80=AFPM Nuno S=C3=A1 <noname.nuno@gmail.c=
om> wrote:
> > Another thing that came to my mind is if the data is totally
> > garbage/wrong or is it just some outstanding sample?

I'm sorry for not answering your question. The data is the same as
the previous conversion even if the input voltage is changed. At this
time, a logic analyzer shows that the read operation is performed
immediately after the conversion is performed. The read operation
returns the previous conversion result because it is performed before
the completion of the conversion.

> > Some research on this also seems to point that we should (need?) call
> > irq_clear_status_flags(irq, IRQ_DISABLE_UNLAZY) when freeing the IRQ.

I have understood that I need to call irq_clear_status_flags. However,
I cannot find a code to free the IRQ in ad_sigma_delta.c and other
Sigma-Delta ADC driver source files. So, I would like to implement
only irq_set_status_flags.