Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Peng Fan <peng.fan@nxp.com>
To:     Greg Ungerer <gerg@linux-m68k.org>,
        "Peng Fan (OSS)" <peng.fan@oss.nxp.com>
CC:     "Markus.Niebel@ew.tq-group.com" <Markus.Niebel@ew.tq-group.com>,
        "aford173@gmail.com" <aford173@gmail.com>,
        Aisheng Dong <aisheng.dong@nxp.com>,
        "alexander.stein@ew.tq-group.com" <alexander.stein@ew.tq-group.com>,
        "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
        "festevam@gmail.com" <festevam@gmail.com>,
        "kernel@pengutronix.de" <kernel@pengutronix.de>,
        "krzysztof.kozlowski+dt@linaro.org" 
        <krzysztof.kozlowski+dt@linaro.org>,
        "l.stach@pengutronix.de" <l.stach@pengutronix.de>,
        "laurent.pinchart@ideasonboard.com" 
        <laurent.pinchart@ideasonboard.com>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>,
        dl-linux-imx <linux-imx@nxp.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "marex@denx.de" <marex@denx.de>,
        "paul.elder@ideasonboard.com" <paul.elder@ideasonboard.com>,
        "robh+dt@kernel.org" <robh+dt@kernel.org>,
        "s.hauer@pengutronix.de" <s.hauer@pengutronix.de>,
        "shawnguo@kernel.org" <shawnguo@kernel.org>,
        "gerg@kernel.org" <gerg@kernel.org>
Subject: RE: [PATCH] arm64: dts: imx8mp: add vpu pgc nodes
Thread-Topic: [PATCH] arm64: dts: imx8mp: add vpu pgc nodes
Thread-Index: AQHZYGnzfuhET8vzU0qSzMmiiHJQlK8OZTnQ
Date:   Mon, 27 Mar 2023 10:01:50 +0000
Message-ID: <DU0PR04MB94174D60EE38B56FEB6CD5BC888B9@DU0PR04MB9417.eurprd04.prod.outlook.com>
References: <20220713063653.2584488-6-peng.fan@oss.nxp.com>
 <20230327050642.593778-1-gerg@linux-m68k.org>
In-Reply-To: <20230327050642.593778-1-gerg@linux-m68k.org>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?XsdGG1lP8S8xOxDjLNifExGaruPQvdAkStKdOkK/0oqE/ytiblmo6jDMrpF7?=
 =?us-ascii?Q?GLqIgBxuAVvMDWLxTziqZGE2I6PTPKuOKzBxcM8Gd470ytD8foJvo2v00aWb?=
 =?us-ascii?Q?BaxT1WbDY/ajZPPjIrJP3dhvfM4qDxwkvpA2k+vhr15i5pykTwlMl4KUZ4Pq?=
 =?us-ascii?Q?cxowZrhiXqgrEc2ChenXiEEiS7FZ8+t92fzxIYKMJ0GZToX7//AT+biwrlYi?=
 =?us-ascii?Q?NkdcJmRGZPwQ0eFZnsblFB6JbfD1Ew0PonZOw0gsbKmzYiRpNjIo3B6pfGzY?=
 =?us-ascii?Q?X6keLd144DIrLhkgGnfgjGIJGByITadA4gvPsNuO+cUFf7gJY7nqwZ+y1O4Y?=
 =?us-ascii?Q?Bw7/PTfMjcF2LduQWrilkjPc7mnImSyJtvyBpsc7cqIJvrs7z8zpZOEpyb0k?=
 =?us-ascii?Q?yylSXWIxx0qhydwHHC63HU9AB1PWUsmCKqyzTMkIlPz0wHG8sm1AJbuCFcxK?=
 =?us-ascii?Q?WWa8q7uHfUzpmHiq99rKWLjbidYDCu/KT9vpJb98RLswVH4LZZ+EJzcx4W6M?=
 =?us-ascii?Q?EikBZmbqEyoBM/W//y3HJOBVpr69zLsuvnt3ravvQuHTYc1FF/NavyW5Rr0k?=
 =?us-ascii?Q?8zT/69bLeMhDSg7yiMvzzy4qDc2DWo1FKd+u1L0cHVpfcxEUYsTOkObJOxs3?=
 =?us-ascii?Q?+8Uuts3uRk+6sq9HffjfMFtWLMyBQpxgD6HIwhsTumDZIPinGAONi8Z56dSQ?=
 =?us-ascii?Q?hUK9llznAihCiYi02Ta3VQdHzvCDUE68ugfdg7NAdy3dtTKgVVJYvhqTZ4+J?=
 =?us-ascii?Q?yokKPkzrxh37JdZ6f7AUPYfpYxUwMFz3N0J+duKgeHCf3ekS5WQ7lF13sARO?=
 =?us-ascii?Q?XGFwy7U9aNJbl2N5OGayI13alOgReCPLeyQeJrPGPTdDQbihsHktoclcawB9?=
 =?us-ascii?Q?Ui9N8OktIGrsVnSt0cX+h3rnP23hZCR47mp4nI1Zby2Y27gE3qRrU4eoEJsH?=
 =?us-ascii?Q?05OMV46yotX8h74L7qWHpku53IaZnHGO4zqdkzd3238VOaaG/aRI8NBZiZwp?=
 =?us-ascii?Q?veOnrhkh4qLVmJ96ab4NVF22AmmQosJas1mQqgJPsNisAeaJdP0bBjljAHBC?=
 =?us-ascii?Q?4yqqASIrIQobQwO+q2gJoLDJhy/Mw+eqKfzgPRF8cPhRsImJyTr0JwhZG2uT?=
 =?us-ascii?Q?uwyY/Ibt4nfNl+iH1cLMnBzJmhXpiTuxt2f2gaVrJpbuOP1AoQMMUldP9GRa?=
 =?us-ascii?Q?BdlKavNMALAbn51buzE8uOU9rzr6igYxQPGzIXL0/MVwMZj/dgf4hcyOFGlg?=
 =?us-ascii?Q?hl/eOnNfuuP9FxETkrE8QPS3rPh8/8HYmfvrivxqAgwrBSVy7zmJdF5yTFLY?=
 =?us-ascii?Q?84VZXGVBtbWp8pM/z8ieii8MG9J7ywoznt3ROJgLuK8Hi28GZ95e2ojMXQQn?=
 =?us-ascii?Q?DMz6VmMSdnrztTVqLp08oZKFxLAJSymy7Bx53XCcRynPjxtqbN+oyDQ+/HT7?=
 =?us-ascii?Q?J5VT+fLmsdqloGwePugbWddv/pHhDCVbC3qjGmC/DZb/RO361GIbPskCvx6T?=
 =?us-ascii?Q?ktc1sTgI3ov0cQIhC+8cTXGCxA3VkjnX19VZoggKuSRIjCPakm/2rpiW1PHP?=
 =?us-ascii?Q?PBJIHfEGQAz82twByGo=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DU0PR04MB9417.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 2991739f-bd5b-4d56-12dd-08db2eaa48a4
X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Mar 2023 10:01:50.1001
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: juEerTqYrr6niluEKOO/P74tza+UlNP/PnUftbyWDa50JOvBDDg8aIxLdu6gHD0k8LyKFyNCiz6pz7UyFIlCAA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAWPR04MB9888
X-Spam-Status: No, score=-0.2 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
        DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,
        SPF_HELO_PASS,SPF_PASS autolearn=unavailable autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> Subject: Re: [PATCH] arm64: dts: imx8mp: add vpu pgc nodes
>=20
> On 22/8/22 14:45, Peng Fan wrote:
> > Add i.MX8MP PGC nodes for vpu, which are used to supply power for VPU.
> >
> > Signed-off-by: Peng Fan <peng.fan@nxp.com>
> > Signed-off-by: Shawn Guo <shawnguo@kernel.org>
> > ---
> >  arch/arm64/boot/dts/freescale/imx8mp.dtsi | 27
> > +++++++++++++++++++++++
> >  1 file changed, 27 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/freescale/imx8mp.dtsi
> > b/arch/arm64/boot/dts/freescale/imx8mp.dtsi
> > index 0b165f98a82c..34af983b0210 100644
> > --- a/arch/arm64/boot/dts/freescale/imx8mp.dtsi
> > +++ b/arch/arm64/boot/dts/freescale/imx8mp.dtsi
> > @@ -598,6 +598,33 @@ pgc_ispdwp: power-domain@18 {
> >                                                 reg =3D
> <IMX8MP_POWER_DOMAIN_MEDIAMIX_ISPDWP>;
> >                                                 clocks =3D <&clk IMX8MP=
_CLK_MEDIA_ISP_ROOT>;
> >                                         };
> > +
> > +                                       pgc_vpumix: power-domain@19 {
> > +                                               #power-domain-cells =3D=
 <0>;
> > +                                               reg =3D <IMX8MP_POWER_D=
OMAIN_VPUMIX>;
> > +                                               clocks =3D<&clk IMX8MP_=
CLK_VPU_ROOT>;
> > +                                       };
> > +
> > +                                       pgc_vpu_g1: power-domain@20 {
> > +                                               #power-domain-cells =3D=
 <0>;
> > +                                               power-domains =3D <&pgc=
_vpumix>;
> > +                                               reg =3D <IMX8MP_POWER_D=
OMAIN_VPU_G1>;
> > +                                               clocks =3D <&clk IMX8MP=
_CLK_VPU_G1_ROOT>;
> > +                                       };
> > +
> > +                                       pgc_vpu_g2: power-domain@21 {
> > +                                               #power-domain-cells =3D=
 <0>;
> > +                                               power-domains =3D <&pgc=
_vpumix>;
> > +                                               reg =3D <IMX8MP_POWER_D=
OMAIN_VPU_G2>;
> > +                                               clocks =3D <&clk IMX8MP=
_CLK_VPU_G2_ROOT>;
> > +                                       };
> > +
> > +                                       pgc_vpu_vc8000e: power-domain@2=
2 {
> > +                                               #power-domain-cells =3D=
 <0>;
> > +                                               power-domains =3D <&pgc=
_vpumix>;
> > +                                               reg =3D
> <IMX8MP_POWER_DOMAIN_VPU_VC8000E>;
> > +                                               clocks =3D <&clk
> IMX8MP_CLK_VPU_VC8KE_ROOT>;
> > +                                       };
> >                                 };
> >                         };
> >                 };
>=20
> This change causes new error messages to come out during boot, for
> example:
>=20
>     ...
>     imx-pgc imx-pgc-domain.8: failed to command PGC
>     imx-pgc imx-pgc-domain.8: failed to command PGC
>     imx-pgc imx-pgc-domain.8: failed to command PGC
>     30890000.serial: ttymxc1 at MMIO 0x30890000 (irq =3D 197, base_baud =
=3D
> 1500000) is a IMX
>     ...
>     hwmon hwmon1: temp1_input not attached to any thermal zone
>     imx-pgc imx-pgc-domain.8: failed to command PGC
>     imx-pgc imx-pgc-domain.8: failed to command PGC
>     imx-pgc imx-pgc-domain.8: failed to command PGC
>     ...
>=20
> They don't seem to cause any problems on the hardware I am using, well, a=
t
> least not that I have found so far.
>=20
> This first appeared for me in linux-6.1. But it is the same in todays lin=
ux 6.3-
> rc4. Reverting this change (not completely trivial due to a couple of com=
mits
> after it that rely on it) fixes it - no more errors.
[Peng Fan]=20

The VPU BLK CTRL seems not enabled.

Regards,
Peng.

>=20
> Regards
> Greg
>=20